From: kernel test robot <lkp@intel.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [axboe-block:net-accept-more 3/6] net/tipc/socket.c:2718: warning: Excess function parameter 'args' description in 'tipc_accept'
Date: Sat, 11 May 2024 05:18:49 +0800 [thread overview]
Message-ID: <202405110537.v42FdTY2-lkp@intel.com> (raw)
Hi Jens,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git net-accept-more
head: f91ebed7e4fc8fa21387924ecd9b6312908b3472
commit: a4b393e6ca8160d2ce71924c22f0cdf47108b1fd [3/6] net: change proto and proto_ops accept type
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240511/202405110537.v42FdTY2-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240511/202405110537.v42FdTY2-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405110537.v42FdTY2-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/tipc/socket.c:2718: warning: Function parameter or struct member 'arg' not described in 'tipc_accept'
>> net/tipc/socket.c:2718: warning: Excess function parameter 'args' description in 'tipc_accept'
vim +2718 net/tipc/socket.c
6398e23cdb1d80 Ying Xue 2014-01-17 2707
b97bf3fd8f6a16 Per Liden 2006-01-02 2708 /**
247f0f3c3176c5 Ying Xue 2014-02-18 2709 * tipc_accept - wait for connection request
b97bf3fd8f6a16 Per Liden 2006-01-02 2710 * @sock: listening socket
d8141208b032ea Andrew Lunn 2020-07-13 2711 * @new_sock: new socket that is to be connected
a4b393e6ca8160 Jens Axboe 2024-05-09 2712 * @args: arguments for accept
b97bf3fd8f6a16 Per Liden 2006-01-02 2713 *
637b77fdca5c5e Randy Dunlap 2020-11-29 2714 * Return: 0 on success, errno otherwise
b97bf3fd8f6a16 Per Liden 2006-01-02 2715 */
a4b393e6ca8160 Jens Axboe 2024-05-09 2716 static int tipc_accept(struct socket *sock, struct socket *new_sock,
a4b393e6ca8160 Jens Axboe 2024-05-09 2717 struct proto_accept_arg *arg)
b97bf3fd8f6a16 Per Liden 2006-01-02 @2718 {
0fef8f205f6f4c Paul Gortmaker 2012-12-04 2719 struct sock *new_sk, *sk = sock->sk;
301bae56f21295 Jon Paul Maloy 2014-08-22 2720 struct tipc_sock *new_tsock;
f8dd60de194817 Xin Long 2021-07-22 2721 struct msghdr m = {NULL,};
0fef8f205f6f4c Paul Gortmaker 2012-12-04 2722 struct tipc_msg *msg;
f8dd60de194817 Xin Long 2021-07-22 2723 struct sk_buff *buf;
6398e23cdb1d80 Ying Xue 2014-01-17 2724 long timeo;
0c3141e910eaaa Allan Stephens 2008-04-15 2725 int res;
b97bf3fd8f6a16 Per Liden 2006-01-02 2726
0c3141e910eaaa Allan Stephens 2008-04-15 2727 lock_sock(sk);
b97bf3fd8f6a16 Per Liden 2006-01-02 2728
0c288c86928e50 Parthasarathy Bhuvaragan 2016-11-01 2729 if (sk->sk_state != TIPC_LISTEN) {
0c3141e910eaaa Allan Stephens 2008-04-15 2730 res = -EINVAL;
0c3141e910eaaa Allan Stephens 2008-04-15 2731 goto exit;
0c3141e910eaaa Allan Stephens 2008-04-15 2732 }
a4b393e6ca8160 Jens Axboe 2024-05-09 2733 timeo = sock_rcvtimeo(sk, arg->flags & O_NONBLOCK);
6398e23cdb1d80 Ying Xue 2014-01-17 2734 res = tipc_wait_for_accept(sock, timeo);
0c3141e910eaaa Allan Stephens 2008-04-15 2735 if (res)
b97bf3fd8f6a16 Per Liden 2006-01-02 2736 goto exit;
b97bf3fd8f6a16 Per Liden 2006-01-02 2737
0c3141e910eaaa Allan Stephens 2008-04-15 2738 buf = skb_peek(&sk->sk_receive_queue);
0c3141e910eaaa Allan Stephens 2008-04-15 2739
a4b393e6ca8160 Jens Axboe 2024-05-09 2740 res = tipc_sk_create(sock_net(sock->sk), new_sock, 0, arg->kern);
0fef8f205f6f4c Paul Gortmaker 2012-12-04 2741 if (res)
0fef8f205f6f4c Paul Gortmaker 2012-12-04 2742 goto exit;
fdd75ea8df370f Stephen Smalley 2015-07-07 2743 security_sk_clone(sock->sk, new_sock->sk);
0fef8f205f6f4c Paul Gortmaker 2012-12-04 2744
0fef8f205f6f4c Paul Gortmaker 2012-12-04 2745 new_sk = new_sock->sk;
301bae56f21295 Jon Paul Maloy 2014-08-22 2746 new_tsock = tipc_sk(new_sk);
0fef8f205f6f4c Paul Gortmaker 2012-12-04 2747 msg = buf_msg(buf);
0c3141e910eaaa Allan Stephens 2008-04-15 2748
258f8667a29d72 Ying Xue 2012-12-03 2749 /* we lock on new_sk; but lockdep sees the lock on sk */
258f8667a29d72 Ying Xue 2012-12-03 2750 lock_sock_nested(new_sk, SINGLE_DEPTH_NESTING);
0c3141e910eaaa Allan Stephens 2008-04-15 2751
0c3141e910eaaa Allan Stephens 2008-04-15 2752 /*
0c3141e910eaaa Allan Stephens 2008-04-15 2753 * Reject any stray messages received by new socket
0c3141e910eaaa Allan Stephens 2008-04-15 2754 * before the socket lock was taken (very, very unlikely)
0c3141e910eaaa Allan Stephens 2008-04-15 2755 */
49afb806cb650d Tuong Lien 2020-01-08 2756 tsk_rej_rx_queue(new_sk, TIPC_ERR_NO_PORT);
0c3141e910eaaa Allan Stephens 2008-04-15 2757
0c3141e910eaaa Allan Stephens 2008-04-15 2758 /* Connect new socket to it's peer */
301bae56f21295 Jon Paul Maloy 2014-08-22 2759 tipc_sk_finish_conn(new_tsock, msg_origport(msg), msg_orignode(msg));
b97bf3fd8f6a16 Per Liden 2006-01-02 2760
095ae612530c94 Christoph Hellwig 2020-05-28 2761 tsk_set_importance(new_sk, msg_importance(msg));
b97bf3fd8f6a16 Per Liden 2006-01-02 2762 if (msg_named(msg)) {
14623e005a1e74 Jon Maloy 2021-06-02 2763 new_tsock->conn_addrtype = TIPC_SERVICE_ADDR;
14623e005a1e74 Jon Maloy 2021-06-02 2764 msg_set_nametype(&new_tsock->phdr, msg_nametype(msg));
14623e005a1e74 Jon Maloy 2021-06-02 2765 msg_set_nameinst(&new_tsock->phdr, msg_nameinst(msg));
b97bf3fd8f6a16 Per Liden 2006-01-02 2766 }
b97bf3fd8f6a16 Per Liden 2006-01-02 2767
b97bf3fd8f6a16 Per Liden 2006-01-02 2768 /*
f8dd60de194817 Xin Long 2021-07-22 2769 * Respond to 'SYN-' by discarding it & returning 'ACK'.
f8dd60de194817 Xin Long 2021-07-22 2770 * Respond to 'SYN+' by queuing it on new socket & returning 'ACK'.
b97bf3fd8f6a16 Per Liden 2006-01-02 2771 */
b97bf3fd8f6a16 Per Liden 2006-01-02 2772 if (!msg_data_sz(msg)) {
2e84c60b77e4dd Jon Paul Maloy 2014-08-22 2773 tsk_advance_rx_queue(sk);
b97bf3fd8f6a16 Per Liden 2006-01-02 2774 } else {
0c3141e910eaaa Allan Stephens 2008-04-15 2775 __skb_dequeue(&sk->sk_receive_queue);
0c3141e910eaaa Allan Stephens 2008-04-15 2776 __skb_queue_head(&new_sk->sk_receive_queue, buf);
aba79f332f46ca Ying Xue 2013-01-20 2777 skb_set_owner_r(buf, new_sk);
b97bf3fd8f6a16 Per Liden 2006-01-02 2778 }
11a4d6f67cf558 Tung Nguyen 2023-02-14 2779 iov_iter_kvec(&m.msg_iter, ITER_SOURCE, NULL, 0, 0);
f8dd60de194817 Xin Long 2021-07-22 2780 __tipc_sendstream(new_sock, &m, 0);
0c3141e910eaaa Allan Stephens 2008-04-15 2781 release_sock(new_sk);
b97bf3fd8f6a16 Per Liden 2006-01-02 2782 exit:
0c3141e910eaaa Allan Stephens 2008-04-15 2783 release_sock(sk);
b97bf3fd8f6a16 Per Liden 2006-01-02 2784 return res;
b97bf3fd8f6a16 Per Liden 2006-01-02 2785 }
b97bf3fd8f6a16 Per Liden 2006-01-02 2786
:::::: The code at line 2718 was first introduced by commit
:::::: b97bf3fd8f6a16966d4f18983b2c40993ff937d4 [TIPC] Initial merge
:::::: TO: Per Liden <per.liden@nospam.ericsson.com>
:::::: CC: David S. Miller <davem@sunset.davemloft.net>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-05-10 21:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405110537.v42FdTY2-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.