From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19168A41 for ; Sat, 11 May 2024 06:39:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715409578; cv=none; b=oJj9Y80kMee+SyPsljNfFcu2uAa8e7kdTZ8ljhjqWlQTkqLJXoyEfPodF0Ss68kk7rwfCh4+RvTHG7A851DlSkZWEFAT9jPvJTl1amnrT3WVZIieEqMgHzUovTBWlLD6v9jGGN438SmC95SvSsBIr4nySud3O9NOGcJg/k7X22Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715409578; c=relaxed/simple; bh=ohIU0BNbyMtZNdVZlUNr4IqV8gPhaMqQ1agVuP69fhM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kDXACV6rsT+Uf1ZTACfcaXyew2H3b9m+qQv01yWWkmahKf62H/jhVdVybJcuSGwro7vBQJAT6eZOOI51HucvVovNKPkIzkOVNVildhRrbnW31RRD3C3MBxugaOtCJebX+dMDkMERmbuESiIIrA7UxWSWBbT97g1oClJNP5OquIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=g6QWFToX; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g6QWFToX" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-5e42b4bbfa4so1593462a12.1 for ; Fri, 10 May 2024 23:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715409575; x=1716014375; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8ZGOyYQlPMjCo7NoBFPkuXTj+4higrK3cJrWnMzKiEg=; b=g6QWFToXQok+V3jhWb2TA3WU/cfN+txc45PKhItOMk96vdRAEaANIWx+gFttgrZYl+ FaI0gNYJJUlNVBsU0WD281elonouHMH79bVjcJIcikEn7fIQq+1qOAg7Oyvqny8ZxMB5 UcM/tzNUBRzotnXfpSVPX9quL1B3mOqbutzAuG5Wrt+3AXVoayqJf6ylehJpcRzJu5fd qJVZl66V3RmCFsyB3I0stWXqVJg3DXjGQyIy5APlEfcU179nQ2E5nYyP5RHRbvbKn+dW EbWLXROGUq5dwKFMtKiMiVJu7m3KL6nm00/lA8Yx6c6eyL9A+Xp7pBdaZWNtUd8iCsmH QoWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715409575; x=1716014375; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8ZGOyYQlPMjCo7NoBFPkuXTj+4higrK3cJrWnMzKiEg=; b=jknfH3QkiF7YukPO2GPNnPDDkKrGx5eGfH722ax9vIx2bzOce9t2Lmy458A4YE/vCK u++cHAeNyBVmwKGznJx1txUeI5wFQIA850xBRdTYGEqUOBq5Ez84l1PFLN5+zF8HL6C/ VdL8n2lXoKEhrXp0CWTHhSL/LQeubolGP2yrKcNcrv4ph3cmbDl9flxEM4FxIyrCj8Lz bc2YR7I8QOpUyoM7jFSeDi37z9O8WGFPq8ixn6NOMxD5PH51IZvZj0K6WZVYf7Ww8x+n R4E3p1+vgv0q0M19D5Re3tlm+3bJL7IZnsJinuKPPDqSr9+SEcbmyzR2b7nm5XyPLxvR HXeA== X-Forwarded-Encrypted: i=1; AJvYcCXgW8u78cv0fxrCj4tcwI+l3hYuCBbB2w4BeY2bnQyVv+C3VoP7NHXIMDsrE+P7bAyQ25DwlHEuskrGri1e+zQ9q45jZQBiFvjhUUkQoA== X-Gm-Message-State: AOJu0YyUO8uEsNtTl4LHV8i6FdWU/0VS94nozuJAubwShMJgI5g9p63w Tvf9MPreMacuGjrJgBD2XdFndc9oymXpc+0SXKfDVtgmFjGMSgwlsQPeGakjSQ== X-Google-Smtp-Source: AGHT+IFcPHdwaLWt2eocdN1RJhFnTd98pYEBepeLkuj7kAaEyXPW4pVze6C7JF/k2OT36e+fxjw+tA== X-Received: by 2002:a05:6a20:dc95:b0:1a7:60d8:a6dd with SMTP id adf61e73a8af0-1afde1df3b4mr5538644637.53.1715409575282; Fri, 10 May 2024 23:39:35 -0700 (PDT) Received: from thinkpad ([220.158.156.38]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2b671056629sm4242175a91.7.2024.05.10.23.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 23:39:34 -0700 (PDT) Date: Sat, 11 May 2024 12:09:29 +0530 From: Manivannan Sadhasivam To: Alexandru Gagniuc Cc: Bjorn Andersson , Konrad Dybcio , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v4 RESEND 5/8] PCI: qcom: Add support for IPQ9574 Message-ID: <20240511063929.GB6672@thinkpad> References: <20240501042847.1545145-1-mr.nuke.me@gmail.com> <20240501042847.1545145-6-mr.nuke.me@gmail.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240501042847.1545145-6-mr.nuke.me@gmail.com> On Tue, Apr 30, 2024 at 11:28:44PM -0500, Alexandru Gagniuc wrote: > IPQ9574 has four PCIe controllers: two single-lane Gen3, and two > dual-lane Gen3. The controllers are identical from a software You mean to say, 'identical to IPQ8074 Gen3 platform' since you are reusing the 2_9_0 cfg? > perspective, with the differences appearing in the PHYs. > > Add a compatible for the PCIe on IPQ9574. > > Signed-off-by: Alexandru Gagniuc But the change looks good to me. Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index ea81ff68d433..e61888e6c63d 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1551,6 +1551,7 @@ static const struct of_device_id qcom_pcie_match[] = { > { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, > { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, > { .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 }, > + { .compatible = "qcom,pcie-ipq9574", .data = &cfg_2_9_0 }, > { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, > { .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 }, > { .compatible = "qcom,pcie-sa8540p", .data = &cfg_sc8280xp }, > -- > 2.40.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3ACAC04FFE for ; Sat, 11 May 2024 06:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vIQmc9jFAejcDsH+0VPM2HXutya5GSyxiZ2vD8LD0P4=; b=uKDkhlMWn/EL2C CXEmg5YQ0P1V8OT8/3k3itYSHv1nprjzy0wjKStMgHGvxVnWZkM5aIlkrvFED8TN0/PFq68uOdQGI PyYdZKPZ9pY2MYXdJWneNCI5NfrGCn1ZSvY3WAPV3sD5WXWc1sPdvvbJ4MPpZYdaJV8/TPqhrdRyu vs/HFr/qz5Ys44gym7O3oWZTs/byfyslgqijoem5a3GXBRmZKP9zeMpASUEH7FC5vMUILTUiyQBGY qmCnHpnBw7wqsCS3ssR5q8w8J2XawF+EzdcbwOFeqRbXYsoG3zYCC8fpfgL7b+RjI6JWuYgxKV1a9 OaFgFiJ7ajNET/GyqSbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5gOY-00000007P08-0Ayk; Sat, 11 May 2024 06:39:46 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5gOT-00000007Oyc-2Y7W for linux-phy@lists.infradead.org; Sat, 11 May 2024 06:39:44 +0000 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-53fbf2c42bfso1952080a12.3 for ; Fri, 10 May 2024 23:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715409575; x=1716014375; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8ZGOyYQlPMjCo7NoBFPkuXTj+4higrK3cJrWnMzKiEg=; b=n4ds9K1Y9+ZXjajD4yvn13pe5VrSX9yzhicxSvxg7bd9ud3QZzkpTnN3xgZNEa8+k4 WA6dE3AKjXbUodOzdGx7hLdEjv4QMvLKcrYq5Sva8z4R8v9NNTyS2RR2tGlhbj7qDcK2 6UW/R4lJyV0v+5qU+Z7EOcvxXDhJJE2HEwslzIfcAZ9dIe2HDvN+Nh9aKWnhTTAglRCD 2LoRTTETx+iueaWVUtOgwa9iwn+l+8kkL9DcykRBLpSRAoBlBzFz1cNlmC/LmnKvLL7t tP2w3HlC/8HoIHzcD0QK6fzLJmNj0aKk6lUU4tNAEiljlSONi7z9MXWrC95S90CW4Im9 2hIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715409575; x=1716014375; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8ZGOyYQlPMjCo7NoBFPkuXTj+4higrK3cJrWnMzKiEg=; b=fmezqPRAz8h1vcvYYvSzV8WYWIpTbSmFiOcyWDSd6rzp7NXciNbnlhgC/9FpLCjiLT ST5yjFtRLD3GN3Gei+h/DtbLJldqBKNzdZy2nW3XwkrX8v3yXWZZDaAmK6D6OE8DFY+f p++UqxNhKk49woqgQhCKYULCc6inYDrSZs7zg5nAFnCrG+PoRJOE9dconFalgOMo792k WeFpB8zJMwDk7aWK9KBvY+MJL8UCTJg1UAbOHSJL7O7TWOPLZF9J2yywsVLTnD6b3VdB tKZbu55QBt3qgHOUr1L5c69GJ3PoRZ/7qsKRzXJy4DwxOQGSa4qNmZ2DyL6Kuis8tP/Z 7e/g== X-Forwarded-Encrypted: i=1; AJvYcCUf1QgvKlMRVIEuY3WA1NXONhdLRDSVLwcIBryAoFE9Q4cibTqT8BDbD0k98Vd658pT4lkyKNSu0xfrWksDoETtVp/udI3Yd92Pq9F1zQ== X-Gm-Message-State: AOJu0YxYt4AtMdwB61SEfZfkmB4VEdDrnnHcBOnvd8TuS8wXj7CDcxo9 wjJqBynuzkPLwYvKOryBs8gjgXYrJXpDAPfLC65iiNodyratKRhbg7lbzDBjMA== X-Google-Smtp-Source: AGHT+IFcPHdwaLWt2eocdN1RJhFnTd98pYEBepeLkuj7kAaEyXPW4pVze6C7JF/k2OT36e+fxjw+tA== X-Received: by 2002:a05:6a20:dc95:b0:1a7:60d8:a6dd with SMTP id adf61e73a8af0-1afde1df3b4mr5538644637.53.1715409575282; Fri, 10 May 2024 23:39:35 -0700 (PDT) Received: from thinkpad ([220.158.156.38]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2b671056629sm4242175a91.7.2024.05.10.23.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 23:39:34 -0700 (PDT) Date: Sat, 11 May 2024 12:09:29 +0530 From: Manivannan Sadhasivam To: Alexandru Gagniuc Cc: Bjorn Andersson , Konrad Dybcio , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v4 RESEND 5/8] PCI: qcom: Add support for IPQ9574 Message-ID: <20240511063929.GB6672@thinkpad> References: <20240501042847.1545145-1-mr.nuke.me@gmail.com> <20240501042847.1545145-6-mr.nuke.me@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240501042847.1545145-6-mr.nuke.me@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240510_233941_778296_7B6C317A X-CRM114-Status: GOOD ( 16.38 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMzAsIDIwMjQgYXQgMTE6Mjg6NDRQTSAtMDUwMCwgQWxleGFuZHJ1IEdhZ25p dWMgd3JvdGU6Cj4gSVBROTU3NCBoYXMgZm91ciBQQ0llIGNvbnRyb2xsZXJzOiB0d28gc2luZ2xl LWxhbmUgR2VuMywgYW5kIHR3bwo+IGR1YWwtbGFuZSBHZW4zLiBUaGUgY29udHJvbGxlcnMgYXJl IGlkZW50aWNhbCBmcm9tIGEgc29mdHdhcmUKCllvdSBtZWFuIHRvIHNheSwgJ2lkZW50aWNhbCB0 byBJUFE4MDc0IEdlbjMgcGxhdGZvcm0nIHNpbmNlIHlvdSBhcmUgcmV1c2luZyB0aGUKMl85XzAg Y2ZnPwoKPiBwZXJzcGVjdGl2ZSwgd2l0aCB0aGUgZGlmZmVyZW5jZXMgYXBwZWFyaW5nIGluIHRo ZSBQSFlzLgo+IAo+IEFkZCBhIGNvbXBhdGlibGUgZm9yIHRoZSBQQ0llIG9uIElQUTk1NzQuCj4g Cj4gU2lnbmVkLW9mZi1ieTogQWxleGFuZHJ1IEdhZ25pdWMgPG1yLm51a2UubWVAZ21haWwuY29t PgoKQnV0IHRoZSBjaGFuZ2UgbG9va3MgZ29vZCB0byBtZS4KClJldmlld2VkLWJ5OiBNYW5pdmFu bmFuIFNhZGhhc2l2YW0gPG1hbml2YW5uYW4uc2FkaGFzaXZhbUBsaW5hcm8ub3JnPgoKLSBNYW5p Cgo+IC0tLQo+ICBkcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLXFjb20uYyB8IDEgKwo+ ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1xY29tLmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVy L2R3Yy9wY2llLXFjb20uYwo+IGluZGV4IGVhODFmZjY4ZDQzMy4uZTYxODg4ZTZjNjNkIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtcWNvbS5jCj4gKysrIGIv ZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpZS1xY29tLmMKPiBAQCAtMTU1MSw2ICsxNTUx LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgcWNvbV9wY2llX21hdGNoW10g PSB7Cj4gIAl7IC5jb21wYXRpYmxlID0gInFjb20scGNpZS1pcHE4MDY0LXYyIiwgLmRhdGEgPSAm Y2ZnXzJfMV8wIH0sCj4gIAl7IC5jb21wYXRpYmxlID0gInFjb20scGNpZS1pcHE4MDc0IiwgLmRh dGEgPSAmY2ZnXzJfM18zIH0sCj4gIAl7IC5jb21wYXRpYmxlID0gInFjb20scGNpZS1pcHE4MDc0 LWdlbjMiLCAuZGF0YSA9ICZjZmdfMl85XzAgfSwKPiArCXsgLmNvbXBhdGlibGUgPSAicWNvbSxw Y2llLWlwcTk1NzQiLCAuZGF0YSA9ICZjZmdfMl85XzAgfSwKPiAgCXsgLmNvbXBhdGlibGUgPSAi cWNvbSxwY2llLW1zbTg5OTYiLCAuZGF0YSA9ICZjZmdfMl8zXzIgfSwKPiAgCXsgLmNvbXBhdGli bGUgPSAicWNvbSxwY2llLXFjczQwNCIsIC5kYXRhID0gJmNmZ18yXzRfMCB9LAo+ICAJeyAuY29t cGF0aWJsZSA9ICJxY29tLHBjaWUtc2E4NTQwcCIsIC5kYXRhID0gJmNmZ19zYzgyODB4cCB9LAo+ IC0tIAo+IDIuNDAuMQo+IAoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDgrprgrqTg rr7grprgrr/grrXgrq7gr40KCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LXBoeQo=