All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-iio@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] iio: Drop explicit initialization of struct i2c_device_id::driver_data to 0
Date: Sat, 11 May 2024 14:20:06 +0100	[thread overview]
Message-ID: <20240511142006.27facd74@jic23-huawei> (raw)
In-Reply-To: <20240508072928.2135858-2-u.kleine-koenig@pengutronix.de>

On Wed,  8 May 2024 09:29:27 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> These drivers don't use the driver_data member of struct i2c_device_id,
> so don't explicitly initialize this member.
> 
> This prepares putting driver_data in an anonymous union which requires
> either no initialization or named designators. But it's also a nice
> cleanup on its own.
> 
> While add it, also remove commas after the sentinel entries.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> I didn't add all the individual maintainers to Cc and put the iio changes in a
> single patch. If you want I can split per driver (or per iio subdirectory?),
> just tell me if you prefer it that way.

I don't mind a single patch as resolving any backporting issues around this
should be easy. 

Whilst your changes for driver_data in struct i2c_device_id obviously don't
need it, maybe it's worth similar patches to cleanup acpi_device_id and
of_device_id tables with pointless 0 initialisation?

Applied this with some conflicts in bmi160 resolved by hand.

Applied to the togreg branch of iio.git but only pushed out for now as testing
to let 0-day look at it. I'll rebase on 6.10-rc1 once available.

Thanks,

Jonathan



  reply	other threads:[~2024-05-11 13:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-08  7:29 [PATCH] iio: Drop explicit initialization of struct i2c_device_id::driver_data to 0 Uwe Kleine-König
2024-05-11 13:20 ` Jonathan Cameron [this message]
2024-05-12 11:41   ` Uwe Kleine-König
2024-05-12 11:47     ` Jonathan Cameron
2024-05-12 20:44       ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240511142006.27facd74@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.