From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9CAFC04FFE for ; Sat, 11 May 2024 17:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/6Ium8YoOWYrXMI3HN7nbjtGIt3Ki7krFZJBKYbVilw=; b=uyGTeiLL9LtbSy 1zO/0QkPcf+Tgtb/p4+lgVijIg0kcmuqnanW5MiskTxLkrDeULnIyNY7XuUibOBquUYGXX04hHqCT IFtmOiisRSIenosMkzOEo7KYYd7WOWzBwArxv0pDKiAWXZ7F8dpRRhmCXxj+3gCydsSqbewCOWi89 cLbLAlfZx1GrL5rnxMNr8DBczg7+Jt7xFjDBE7sK6sCz71c9w0aObfsXdBSVP2ALh1N3aHleb57xW iYpEKrdHybnPm0biEj+5hcYk0ZsJG5v696IHvIQ+ABCVZLnh/PybW3HrlMe9/7plW2yHIE/kC3rk1 6XILWnPqd1OYo45COlWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5qiu-00000008OMd-0ro6; Sat, 11 May 2024 17:41:28 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5qir-00000008OM1-0uUf for linux-arm-kernel@lists.infradead.org; Sat, 11 May 2024 17:41:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 15A18CE0622; Sat, 11 May 2024 17:41:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80238C2BBFC; Sat, 11 May 2024 17:41:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715449280; bh=Dlo88TYjJ2dqpMbh1XVRqvHEvnVqfca8m0hFFGpWvgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NEeFkol3mXfZbArM4ITEYgwWMmg7Z6pFFK8e0IQqzNP0sCFg9u3/pIwrZBWBAYdXS 5YMDxVVF7OWz40LLpfVEv6D9TXoJzxf1qWJysoWgJjgrasdtG9ULu50TxYjc8uL3Hx 7uHepVIOL4zkj9bfM1s9MisdLQrGjJpGOVa69fqz4wUq4UISYVIwjFwM4EPO8a2X91 XVLq1kJX8yC0GeWWrODGAdBWZ22gIuWM5v84v4WiMTLXr90GKcLZ736o5ksBC4E1AN uj0hP3khmqYOLNwKDlz4odl0JrptzAqcWHsANlZnrgzvOqMrmKHmkfGyWqLjT2hMkT WsnL8dZE68vIA== Date: Sat, 11 May 2024 18:41:12 +0100 From: Simon Horman To: Xiaolei Wang Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, richardcochran@gmail.com, bartosz.golaszewski@linaro.org, rohan.g.thomas@intel.com, rmk+kernel@armlinux.org.uk, fancer.lancer@gmail.com, ahalaney@redhat.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [net PATCH v5 2/2] net: stmmac: move the EST structure to struct stmmac_priv Message-ID: <20240511174112.GS2347895@kernel.org> References: <20240510122155.3394723-1-xiaolei.wang@windriver.com> <20240510122155.3394723-3-xiaolei.wang@windriver.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240510122155.3394723-3-xiaolei.wang@windriver.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240511_104125_461119_3E23AF20 X-CRM114-Status: GOOD ( 15.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2024 at 08:21:55PM +0800, Xiaolei Wang wrote: > Move the EST structure to struct stmmac_priv, because the > EST configs don't look like platform config, but EST is > enabled in runtime with the settings retrieved for the TC > TAPRIO feature also in runtime. So it's better to have the > EST-data preserved in the driver private data instead of > the platform data storage. > > Signed-off-by: Xiaolei Wang Patch 1/2 of this series is a fix for net, with a Fixes tag. IMHO, it looks good. This patch, however, is a clean-up/enhancement. It doesn't have a Fixes tag, which is good. But I think it should be targeted at net-next (once patch 1/2 has been accepted into net, and net has been merged into net-next; also, given the timing, once net-next reopens as It's likely to close rather soon for the merge window). Perhaps it is possible for the maintainers to pick up patch 1/2, leaving this patch as follow-up. The above notwithstanding, this patch looks good to me. Reviewed-by: Simon Horman -- pw-bot: under-review _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DFDF7F; Sat, 11 May 2024 17:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715449281; cv=none; b=K7ie/K7WS+IXvpAOEzUSwZlRqNC66GohNYAZbafs/CRsp7cnHusX1KMUqQUT9C6bFE8STteCQDMIUn9twty8ovSZPuLEVR7uBNWbTUbnk/oOWM+tlGp4TM+wXSuXjK2REj/r3N5EAIXbY8o447ODpksM80L25h7J0GQqzMqWEeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715449281; c=relaxed/simple; bh=Dlo88TYjJ2dqpMbh1XVRqvHEvnVqfca8m0hFFGpWvgI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fRaE+A/9uG+K+nYz0f9AnB91oHkdXQFBKi4CvvLgkgVYr2/wkSUv1nfrXyZgIyoWxB0ByKI/OK/ugR0wvE2EC7udBaB8x9ftoM5GgSYmLhRBmDvXsrjc3ftyHrlZR0FMfWrqKKdG3Zrl8GTV+FlSejEfSiYBSMfYZReK3UWKkSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NEeFkol3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NEeFkol3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80238C2BBFC; Sat, 11 May 2024 17:41:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715449280; bh=Dlo88TYjJ2dqpMbh1XVRqvHEvnVqfca8m0hFFGpWvgI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NEeFkol3mXfZbArM4ITEYgwWMmg7Z6pFFK8e0IQqzNP0sCFg9u3/pIwrZBWBAYdXS 5YMDxVVF7OWz40LLpfVEv6D9TXoJzxf1qWJysoWgJjgrasdtG9ULu50TxYjc8uL3Hx 7uHepVIOL4zkj9bfM1s9MisdLQrGjJpGOVa69fqz4wUq4UISYVIwjFwM4EPO8a2X91 XVLq1kJX8yC0GeWWrODGAdBWZ22gIuWM5v84v4WiMTLXr90GKcLZ736o5ksBC4E1AN uj0hP3khmqYOLNwKDlz4odl0JrptzAqcWHsANlZnrgzvOqMrmKHmkfGyWqLjT2hMkT WsnL8dZE68vIA== Date: Sat, 11 May 2024 18:41:12 +0100 From: Simon Horman To: Xiaolei Wang Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, richardcochran@gmail.com, bartosz.golaszewski@linaro.org, rohan.g.thomas@intel.com, rmk+kernel@armlinux.org.uk, fancer.lancer@gmail.com, ahalaney@redhat.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [net PATCH v5 2/2] net: stmmac: move the EST structure to struct stmmac_priv Message-ID: <20240511174112.GS2347895@kernel.org> References: <20240510122155.3394723-1-xiaolei.wang@windriver.com> <20240510122155.3394723-3-xiaolei.wang@windriver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510122155.3394723-3-xiaolei.wang@windriver.com> On Fri, May 10, 2024 at 08:21:55PM +0800, Xiaolei Wang wrote: > Move the EST structure to struct stmmac_priv, because the > EST configs don't look like platform config, but EST is > enabled in runtime with the settings retrieved for the TC > TAPRIO feature also in runtime. So it's better to have the > EST-data preserved in the driver private data instead of > the platform data storage. > > Signed-off-by: Xiaolei Wang Patch 1/2 of this series is a fix for net, with a Fixes tag. IMHO, it looks good. This patch, however, is a clean-up/enhancement. It doesn't have a Fixes tag, which is good. But I think it should be targeted at net-next (once patch 1/2 has been accepted into net, and net has been merged into net-next; also, given the timing, once net-next reopens as It's likely to close rather soon for the merge window). Perhaps it is possible for the maintainers to pick up patch 1/2, leaving this patch as follow-up. The above notwithstanding, this patch looks good to me. Reviewed-by: Simon Horman -- pw-bot: under-review