All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Jitendra Vegiraju <jitendra.vegiraju@broadcom.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com,
	bcm-kernel-feedback-list@broadcom.com,
	alexandre.torgue@foss.st.com, joabreu@synopsys.com,
	mcoquelin.stm32@gmail.com, richardcochran@gmail.com,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2, net-next, 2/2] net: stmmac: PCI driver for BCM8958X SoC
Date: Sun, 12 May 2024 09:35:18 +0100	[thread overview]
Message-ID: <20240512083518.GX2347895@kernel.org> (raw)
In-Reply-To: <20240511015924.41457-1-jitendra.vegiraju@broadcom.com>

On Fri, May 10, 2024 at 06:59:24PM -0700, Jitendra Vegiraju wrote:
> Broadcom BCM8958X SoCs use Synopsys XGMAC design, which is similar to
> dwxgmac2 core implementation in stmmac driver. The existing dwxgmac2 dma
> operation functions have some conflicting differences with BCM8958X.
> This glue driver attempts to reuse dwxgmac2 implementation wherever
> possible, adding alternative implementations where necessary.
> 
> v2: code cleanup to address patchwork reports.
> 
> Signed-off-by: Jitendra Vegiraju <jitendra.vegiraju@broadcom.com>

...

> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-brcm.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-brcm.c

...

> +static struct mac_device_info *dwxgmac_brcm_setup(void *ppriv)
> +{
> +	struct mac_device_info *mac;
> +	struct stmmac_priv *priv = ppriv;

Hi, Jitendra,

A minor nit from my side.

Please consider using reverse xmas tree order - longest line to shortest -
for new Networking code.

This tool can be of assistance: https://github.com/ecree-solarflare/xmastree

...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Jitendra Vegiraju <jitendra.vegiraju@broadcom.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com,
	bcm-kernel-feedback-list@broadcom.com,
	alexandre.torgue@foss.st.com, joabreu@synopsys.com,
	mcoquelin.stm32@gmail.com, richardcochran@gmail.com,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2, net-next, 2/2] net: stmmac: PCI driver for BCM8958X SoC
Date: Sun, 12 May 2024 09:35:18 +0100	[thread overview]
Message-ID: <20240512083518.GX2347895@kernel.org> (raw)
In-Reply-To: <20240511015924.41457-1-jitendra.vegiraju@broadcom.com>

On Fri, May 10, 2024 at 06:59:24PM -0700, Jitendra Vegiraju wrote:
> Broadcom BCM8958X SoCs use Synopsys XGMAC design, which is similar to
> dwxgmac2 core implementation in stmmac driver. The existing dwxgmac2 dma
> operation functions have some conflicting differences with BCM8958X.
> This glue driver attempts to reuse dwxgmac2 implementation wherever
> possible, adding alternative implementations where necessary.
> 
> v2: code cleanup to address patchwork reports.
> 
> Signed-off-by: Jitendra Vegiraju <jitendra.vegiraju@broadcom.com>

...

> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-brcm.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-brcm.c

...

> +static struct mac_device_info *dwxgmac_brcm_setup(void *ppriv)
> +{
> +	struct mac_device_info *mac;
> +	struct stmmac_priv *priv = ppriv;

Hi, Jitendra,

A minor nit from my side.

Please consider using reverse xmas tree order - longest line to shortest -
for new Networking code.

This tool can be of assistance: https://github.com/ecree-solarflare/xmastree

...

  parent reply	other threads:[~2024-05-12  8:35 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10  0:03 [PATCH, net-next, 0/2] net: stmmac: support for BCM8958x SoC Jitendra Vegiraju
2024-05-10  0:03 ` [PATCH, net-next, 1/2] net: stmmac: Export dma_ops for reuse in glue drivers Jitendra Vegiraju
2024-05-10  0:03 ` [PATCH, net-next, 2/2] net: stmmac: PCI driver for BCM8958X SoC Jitendra Vegiraju
2024-05-11  1:35   ` Jakub Kicinski
2024-05-11  1:59   ` [PATCH v2, " Jitendra Vegiraju
2024-05-11  1:59     ` Jitendra Vegiraju
2024-05-11  2:08     ` Jakub Kicinski
2024-05-11  2:08       ` Jakub Kicinski
2024-05-13 16:47       ` Jitendra Vegiraju
2024-05-13 16:47         ` Jitendra Vegiraju
2024-05-11 16:16     ` Andrew Lunn
2024-05-11 16:16       ` Andrew Lunn
2024-05-11 17:12       ` Russell King (Oracle)
2024-05-11 17:12         ` Russell King (Oracle)
2024-05-11 17:19         ` Andrew Lunn
2024-05-11 17:19           ` Andrew Lunn
2024-05-11 19:35           ` Russell King (Oracle)
2024-05-11 19:35             ` Russell King (Oracle)
2024-05-11 17:50         ` Andrew Lunn
2024-05-11 17:50           ` Andrew Lunn
2024-05-11 19:36           ` Russell King (Oracle)
2024-05-11 19:36             ` Russell King (Oracle)
2024-05-13 17:32           ` Jitendra Vegiraju
2024-05-13 17:32             ` Jitendra Vegiraju
2024-05-13 18:07             ` Andrew Lunn
2024-05-13 18:07               ` Andrew Lunn
2024-05-14  8:19             ` Russell King (Oracle)
2024-05-14  8:19               ` Russell King (Oracle)
2024-05-14 16:18               ` Florian Fainelli
2024-05-14 16:18                 ` Florian Fainelli
2024-05-11 19:34     ` Russell King (Oracle)
2024-05-11 19:34       ` Russell King (Oracle)
2024-05-13 17:38       ` Jitendra Vegiraju
2024-05-13 17:38         ` Jitendra Vegiraju
2024-05-13 17:41         ` Russell King (Oracle)
2024-05-13 17:41           ` Russell King (Oracle)
2024-05-13 19:52           ` Andrew Lunn
2024-05-13 19:52             ` Andrew Lunn
2024-05-12  8:35     ` Simon Horman [this message]
2024-05-12  8:35       ` Simon Horman
2024-05-17 23:50   ` [PATCH, " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240512083518.GX2347895@kernel.org \
    --to=horms@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jitendra.vegiraju@broadcom.com \
    --cc=joabreu@synopsys.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.