From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Romain Naour <romain.naour@gmail.com>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] toolchain/Config.in: enable libatomic with BR2_BINFMT_FLAT
Date: Sun, 12 May 2024 10:15:07 +0200 [thread overview]
Message-ID: <20240512101507.5b678cd4@windsurf> (raw)
In-Reply-To: <CAPi7W808FakSM3CDpHEDrVh4HgHgfbZjd0SzK0W-pav1ub=3ww@mail.gmail.com>
Hello Fabrice,
On Tue, 12 Mar 2024 08:18:35 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> How should I proceed for my v2?
> Should I replace !BR2_BINFMT_FLAT by (!BR2_BINFMT_FLAT=y ||
> (BR2_TOOLCHAIN_GCC_AT_LEAST_10 && BR2_arm))?
> An other option would be to add default y if
> BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARMV7M_UCLIBC_STABLE (more simple but
> ugly).
The latter is indeed ugly. Something like the below?
config BR2_TOOLCHAIN_HAS_LIBATOMIC
bool
default y if BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_BINFMT_ELF || (BR2_BINFMT_FLAT && BR2_arm && BR2_TOOLCHAIN_GCC_AT_LEAST_10)
What do you think ? The comment above the BR2_TOOLCHAIN_HAS_LIBATOMIC
would need to be updated accordingly, of course.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-05-12 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 12:28 [Buildroot] [PATCH 1/1] toolchain/Config.in: enable libatomic with BR2_BINFMT_FLAT Fabrice Fontaine
2024-03-07 12:49 ` Thomas Petazzoni via buildroot
2024-03-07 17:18 ` Fabrice Fontaine
2024-03-11 11:35 ` Thomas Petazzoni via buildroot
2024-03-12 7:18 ` Fabrice Fontaine
2024-05-12 8:15 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240512101507.5b678cd4@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=romain.naour@gmail.com \
--cc=thomas.de_schampheleire@nokia.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.