All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
To: buildroot@buildroot.org
Cc: Roy Kollen Svendsen <roy.kollen.svendsen@akersolutions.com>,
	Samuel Martin <s.martin49@gmail.com>,
	Roy Kollen Svendsen <roykollensvendsen@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Zoltan Gyarmati <zgyarmati@zgyarmati.de>,
	Jesse Van Gavere <jesseevg@gmail.com>
Subject: [Buildroot] [PATCH v3 08/14] package/qt6/qt6declarative: fix build when Qt Network not available
Date: Sun, 12 May 2024 13:45:55 +0200	[thread overview]
Message-ID: <20240512114617.2564569-8-roykollensvendsen@gmail.com> (raw)
In-Reply-To: <20240512114617.2564569-1-roykollensvendsen@gmail.com>

From: Roy Kollen Svendsen <roy.kollen.svendsen@akersolutions.com>

Avoid checking for FEATURE_ssl when FEATURE_network is not available.

The failure occurs because FEATURE_ssl is defined by the Qt Network
module. So we check for FEATURE_network before we check for
FEATURE_ssl.

Fixes the following build failure:

CMake Error at qt6base-6.7.0/cmake/QtFeature.cmake:376 (message):
  Attempting to evaluate feature ssl but its definition is missing.  Either
  the feature does not exist or a dependency to the module that defines it is
  missing
Call Stack (most recent call first):
  qt6base-6.7.0/cmake/QtFeature.cmake:141 (qt_evaluate_feature)
  qt6base-6.7.0/cmake/QtFeature.cmake:180 (qt_internal_evaluate_config_expression)
  qt6base-6.7.0/cmake/QtFeature.cmake:396 (qt_evaluate_config_expression)
  qt6base-6.7.0/cmake/QtFeature.cmake:711 (qt_evaluate_feature)
  qt6base-6.7.0/cmake/QtFeature.cmake:680 (qt_feature_module_end)
  src/qml/CMakeLists.txt:13 (qt_feature_evaluate_features)

Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
---
Changes v2 -> v3:
  - This fix was added in this version of the patch set.

 ...1-Fix-build-with--no-feature-network.patch | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 package/qt6/qt6declarative/0001-Fix-build-with--no-feature-network.patch

diff --git a/package/qt6/qt6declarative/0001-Fix-build-with--no-feature-network.patch b/package/qt6/qt6declarative/0001-Fix-build-with--no-feature-network.patch
new file mode 100644
index 0000000000..bef5794229
--- /dev/null
+++ b/package/qt6/qt6declarative/0001-Fix-build-with--no-feature-network.patch
@@ -0,0 +1,28 @@
+From 8377691a0998fd84e6fc8349a5db450bf2d79164 Mon Sep 17 00:00:00 2001
+From: Tasuku Suzuki <tasuku.suzuki@signal-slot.co.jp>
+Date: Tue, 21 Nov 2023 23:58:43 +0900
+Subject: Fix build with -no-feature-network
+
+Change-Id: Ib21012301da6afb5458f707b39a9a8079d93eb93
+Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
+Upstream: https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=8377691a0998fd84e6fc8349a5db450bf2d79164
+Signed-off-by: Roy Kollen Svendsen <roy.kollen.svendsen@akersolutions.com>
+---
+ src/qml/configure.cmake | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/qml/configure.cmake b/src/qml/configure.cmake
+index 2d0434643a..d1ff90bd54 100644
+--- a/src/qml/configure.cmake
++++ b/src/qml/configure.cmake
+@@ -82,7 +82,7 @@ qt_feature("qml-ssl" PUBLIC
+     SECTION "QML"
+     LABEL "QML SSL support"
+     PURPOSE "Provides ssl support in QML."
+-    CONDITION QT_FEATURE_ssl
++    CONDITION QT_FEATURE_qml_network AND QT_FEATURE_ssl
+ )
+ 
+ # On arm and arm64 we need a specialization of cacheFlush() for each OS to be
+-- 
+cgit v1.2.3
-- 
2.45.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-05-12 20:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1924535>
2024-05-12 11:45 ` [Buildroot] [PATCH v3 01/14] package/qt6: bump version to 6.7.0 Roy Kollen Svendsen
2024-05-12 11:45   ` [Buildroot] [PATCH v3 02/14] package/qt6/qt6base: patch CVE-2024-33861 Roy Kollen Svendsen
2024-05-13  6:40     ` Thomas Petazzoni via buildroot
2024-05-13  7:57       ` Jesse Van Gavere
2024-05-13 10:29         ` Roy Kollen Svendsen
2024-05-13 11:05           ` Jesse Van Gavere
2024-05-13 11:59             ` Thomas Petazzoni via buildroot
2024-05-12 11:45   ` [Buildroot] [PATCH v3 03/14] package/qt6/qt6base: add blind option to enable GUI support on host Roy Kollen Svendsen
2024-05-12 11:45   ` [Buildroot] [PATCH v3 04/14] package/qt6/qt6shadertools: new package Roy Kollen Svendsen
2024-05-12 11:45   ` [Buildroot] [PATCH v3 05/14] package/qt6/qt6svg: allow building for host Roy Kollen Svendsen
2024-05-12 11:45   ` [Buildroot] [PATCH v3 06/14] package/qt6/qt6languageserver: new package Roy Kollen Svendsen
2024-05-12 11:45   ` [Buildroot] [PATCH v3 07/14] package/qt6/qt6declarative: " Roy Kollen Svendsen
2024-05-12 11:45   ` Roy Kollen Svendsen [this message]
2024-05-12 11:45   ` [Buildroot] [PATCH v3 09/14] package/qt6/qt6websockets: " Roy Kollen Svendsen
2024-05-12 11:45   ` [Buildroot] [PATCH v3 10/14] package/qt6/qt6wayland: " Roy Kollen Svendsen
2024-05-12 11:45   ` [Buildroot] [PATCH v3 11/14] package/qt6/qt6base: add blind option to enable Network support on host Roy Kollen Svendsen
2024-05-12 11:45   ` [Buildroot] [PATCH v3 12/14] package/qt6/qt6tools: new package Roy Kollen Svendsen
2024-05-12 11:46   ` [Buildroot] [PATCH v3 13/14] package/qt6/qt6virtualkeyboard: " Roy Kollen Svendsen
2024-05-12 11:46   ` [Buildroot] [PATCH v3 14/14] package/qt6/qt6mqtt: " Roy Kollen Svendsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240512114617.2564569-8-roykollensvendsen@gmail.com \
    --to=roykollensvendsen@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=jesseevg@gmail.com \
    --cc=roy.kollen.svendsen@akersolutions.com \
    --cc=s.martin49@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=zgyarmati@zgyarmati.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.