From: Jakub Kicinski <kuba@kernel.org>
To: Josua Mayer <josua@solid-run.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mor Nagli <mor.nagli@solid-run.com>
Subject: Re: [PATCH net-next v3] net: dsa: mv88e6xxx: control mdio bus-id truncation for long paths
Date: Mon, 13 May 2024 08:32:25 -0700 [thread overview]
Message-ID: <20240513083225.1043f59e@kernel.org> (raw)
In-Reply-To: <c30a0242-9c68-4930-a752-80fb4ad499d9@solid-run.com>
On Tue, 7 May 2024 12:03:31 +0000 Josua Mayer wrote:
> > The idea and implementation is reasonable but this could affect other drivers than mv88e6xxx, why not move that logic to mdiobus_register() and tracking the truncation index globally within the MDIO bus layer?
> Conceptually I agree, it would be nice to have a centralized
> solution to this problem, it probably can occur in multiple places.
>
> My reasoning is that solving the problem within a single driver
> is a much smaller task, especially for sporadic contributors
> who lack a deep understanding for how all layers interact.
>
> Perhaps agreeing on a good solution within this driver
> can inform a more general solution to be added later.
I agree with Florian, FWIW. The choice of how to truncate is a bit
arbitrary, if core does it at least it will be consistent.
next prev parent reply other threads:[~2024-05-13 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 9:52 [PATCH net-next v3] net: dsa: mv88e6xxx: control mdio bus-id truncation for long paths Josua Mayer
2024-05-05 19:11 ` Florian Fainelli
2024-05-07 12:03 ` Josua Mayer
2024-05-13 15:32 ` Jakub Kicinski [this message]
2024-11-18 14:57 ` Josua Mayer
2024-11-18 15:05 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513083225.1043f59e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=josua@solid-run.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mor.nagli@solid-run.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.