From: Stephen Hemminger <stephen@networkplumber.org>
To: Maryam Tahhan <mtahhan@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic
Date: Mon, 13 May 2024 08:53:37 -0700 [thread overview]
Message-ID: <20240513085337.6665bd5f@hermes.local> (raw)
In-Reply-To: <97be801a-bc5c-47bd-bb1f-23cca7f1fbcf@redhat.com>
On Mon, 13 May 2024 09:23:08 +0100
Maryam Tahhan <mtahhan@redhat.com> wrote:
> On 10/05/2024 16:06, Stephen Hemminger wrote:
> > You don't have to use local statistic for this, there already is one in the dev struct
> > i.e dev->data->rx_mbuf_alloc_failed. The problem is you need the DPDK port number to find
> > what dev is.
>
> I think the diff id that dev->data->rx_mbuf_alloc_failed would reflect
> the pure HW(NIC) failed allocations where as the local alloc_failed
> would reflect the failed allocations on the xdp side. Both should be
> accounted for.
Since this is not the fast path, why not just increment the global statistic.
This is a SW driver, but it can increment statistics just like a HW NIC driver.
next prev parent reply other threads:[~2024-05-13 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 10:03 [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf Ciara Loftus
2024-05-10 10:03 ` [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic Ciara Loftus
2024-05-10 12:35 ` Maryam Tahhan
2024-05-10 15:06 ` Stephen Hemminger
2024-05-13 8:23 ` Maryam Tahhan
2024-05-13 15:53 ` Stephen Hemminger [this message]
2024-05-14 8:37 ` Loftus, Ciara
2024-05-10 10:03 ` [PATCH 3/3] net/af_xdp: Fix stats reset Ciara Loftus
2024-05-10 12:36 ` Maryam Tahhan
2024-05-10 12:20 ` [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf Maryam Tahhan
2024-05-10 14:58 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513085337.6665bd5f@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=mtahhan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.