All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
	Gal Pressman <gal@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	Carolina Jubran <cjubran@nvidia.com>
Subject: Re: [PATCH net-next 2/3] net/mlx5e: Modifying channels number and updating TX queues
Date: Mon, 13 May 2024 09:59:44 +0100	[thread overview]
Message-ID: <20240513085944.GC2787@kernel.org> (raw)
In-Reply-To: <20240512124306.740898-3-tariqt@nvidia.com>

On Sun, May 12, 2024 at 03:43:04PM +0300, Tariq Toukan wrote:
> From: Carolina Jubran <cjubran@nvidia.com>
> 
> It is not appropriate for the mlx5e_num_channels_changed
> function to be called solely for updating the TX queues,
> even if the channels number has not been changed.
> 
> Move the code responsible for updating the TC and TX queues
> from mlx5e_num_channels_changed and produce a new function
> called mlx5e_update_tc_and_tx_queues. This new function should
> only be called when the channels number remains unchanged.
> 
> Signed-off-by: Carolina Jubran <cjubran@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Reviewed-by: Simon Horman <horms@kernel.org>


  reply	other threads:[~2024-05-13  8:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-12 12:43 [PATCH net-next 0/3] mlx5 misc patches Tariq Toukan
2024-05-12 12:43 ` [PATCH net-next 1/3] net/mlx5: Enable 8 ports LAG Tariq Toukan
2024-05-13  8:59   ` Simon Horman
2024-05-12 12:43 ` [PATCH net-next 2/3] net/mlx5e: Modifying channels number and updating TX queues Tariq Toukan
2024-05-13  8:59   ` Simon Horman [this message]
2024-05-12 12:43 ` [PATCH net-next 3/3] net/mlx5: Remove unused msix related exported APIs Tariq Toukan
2024-05-13  8:59   ` Simon Horman
2024-05-13  9:14   ` Kalesh Anakkur Purayil
2024-05-14  0:00 ` [PATCH net-next 0/3] mlx5 misc patches patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240513085944.GC2787@kernel.org \
    --to=horms@kernel.org \
    --cc=cjubran@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.