From: Simon Horman <horms@kernel.org>
To: darinzon@amazon.com
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Woodhouse, David" <dwmw@amazon.com>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
Saeed Bshara <saeedb@amazon.com>, "Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Agroskin, Shay" <shayagr@amazon.com>,
"Itzko, Shahar" <itzko@amazon.com>,
"Abboud, Osama" <osamaabb@amazon.com>,
"Ostrovsky, Evgeny" <evostrov@amazon.com>,
"Tabachnik, Ofir" <ofirt@amazon.com>
Subject: Re: [PATCH v2 net-next 4/5] net: ena: Changes around strscpy calls
Date: Mon, 13 May 2024 10:35:14 +0100 [thread overview]
Message-ID: <20240513093514.GH2787@kernel.org> (raw)
In-Reply-To: <20240512134637.25299-5-darinzon@amazon.com>
On Sun, May 12, 2024 at 01:46:36PM +0000, darinzon@amazon.com wrote:
> From: David Arinzon <darinzon@amazon.com>
>
> strscpy copies as much of the string as possible,
> meaning that the destination string will be truncated
> in case of no space. As this is a non-critical error in
> our case, adding a debug level print for indication.
>
> This patch also removes a -1 which was added to ensure
> enough space for NUL, but strscpy destination string is
> guaranteed to be NUL-terminted, therefore, the -1 is
> not needed.
>
> Signed-off-by: David Arinzon <darinzon@amazon.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-05-13 9:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 13:46 [PATCH v2 net-next 0/5] ENA driver changes May 2024 darinzon
2024-05-12 13:46 ` [PATCH v2 net-next 1/5] net: ena: Add a counter for driver's reset failures darinzon
2024-05-13 9:34 ` Simon Horman
2024-05-12 13:46 ` [PATCH v2 net-next 2/5] net: ena: Reduce holes in ena_com structures darinzon
2024-05-13 9:34 ` Simon Horman
2024-05-12 13:46 ` [PATCH v2 net-next 3/5] net: ena: Add validation for completion descriptors consistency darinzon
2024-05-13 9:34 ` Simon Horman
2024-05-12 13:46 ` [PATCH v2 net-next 4/5] net: ena: Changes around strscpy calls darinzon
2024-05-13 9:35 ` Simon Horman [this message]
2024-05-12 13:46 ` [PATCH v2 net-next 5/5] net: ena: Change initial rx_usec interval darinzon
2024-05-13 9:35 ` Simon Horman
2024-05-13 21:50 ` [PATCH v2 net-next 0/5] ENA driver changes May 2024 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513093514.GH2787@kernel.org \
--to=horms@kernel.org \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=edumazet@google.com \
--cc=evostrov@amazon.com \
--cc=itzko@amazon.com \
--cc=kuba@kernel.org \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ofirt@amazon.com \
--cc=osamaabb@amazon.com \
--cc=pabeni@redhat.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.