From: Avinesh Kumar <akumar@suse.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/mmap08: Use macro TST_EXP_FAIL_PTR_VOID()
Date: Mon, 13 May 2024 15:08:24 +0200 [thread overview]
Message-ID: <20240513130825.11190-1-akumar@suse.de> (raw)
In-Reply-To: <20240507165300.GA157588@pevik>
Signed-off-by: Avinesh Kumar <akumar@suse.de>
---
testcases/kernel/syscalls/mmap/mmap08.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/testcases/kernel/syscalls/mmap/mmap08.c b/testcases/kernel/syscalls/mmap/mmap08.c
index 5c9fd782c..f023446f5 100644
--- a/testcases/kernel/syscalls/mmap/mmap08.c
+++ b/testcases/kernel/syscalls/mmap/mmap08.c
@@ -8,7 +8,7 @@
/*\
* [Description]
*
- * verify that, mmap() calls fails with errno EBADF when a file mapping
+ * Verify that, mmap() calls fails with errno EBADF when a file mapping
* is requested but the fd is not a valid file descriptor.
*/
@@ -27,15 +27,10 @@ static void setup(void)
static void run(void)
{
- TESTPTR(mmap(NULL, page_sz, PROT_WRITE, MAP_FILE | MAP_SHARED, fd, 0));
+ TST_EXP_FAIL_PTR_VOID(mmap(NULL, page_sz, PROT_WRITE, MAP_FILE | MAP_SHARED, fd, 0), EBADF);
- if (TST_RET_PTR != MAP_FAILED) {
- tst_res(TFAIL, "mmap() passed unexpectedly");
+ if(TST_RET_PTR != MAP_FAILED) {
SAFE_MUNMAP(TST_RET_PTR, page_sz);
- } else if (TST_ERR == EBADF) {
- tst_res(TPASS, "mmap() failed with EBADF");
- } else {
- tst_res(TFAIL | TERRNO, "mmap() failed with an invalid errno");
}
}
--
2.44.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-05-13 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 19:48 [LTP] [PATCH] syscalls/mmap08: Use macro TST_EXP_FAIL_PTR_VOID() Avinesh Kumar
2024-05-07 16:53 ` Petr Vorel
2024-05-13 13:08 ` Avinesh Kumar [this message]
2024-05-13 13:18 ` [LTP] [PATCH v2] " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513130825.11190-1-akumar@suse.de \
--to=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.