All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Michael Hennerich <michael.hennerich@analog.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node name
Date: Mon, 13 May 2024 09:19:06 -0500	[thread overview]
Message-ID: <20240513141906.GA2534611-robh@kernel.org> (raw)
In-Reply-To: <20240510-b4-iio-axi-adc-dt-binding-tweak-v1-1-a1f633c4602c@baylibre.com>

On Fri, May 10, 2024 at 04:04:38PM -0500, David Lechner wrote:
> It is always recommended to use generic node names for devicetree nodes.
> The documentation [1] of the AXI ADC IP core says "The most important
> part of the core is the Receiver PHY module.", so using phy as the node
> name seems appropriate.
> 
> [1]: https://wiki.analog.com/resources/fpga/docs/axi_adc_ip
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> index e1f450b80db2..9cad4c439045 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> @@ -57,7 +57,7 @@ additionalProperties: false
>  
>  examples:
>    - |
> -    axi-adc@44a00000 {
> +    phy@44a00000 {

phy should be used when there's #phy-cells which is not the case here. 
'adc' is somewhat standard. Or maybe it should be tied to 
#io-backend-cells.

Until we have something defined as ti what it should be, we should just 
leave node names alone.

Rob

  parent reply	other threads:[~2024-05-13 14:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10 21:04 [PATCH] dt-bindings: iio: adc: adi,axi-adc: tweak example node name David Lechner
2024-05-11 13:00 ` Conor Dooley
2024-05-12 11:52   ` Jonathan Cameron
2024-05-13 14:19 ` Rob Herring [this message]
2024-05-19 17:41   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240513141906.GA2534611-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.