Re: [PATCH v2 1/2] netfilter: nft_queue: compute SCTP checksum

[Florian Westphal <fw@strlen.de>]

Antonio Ojea <aojea@google.com> wrote:
> when packet is enqueued with nfqueue and GSO is enabled, checksum
> calculation has to take into account the protocol, as SCTP uses a
> 32 bits CRC checksum.
> 
> Signed-off-by: Antonio Ojea <aojea@google.com>
> ---
> V1 -> V2: add a helper function to process the checksum
> 
>  net/netfilter/nfnetlink_queue.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/nfnetlink_queue.c b/net/netfilter/nfnetlink_queue.c
> index 00f4bd21c59b..accf4942d9ff 100644
> --- a/net/netfilter/nfnetlink_queue.c
> +++ b/net/netfilter/nfnetlink_queue.c
> @@ -538,6 +538,14 @@ static int nfqnl_put_bridge(struct nf_queue_entry *entry, struct sk_buff *skb)
>  	return -1;
>  }
>  
> +static int nf_queue_checksum_help(struct sk_buff *entskb)
> +{
> +  if (skb_csum_is_sctp(entskb))
> +    return skb_crc32c_csum_help(entskb);

This should be tabs, please run your patch through checkpatch.pl.