From: "Michael S. Tsirkin" <mst@redhat.com>
To: Zhu Lingshan <lingshan.zhu@intel.com>
Cc: jasowang@redhat.com, virtualization@lists.linux.dev
Subject: Re: [PATCH] ifcvf/vDPA: ifcvf drives standard virtio pci devices
Date: Tue, 14 May 2024 09:44:33 -0400 [thread overview]
Message-ID: <20240514094234-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240513212707.9894-1-lingshan.zhu@intel.com>
On Tue, May 14, 2024 at 05:27:07AM +0800, Zhu Lingshan wrote:
> @@ -880,7 +881,9 @@ static struct pci_device_id ifcvf_pci_ids[] = {
> VIRTIO_TRANS_ID_BLOCK,
> PCI_VENDOR_ID_INTEL,
> VIRTIO_ID_BLOCK) },
> -
> + /* standard virtio pci devices */
> + { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET,
> + PCI_ANY_ID) },
> { 0 },
To summarize, I don't think ifcvf should drive standard virtio devices.
If it can then it sounds more like a reason to try to reuse more code
from virtio core.
> };
> MODULE_DEVICE_TABLE(pci, ifcvf_pci_ids);
> --
> 2.43.0
next prev parent reply other threads:[~2024-05-14 13:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 21:27 [PATCH] ifcvf/vDPA: ifcvf drives standard virtio pci devices Zhu Lingshan
2024-05-13 13:36 ` Parav Pandit
2024-05-14 1:27 ` Zhu, Lingshan
2024-05-14 3:33 ` Parav Pandit
2024-05-14 5:25 ` Zhu, Lingshan
2024-05-13 13:38 ` Michael S. Tsirkin
2024-05-14 1:22 ` Zhu, Lingshan
2024-05-14 13:44 ` Michael S. Tsirkin [this message]
2024-05-15 7:28 ` Zhu, Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240514094234-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.