From: Tree Davies <tdavies@darkphysics.net>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Tree Davies <tdavies@darkphysics.net>
Subject: [PATCH 22/31] Staging: rtl8192e: Rename variable IsDataFrame
Date: Tue, 14 May 2024 21:52:19 -0700 [thread overview]
Message-ID: <20240515045228.35928-23-tdavies@darkphysics.net> (raw)
In-Reply-To: <20240515045228.35928-1-tdavies@darkphysics.net>
Rename variable IsDataFrame to is_data_frame
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtllib.h | 4 ++--
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index f69f4ca39fd5..0914ba37f42f 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -338,8 +338,8 @@ enum rt_op_mode {
#define RTLLIB_QCTL_TID 0x000F
#define FC_QOS_BIT BIT(7)
-#define IsDataFrame(pdu) (((pdu[0] & 0x0C) == 0x08) ? true : false)
-#define is_legacy_data_frame(pdu) (IsDataFrame(pdu) && (!(pdu[0]&FC_QOS_BIT)))
+#define is_data_frame(pdu) (((pdu[0] & 0x0C) == 0x08) ? true : false)
+#define is_legacy_data_frame(pdu) (is_data_frame(pdu) && (!(pdu[0]&FC_QOS_BIT)))
#define IsQoSDataFrame(pframe) \
((*(u16 *)pframe&(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) == \
(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA))
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index f276e52aab08..d4714e193df4 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -881,7 +881,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_device *ieee,
if (!ieee->ht_info->cur_rx_reorder_enable ||
!ieee->current_network.qos_data.active ||
- !IsDataFrame(skb->data) ||
+ !is_data_frame(skb->data) ||
is_legacy_data_frame(skb->data)) {
if (!ieee80211_is_beacon(hdr->frame_control)) {
if (is_duplicate_packet(ieee, hdr))
--
2.30.2
next prev parent reply other threads:[~2024-05-15 4:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 4:51 [PATCH 00/31] Staging: rtl8192e: rtllib_rx.c Rename camelcase variables Tree Davies
2024-05-15 4:51 ` [PATCH 01/31] Staging: rtl8192e: Rename variable IsPassiveChannel Tree Davies
2024-05-15 4:51 ` [PATCH 02/31] Staging: rtl8192e: Rename variable CountryIeBuf Tree Davies
2024-05-15 4:52 ` [PATCH 03/31] Staging: rtl8192e: Rename variable CountryIeLen Tree Davies
2024-05-15 4:52 ` [PATCH 04/31] Staging: rtl8192e: Rename variable bWithAironetIE Tree Davies
2024-05-15 4:52 ` [PATCH 05/31] Staging: rtl8192e: Rename variable bContainHTC Tree Davies
2024-05-15 4:52 ` [PATCH 06/31] Staging: rtl8192e: Rename variable MBssid Tree Davies
2024-05-15 4:52 ` [PATCH 07/31] Staging: rtl8192e: Rename variable MBssidMask Tree Davies
2024-05-15 4:52 ` [PATCH 08/31] Staging: rtl8192e: Rename variable elementID Tree Davies
2024-05-15 4:52 ` [PATCH 09/31] Staging: rtl8192e: Rename variable rtllib_rx_Monitor Tree Davies
2024-05-15 4:52 ` [PATCH 10/31] Staging: rtl8192e: Rename variable rtllib_rx_InfraAdhoc Tree Davies
2024-05-15 4:52 ` [PATCH 11/31] Staging: rtl8192e: Rename variable IsLegacyDataFrame Tree Davies
2024-05-15 4:52 ` [PATCH 12/31] Staging: rtl8192e: Rename variable RxReorderIndicatePacket Tree Davies
2024-05-15 4:52 ` [PATCH 13/31] Staging: rtl8192e: Rename variable RfdArray Tree Davies
2024-05-15 4:52 ` [PATCH 14/31] Staging: rtl8192e: Rename variable Decrypted Tree Davies
2024-05-15 4:52 ` [PATCH 15/31] Staging: rtl8192e: Rename variable AddReorderEntry Tree Davies
2024-05-15 4:52 ` [PATCH 16/31] Staging: rtl8192e: Rename variable pList Tree Davies
2024-05-15 9:15 ` Dan Carpenter
2024-05-15 4:52 ` [PATCH 17/31] Staging: rtl8192e: Rename variable nPadding_Length Tree Davies
2024-05-15 10:27 ` Dan Carpenter
2024-05-15 4:52 ` [PATCH 18/31] Staging: rtl8192e: Rename variable LLCOffset Tree Davies
2024-05-15 4:52 ` [PATCH 19/31] Staging: rtl8192e: Rename variable ChkLength Tree Davies
2024-05-15 10:31 ` Dan Carpenter
2024-05-18 22:02 ` <Tree Davies
2024-05-15 4:52 ` [PATCH 20/31] Staging: rtl8192e: Rename variable WinEnd Tree Davies
2024-05-15 4:52 ` [PATCH 21/31] Staging: rtl8192e: Rename variable WinSize Tree Davies
2024-05-15 4:52 ` Tree Davies [this message]
2024-05-15 4:52 ` [PATCH 23/31] Staging: rtl8192e: Rename variable bMatchWinStart Tree Davies
2024-05-15 4:52 ` [PATCH 24/31] Staging: rtl8192e: Rename variable bMBssidValid Tree Davies
2024-05-15 4:52 ` [PATCH 25/31] Staging: rtl8192e: Rename variable bWithCcxVerNum Tree Davies
2024-05-15 4:52 ` [PATCH 26/31] Staging: rtl8192e: Rename variable Frame_QoSTID Tree Davies
2024-05-15 4:52 ` [PATCH 27/31] Staging: rtl8192e: Rename variable CcxRmState Tree Davies
2024-05-15 4:52 ` [PATCH 28/31] Staging: rtl8192e: Rename variable IsQoSDataFrame Tree Davies
2024-05-15 4:52 ` [PATCH 29/31] Staging: rtl8192e: Rename variable RfdCnt Tree Davies
2024-05-15 4:52 ` [PATCH 30/31] Staging: rtl8192e: Rename variable prxbIndicateArray Tree Davies
2024-05-15 4:52 ` [PATCH 31/31] Staging: rtl8192e: Rename variable bPktInBuf Tree Davies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515045228.35928-23-tdavies@darkphysics.net \
--to=tdavies@darkphysics.net \
--cc=anjan@momi.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.