From: Petr Vorel <pvorel@suse.cz>
To: "Yang Xu (Fujitsu)" <xuyang2018.jy@fujitsu.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] lseek: Add negative tests for lseek
Date: Wed, 15 May 2024 08:49:52 +0200 [thread overview]
Message-ID: <20240515064952.GA197249@pevik> (raw)
In-Reply-To: <26b3c58d-ff1b-4f2c-82de-8692aacaed5a@fujitsu.com>
> Hi Avinesh
> Thanks for your reviewing.
> According to the man page, not all file systems support SEEK_DATA/SEEK_HOLE.
> Users may run LTP on an old kernel, or on a file system that does not
> support SEEK_DATA/SEEK_HOLE If returning TFAIL directly, this may make
> user confused.
> So in the case I check the errno of lseek(), and return TCONF if
> SEEK_DATA/SEEK_HOLE are not supported.
Sounds good.
Kind regards,
Petr
> I think this is easier to understand for users.
> Best Regards
> Yang Xu
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-05-15 6:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 5:25 [LTP] [PATCH] lseek: Add negative tests for lseek Yang Xu via ltp
2024-05-13 11:31 ` Avinesh Kumar
2024-05-14 2:41 ` Yang Xu (Fujitsu) via ltp
2024-05-15 6:49 ` Petr Vorel [this message]
2025-01-14 11:58 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515064952.GA197249@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.