Re: [LTP] [PATCH] syscalls/setitimer: Pass the kernel-defined struct __kernel_old_itimerval to sys_setitimer().

[Petr Vorel <pvorel@suse.cz>]

Hi Cyril,

> Hi all,

...
> > Also we should really add tests for the libc wrapper as well, since that
> > is actually more likely to get broken by the double conversion on 32bit
> > arch, but that should be done in an subsequent patches.

> +1. Adding .test_variants with {g,s}etitimer() for {g,s}etitimer0[12].c should
> be trivial. Or did you mean to have test variants also for other functions in
> include/tst_timer.h (e.g. timerfd_{g,s}ettime()) ?

timerfd_{g,s}ettime() (and other functions) test raw syscall with variants for
64bit and the old 32bit. These tests (in testcases/kernel/syscalls/timerfd) are
already quite complicated. I'm not sure if it's a good idea to add also
timerfd_{g,s}ettime() wrappers. But they should be covered as well, right?

> BTW we already test {g,s}etitimer() libc wrapper in getitimer01.c, therefore we
> already have libc wrapper at least somehow covered (the other two test raw
> syscall).

And we of course test {g,s}etitimer() libc wrappers in open posix testsuite.

Kind regards,
Petr

> Once we agree what to do I'll either post a patch or add a ticket for it (or
> feel free to add a ticket yourself).
...

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp