From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <edumazet@google.com>
Cc: Florian Westphal <fw@strlen.de>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, eric.dumazet@gmail.com,
syzbot <syzkaller@googlegroups.com>
Subject: Re: [PATCH net] netfilter: nfnetlink_queue: acquire rcu_read_lock() in instance_destroy_rcu()
Date: Wed, 15 May 2024 16:10:23 +0200 [thread overview]
Message-ID: <20240515141023.GE13678@breakpoint.cc> (raw)
In-Reply-To: <CANn89iJUMN6VOkhLi__EH2VxMF1XatEn2x-n=0tLQ1+Bk3u+GQ@mail.gmail.com>
Eric Dumazet <edumazet@google.com> wrote:
> > If you prefer Erics patch thats absolutely fine with me, I'll rebase in
> > that case to keep the selftest around.
>
> I missed your patch, otherwise I would have done nothing ;)
>
> I saw the recent changes about nf_reinject() and tried to have a patch
> that would be easily backported without conflicts.
Right, makes sense from that pov.
I think its fine to apply the patch in this case, I'll followup later.
Thus:
Acked-by: Florian Westphal <fw@strlen.de>
> Do you think the splat is caused by recent changes, or is it simply
> syzbot getting smarter ?
Its old bug, AFAICS your Fixes tag is correct.
1. Userspace prog needs to subscribe to queue x
2. iptables/nftables rule needs to send packets to queue x
3. actual packets that match that have to be sent
4. Userspace program needs to exit while at least one packet
is queued
Amazing that syzbot managed to hit all 4 checkboxes :)
prev parent reply other threads:[~2024-05-15 14:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 13:23 [PATCH net] netfilter: nfnetlink_queue: acquire rcu_read_lock() in instance_destroy_rcu() Eric Dumazet
2024-05-15 13:27 ` Florian Westphal
2024-05-15 13:39 ` Eric Dumazet
2024-05-15 13:42 ` Eric Dumazet
2024-05-15 14:10 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515141023.GE13678@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.