All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Nigel Croxon <ncroxon@redhat.com>
Cc: "Kernel.org-Linux-RAID" <linux-raid@vger.kernel.org>,
	Xiao Ni <xni@redhat.com>, Jes Sorensen <jes@trained-monkey.org>
Subject: Re: [PATCH] add checking of return status on fstat calls
Date: Wed, 15 May 2024 14:45:01 +0200	[thread overview]
Message-ID: <20240515144501.000048ad@linux.intel.com> (raw)
In-Reply-To: <bc9e94e6-96c5-411b-977b-30aea31cf9c3@redhat.com>

On Wed, 15 May 2024 07:55:57 -0400
Nigel Croxon <ncroxon@redhat.com> wrote:

> From 99c48231fe50845f622572d10fbb91a5ece0501f Mon Sep 17 00:00:00 2001
> From: Nigel Croxon <ncroxon@redhat.com>
> Date: Fri, 10 May 2024 09:08:02 -0400
> Subject: [PATCH] add checking of return status on fstat calls
> 
> There are a few places we don't check the return status when
> calling fstat for success. Clean up the calls by adding a
> check before continuing.
> 
> Signed-off-by: Nigel Croxon <ncroxon@redhat.com>
> ---
Hi Nigel,
I'm observing following errors:

warning: Patch sent with format=flowed; space at the end of lines might be lost.
Applying: add checking of return status on fstat calls
error: corrupt patch at line 16
Patch failed at 0001 add checking of return status on fstat calls
----

Probably you need to rebase patch to current main.

I also see, some checkpatch issues like "rv=0".
At this moment, you can just fork the github repo:
https://github.com/md-raid-utilities/mdadm

and open pull request, then checkpatch will be automatically run for you :)

Thanks,
Mariusz

  reply	other threads:[~2024-05-15 12:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15 11:55 [PATCH] add checking of return status on fstat calls Nigel Croxon
2024-05-15 12:45 ` Mariusz Tkaczyk [this message]
2024-05-15 17:42   ` Nigel Croxon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240515144501.000048ad@linux.intel.com \
    --to=mariusz.tkaczyk@linux.intel.com \
    --cc=jes@trained-monkey.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=ncroxon@redhat.com \
    --cc=xni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.