From: Bjorn Helgaas <helgaas@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: "Jon Hunter" <jonathanh@nvidia.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
"Manikanta Maddireddy" <mmaddireddy@nvidia.com>
Subject: Re: [PATCH V2] PCI: tegra194: Set EP alignment restriction for inbound ATU
Date: Wed, 15 May 2024 16:21:22 -0500 [thread overview]
Message-ID: <20240515212122.GA2139389@bhelgaas> (raw)
In-Reply-To: <ZjtFg83RjyKQA82S@ryzen.lan>
On Wed, May 08, 2024 at 11:27:31AM +0200, Niklas Cassel wrote:
> On Wed, May 08, 2024 at 10:22:07AM +0100, Jon Hunter wrote:
> > Tegra194 and Tegra234 PCIe EP controllers have 64K alignment
> > restriction for the inbound ATU. Set the endpoint inbound ATU alignment to
> > 64kB in the Tegra194 PCIe driver.
> >
> > Fixes: c57247f940e8 ("PCI: tegra: Add support for PCIe endpoint mode in Tegra194")
> > Suggested-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> > Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Applied by Krzysztof to pci/controller/tegra194, but his outgoing mail
queue was stuck. Trying to squeeze into v6.10.
> > ---
> > Changes since V1: Updated commit message.
> >
> > drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> > index 93f5433c5c55..4537313ef37a 100644
> > --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> > @@ -2015,6 +2015,7 @@ static const struct pci_epc_features tegra_pcie_epc_features = {
> > .bar[BAR_3] = { .type = BAR_RESERVED, },
> > .bar[BAR_4] = { .type = BAR_RESERVED, },
> > .bar[BAR_5] = { .type = BAR_RESERVED, },
> > + .align = SZ_64K,
> > };
> >
> > static const struct pci_epc_features*
> > --
> > 2.34.1
> >
>
> Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2024-05-15 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 9:22 [PATCH V2] PCI: tegra194: Set EP alignment restriction for inbound ATU Jon Hunter
2024-05-08 9:27 ` Niklas Cassel
2024-05-15 21:21 ` Bjorn Helgaas [this message]
2024-05-17 11:31 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240515212122.GA2139389@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.