From: Jakub Kicinski <kuba@kernel.org>
To: "Lena Wang (王娜)" <Lena.Wang@mediatek.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Shiming Cheng (成诗明)" <Shiming.Cheng@mediatek.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"willemdebruijn.kernel@gmail.com"
<willemdebruijn.kernel@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH net] net: prevent pulling SKB_GSO_FRAGLIST skb
Date: Thu, 16 May 2024 08:11:10 -0700 [thread overview]
Message-ID: <20240516081110.362cbb51@kernel.org> (raw)
In-Reply-To: <bc69f8cc4aed8b16daba17c0ca0199fe6d7d24a8.camel@mediatek.com>
On Wed, 15 May 2024 09:02:35 +0000 Lena Wang (王娜) wrote:
> > One of the fixes you posted breaks the
> >
> > tools/testing/selftests/net/udpgro_fwd.sh
> >
> > selftest. Please investigate, and either adjust the test or the fix.
>
> Dear Jakub,
> Sorry for late response.
> As we do not make selftest before, I try to build a test environmen and
> cost time to apply sudo access right in our company server.
Please read:
https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style
Depending on your setup sudo may not be needed.
> Now it blocks to generate xdp_dummy.bpf.o. Could you please give some guidline
> about the script test step? Thanks.
Install clang and run make? Please share some outputs or more details,
I'm not sure what the problem is
> Could you give more info about the failed situation?
> Is it this fix "[PATCH net] net: prevent pulling SKB_GSO_FRAGLIST skb"
> failed?
> Which case is failed?
These are the results, as far as I can tell:
https://netdev-3.bots.linux.dev/vmksft-net/results/573200/24-udpgro-fwd-sh/
> Is it possible that the test case has issue?
Entirely possible, yes.
next prev parent reply other threads:[~2024-05-16 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 14:29 [PATCH net] net: prevent pulling SKB_GSO_FRAGLIST skb shiming.cheng
2024-04-29 13:28 ` Willem de Bruijn
2024-04-29 13:42 ` Jakub Kicinski
2024-05-15 9:02 ` Lena Wang (王娜)
2024-05-16 15:11 ` Jakub Kicinski [this message]
2024-05-23 10:03 ` Lena Wang (王娜)
2024-05-23 12:46 ` Willem de Bruijn
2024-05-23 14:59 ` Willem de Bruijn
2024-05-29 11:35 ` Lena Wang (王娜)
2024-05-29 14:04 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240516081110.362cbb51@kernel.org \
--to=kuba@kernel.org \
--cc=Lena.Wang@mediatek.com \
--cc=Shiming.Cheng@mediatek.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.