All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: andrew.rybchenko@oktetlabs.ru, konstantin.v.ananyev@yandex.ru,
	paul.szczepanek@arm.com, dev@dpdk.org
Subject: Re: [PATCH] mempool: dump includes list of memory chunks
Date: Thu, 16 May 2024 08:20:57 -0700	[thread overview]
Message-ID: <20240516082057.40f3ce56@hermes.local> (raw)
In-Reply-To: <20240516085940.61119-1-mb@smartsharesystems.com>

On Thu, 16 May 2024 10:59:40 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:

> +	fprintf(f, "  mem_list:\n");
> +	n = 0;
> +	STAILQ_FOREACH(memhdr, &mp->mem_list, next) {
> +		fprintf(f, "    addr[%u]=%p\n", n, memhdr->addr);
> +		fprintf(f, "    iova[%u]=0x%" PRIx64 "\n", n, memhdr->iova);
> +		fprintf(f, "    len[%u]=%zu\n", n, memhdr->len);
> +		n++;
> +	}

The output would look better if it was a table with one line per mempool, and the name first
and column headers, and n is redundant

mem_list:
Addr	Iova	Len
...

  reply	other threads:[~2024-05-16 15:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16  8:59 [PATCH] mempool: dump includes list of memory chunks Morten Brørup
2024-05-16 15:20 ` Stephen Hemminger [this message]
2024-05-17  7:29   ` Morten Brørup
2024-05-29 12:55 ` Paul Szczepanek
2024-05-29 14:03   ` Morten Brørup
2024-06-10  9:13 ` Morten Brørup
2024-06-10 11:56 ` Andrew Rybchenko
2024-06-10 13:44 ` Konstantin Ananyev
2024-06-10 14:51   ` Morten Brørup
2024-06-10 16:28     ` Konstantin Ananyev
2024-06-11  6:38 ` [PATCH v2] " Morten Brørup
2024-06-11  6:50 ` Morten Brørup
2024-06-11  6:51 ` [PATCH v3] " Morten Brørup
2024-06-11 11:27   ` lihuisong (C)
2024-06-14 14:10   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240516082057.40f3ce56@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=mb@smartsharesystems.com \
    --cc=paul.szczepanek@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.