From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2A1980031; Thu, 16 May 2024 08:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715848080; cv=none; b=k1CV4LQalYa8Oo5Q/xrjXv+IzVTfItlTSLUdgmT7FzecOwi4JVI4CxJpvx/tbf7jM4M7Byqe2dfAwSjFPzCi1VGPrztIe90YSGFbQ55BHyg1Ucf8fy+5QfBu6dWwSug27ocrNaE99Alz+2CyT33UVNduTgfPDCdzSW61KtHQdVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715848080; c=relaxed/simple; bh=K6LjZar4C+lKcaUcvKF9CUktTgIY/qpM6WOPF5lY1uw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BBa+KIiQZyzRCSF+zORxI5gpJbPaCvIn9ZgWtySFH37mkRqy7jtdS8YZrVFHrBsoAytNV5XdMzyfqdEMaJimVE22M404qgXNkzez+vVTfQkUdvs6R3ROj1cCXMpVOP1lmdPrMIbQK4aRWJHJ1NIYM0vZpfPNJuryBReEufQdSDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IVM2U5GL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IVM2U5GL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6C04C113CC; Thu, 16 May 2024 08:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715848080; bh=K6LjZar4C+lKcaUcvKF9CUktTgIY/qpM6WOPF5lY1uw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IVM2U5GL41lJTUzuQNHCDzbJ+lZ1NsJiUnnwHsjBArxf3Mu3rushEXOEiGkSlD744 ei3h/xt4Jw3/iEtIvTsF7imzCrsQ6E9BMT/EkCahgBOMpl085ZVphA05HiT1AnFAIh 0tY9NIFSMskjH/g8z1vuBFhVSE4e2HwRcdkMmwQB4BnFpZuhpmvZFM6TfvaCGEYHI/ AUBxKyZGlJjB4ndP/dggyUP+2mC5HEVfCxhczi92o0NzrwSWSpYaSlBQc9lQnAYOds ew7Sy2fRPYk1ygWnnQ0V8axIeRde63H0zPvIKUNJgaY/awJFPweqdhj4NPfj4vzYgL sQgI4500BrPZA== Date: Thu, 16 May 2024 09:27:54 +0100 From: Simon Horman To: Larysa Zaremba Cc: intel-wired-lan@lists.osuosl.org, Jacob Keller , maciej.fijalkowski@intel.com, Magnus Karlsson , Przemek Kitszel , igor.bagnucki@intel.com, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH iwl-net 1/3] ice: remove af_xdp_zc_qps bitmap Message-ID: <20240516082754.GE179178@kernel.org> References: <20240515160246.5181-1-larysa.zaremba@intel.com> <20240515160246.5181-2-larysa.zaremba@intel.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240515160246.5181-2-larysa.zaremba@intel.com> On Wed, May 15, 2024 at 06:02:14PM +0200, Larysa Zaremba wrote: > Referenced commit has introduced a bitmap to distinguish between ZC and > copy-mode AF_XDP queues, because xsk_get_pool_from_qid() does not do this > for us. > > The bitmap would be especially useful when restoring previous state after > rebuild, if only it was not reallocated in the process. This leads to e.g. > xdpsock dying after changing number of queues. > > Instead of preserving the bitmap during the rebuild, remove it completely > and distinguish between ZC and copy-mode queues based on the presence of > a device associated with the pool. > > Fixes: e102db780e1c ("ice: track AF_XDP ZC enabled queues in bitmap") > Reviewed-by: Przemek Kitszel > Signed-off-by: Larysa Zaremba Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFFC6C25B74 for ; Thu, 16 May 2024 08:28:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id A26984092B; Thu, 16 May 2024 08:28:04 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id QZHX4ImO8BCD; Thu, 16 May 2024 08:28:03 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5FBA941C91 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1715848083; bh=d4hJtdBjJHYV39NdueoN5H8ZPgS1hyw5FDu5MtqkEXM=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=s6O98nj/NTel+UGaLhEQPkj9APsAmSmUaNsaLmwnUAHIW0hMK/IGmSCFfY6tcFIZU 6K1NsGEwvC5sCbcw9YhhM/1aLjNluJaxfuPdnD1zLaAs6QLm+q99J8+DxvOfpcDXVQ ilVCTjFVI6ap57iVxZyb1eJcIlXAcegFwRN8EdCPRuZC0SL/E3CCnADDu4evDD4tDl cLlBhVRRiw6begHPB9u3GC1ZTNwLqpm6joBvSO91oFMEV6ndVZyfENZHREGlDObUTl MGiQTvgSh8bDmEhguQkTnovUoLdlzrHLYTCMU+f4S018zInisYDfrPPFofv/fQ7eSo WxIVIr17s6IMw== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 5FBA941C91; Thu, 16 May 2024 08:28:03 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id C85F01BF855 for ; Thu, 16 May 2024 08:28:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C181840795 for ; Thu, 16 May 2024 08:28:01 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id sCybh5rsVmUb for ; Thu, 16 May 2024 08:28:01 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 07CCC40794 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 07CCC40794 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id 07CCC40794 for ; Thu, 16 May 2024 08:28:00 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6310461627; Thu, 16 May 2024 08:28:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6C04C113CC; Thu, 16 May 2024 08:27:56 +0000 (UTC) Date: Thu, 16 May 2024 09:27:54 +0100 From: Simon Horman To: Larysa Zaremba Message-ID: <20240516082754.GE179178@kernel.org> References: <20240515160246.5181-1-larysa.zaremba@intel.com> <20240515160246.5181-2-larysa.zaremba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240515160246.5181-2-larysa.zaremba@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715848080; bh=K6LjZar4C+lKcaUcvKF9CUktTgIY/qpM6WOPF5lY1uw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IVM2U5GL41lJTUzuQNHCDzbJ+lZ1NsJiUnnwHsjBArxf3Mu3rushEXOEiGkSlD744 ei3h/xt4Jw3/iEtIvTsF7imzCrsQ6E9BMT/EkCahgBOMpl085ZVphA05HiT1AnFAIh 0tY9NIFSMskjH/g8z1vuBFhVSE4e2HwRcdkMmwQB4BnFpZuhpmvZFM6TfvaCGEYHI/ AUBxKyZGlJjB4ndP/dggyUP+2mC5HEVfCxhczi92o0NzrwSWSpYaSlBQc9lQnAYOds ew7Sy2fRPYk1ygWnnQ0V8axIeRde63H0zPvIKUNJgaY/awJFPweqdhj4NPfj4vzYgL sQgI4500BrPZA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=IVM2U5GL Subject: Re: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: remove af_xdp_zc_qps bitmap X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: maciej.fijalkowski@intel.com, Jesper Dangaard Brouer , Daniel Borkmann , Przemek Kitszel , John Fastabend , Alexei Starovoitov , "David S. Miller" , Eric Dumazet , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Jacob Keller , Jakub Kicinski , bpf@vger.kernel.org, Paolo Abeni , Magnus Karlsson , igor.bagnucki@intel.com, linux-kernel@vger.kernel.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, May 15, 2024 at 06:02:14PM +0200, Larysa Zaremba wrote: > Referenced commit has introduced a bitmap to distinguish between ZC and > copy-mode AF_XDP queues, because xsk_get_pool_from_qid() does not do this > for us. > > The bitmap would be especially useful when restoring previous state after > rebuild, if only it was not reallocated in the process. This leads to e.g. > xdpsock dying after changing number of queues. > > Instead of preserving the bitmap during the rebuild, remove it completely > and distinguish between ZC and copy-mode queues based on the presence of > a device associated with the pool. > > Fixes: e102db780e1c ("ice: track AF_XDP ZC enabled queues in bitmap") > Reviewed-by: Przemek Kitszel > Signed-off-by: Larysa Zaremba Reviewed-by: Simon Horman