All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Jorge Ramirez-Ortiz, Foundries" <jorge@foundries.io>
Cc: Tim Harvey <tharvey@gateworks.com>,
	u-boot@lists.denx.de,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Adam Ford <aford173@gmail.com>,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Subject: Re: [PATCH v3] tpm: display warning if using gpio reset with TPM
Date: Thu, 16 May 2024 12:40:47 +0200	[thread overview]
Message-ID: <20240516124047.0fe6a6e9@xps-13> (raw)
In-Reply-To: <ZkXV6wBiN/oRfUH+@trex>


> > > Signed-off-by: Jorge Ramirez-Ortiz <jorge@foundries.io>  
> > 
> > You cannot send your SoB like this. SoB means you are carrying some
> > code which complies with the license, etc.
> > 
> > Either you were part of the original writing and want to be credited
> > for that (you can be the author and first SoB, or suggest Tim to use
> > Co-developed-by). Or you reviewed the change (Reviewed-by), you tested
> > the change (Tested-by), or you are maintainer/responsible for some part
> > that is touched and you agree with the change (Acked-by).  
> 
> right, however there is some lenience in the process: some projects accept
> the signed off, some others add the acked or reviewed and so on...
> 
> but I agree with you and I certainly do not need/want/expect to be
> credited for this work. it is all good on my end :)
> 
> > 
> > Thanks,
> > Miquèl  
> 
> btw you could have simply ignored my note btw : notice the "if needed"
> part in my response. for reference, I noticed my name in CC, checked the
> change, thought it was a good idea and tried to move it a long - just
> chose the wrong tag for sure...

And this is likely a good habit :) But now you need to send your
Reviewed-by because these tags are usually collected by the tools. If
you don't write it properly, there are very little chances it will
ever be picked-up.

Thanks,
Miquèl

  reply	other threads:[~2024-05-16 10:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-15 23:21 [PATCH v3] tpm: display warning if using gpio reset with TPM Tim Harvey
2024-05-16  7:09 ` Miquel Raynal
2024-05-16  9:09   ` Jorge Ramirez-Ortiz, Foundries
2024-05-16  9:34     ` Miquel Raynal
2024-05-16  9:46       ` Jorge Ramirez-Ortiz, Foundries
2024-05-16 10:40         ` Miquel Raynal [this message]
2024-05-21 19:04           ` Ilias Apalodimas
2024-05-21 19:01 ` Ilias Apalodimas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240516124047.0fe6a6e9@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=aford173@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jorge@foundries.io \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.