From: Kent Gibson <warthog618@gmail.com>
To: Hagar Hemdan <hagarhem@amazon.com>
Cc: Norbert Manthey <nmanthey@amazon.de>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: prevent potential speculation leaks in gpio_device_get_desc()
Date: Fri, 17 May 2024 00:22:39 +0800 [thread overview]
Message-ID: <20240516162239.GA184911@rigel> (raw)
In-Reply-To: <20240516145540.GA116534@rigel>
On Thu, May 16, 2024 at 10:55:40PM +0800, Kent Gibson wrote:
> On Thu, May 16, 2024 at 12:57:42PM +0000, Hagar Hemdan wrote:
> > On Tue, May 14, 2024 at 08:42:21PM +0800, Kent Gibson wrote:
>
> Now I need to test your patch to see what it actually does.
>
Tested. Fails. It does what I thought it would - clamps the offset into
bounds BEFORE the call to gpio_device_get_desc().
The appropriate place for this fix is in gpio_device_get_desc(), after
the bounds check.
Cheers,
Kent.
next prev parent reply other threads:[~2024-05-16 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 12:26 [PATCH] gpio: prevent potential speculation leaks in gpio_device_get_desc() Hagar Hemdan
2024-05-14 12:42 ` Kent Gibson
2024-05-16 12:57 ` Hagar Hemdan
2024-05-16 14:55 ` Kent Gibson
2024-05-16 16:22 ` Kent Gibson [this message]
2024-05-17 8:00 ` Hagar Hemdan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240516162239.GA184911@rigel \
--to=warthog618@gmail.com \
--cc=brgl@bgdev.pl \
--cc=hagarhem@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nmanthey@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.