[PATCH] Add convenience TARGET_CROSS

[PATCH] Add convenience TARGET_CROSS

[Vladimir Serbinenko]

This allows to set up cross environment with just 3 parameters: target,
platform and TARGET_CROSS

Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
---
 configure.ac | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/configure.ac b/configure.ac
index 84a202c6e..cacbdb6ef 100644
--- a/configure.ac
+++ b/configure.ac
@@ -539,12 +539,12 @@ if test "x$target_alias" != x && test "x$host_alias" != "x$target_alias"; then
   tmp_ac_tool_prefix="$ac_tool_prefix"
   ac_tool_prefix=$target_alias-
 
-  AC_CHECK_TOOLS(TARGET_CC, [gcc egcs cc],
+  AC_CHECK_TOOLS(TARGET_CC, [${TARGET_CROSS}gcc ${TARGET_CROSS}egcs ${TARGET_CROSS}cc],
                  [AC_MSG_ERROR([none of gcc, egcs and cc is found. set TARGET_CC manually.])])
-  AC_CHECK_TOOL(TARGET_OBJCOPY, objcopy)
-  AC_CHECK_TOOL(TARGET_STRIP, strip)
-  AC_CHECK_TOOL(TARGET_NM, nm)
-  AC_CHECK_TOOL(TARGET_RANLIB, ranlib)
+  AC_CHECK_TOOL(TARGET_OBJCOPY, ${TARGET_CROSS}objcopy)
+  AC_CHECK_TOOL(TARGET_STRIP, ${TARGET_CROSS}strip)
+  AC_CHECK_TOOL(TARGET_NM, ${TARGET_CROSS}nm)
+  AC_CHECK_TOOL(TARGET_RANLIB, ${TARGET_CROSS}ranlib)
 
   ac_tool_prefix="$tmp_ac_tool_prefix"
 else
-- 
2.39.2


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Add convenience TARGET_CROSS

[Daniel Kiper]

On Thu, May 16, 2024 at 10:07:12PM +0300, Vladimir Serbinenko wrote:
> This allows to set up cross environment with just 3 parameters: target,
> platform and TARGET_CROSS

May I ask you to document this in the INSTALL file?

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Add convenience TARGET_CROSS

[Mike Gilbert]

On Thu, May 16, 2024 at 3:07 PM Vladimir Serbinenko <phcoder@gmail.com> wrote:
>
> This allows to set up cross environment with just 3 parameters: target,
> platform and TARGET_CROSS

I wonder if it would make sense to use the AC_CHECK_TARGET_TOOL[S]
macros instead of AC_CHECK_TOOL[S]?

https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.72/html_node/Generic-Programs.html#index-AC_005fCHECK_005fTARGET_005fTOOL-1

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH] Add convenience TARGET_CROSS

[Vladimir Serbinenko]

Setting all TARGET_* variables is cumbersome. This convenience macro allows
to set them all in one go

Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
---
 configure.ac | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/configure.ac b/configure.ac
index ad1e7bea5..34f4f9415 100644
--- a/configure.ac
+++ b/configure.ac
@@ -540,12 +540,12 @@ if test "x$target_alias" != x && test "x$host_alias" != "x$target_alias"; then
   tmp_ac_tool_prefix="$ac_tool_prefix"
   ac_tool_prefix=$target_alias-
 
-  AC_CHECK_TOOLS(TARGET_CC, [gcc egcs cc],
+  AC_CHECK_TOOLS(TARGET_CC, [${TARGET_CROSS}gcc ${TARGET_CROSS}egcs ${TARGET_CROSS}cc],
                  [AC_MSG_ERROR([none of gcc, egcs and cc is found. set TARGET_CC manually.])])
-  AC_CHECK_TOOL(TARGET_OBJCOPY, objcopy)
-  AC_CHECK_TOOL(TARGET_STRIP, strip)
-  AC_CHECK_TOOL(TARGET_NM, nm)
-  AC_CHECK_TOOL(TARGET_RANLIB, ranlib)
+  AC_CHECK_TOOL(TARGET_OBJCOPY, ${TARGET_CROSS}objcopy)
+  AC_CHECK_TOOL(TARGET_STRIP, ${TARGET_CROSS}strip)
+  AC_CHECK_TOOL(TARGET_NM, ${TARGET_CROSS}nm)
+  AC_CHECK_TOOL(TARGET_RANLIB, ${TARGET_CROSS}ranlib)
 
   ac_tool_prefix="$tmp_ac_tool_prefix"
 else
-- 
2.49.0


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Add convenience TARGET_CROSS

[Daniel Kiper]

On Thu, Mar 27, 2025 at 07:32:04PM +0300, Vladimir Serbinenko wrote:
> Setting all TARGET_* variables is cumbersome. This convenience macro allows
> to set them all in one go

I think TARGET_CROSS should be documented in the INSTALL file.

> Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
> ---
>  configure.ac | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index ad1e7bea5..34f4f9415 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -540,12 +540,12 @@ if test "x$target_alias" != x && test "x$host_alias" != "x$target_alias"; then
>    tmp_ac_tool_prefix="$ac_tool_prefix"
>    ac_tool_prefix=$target_alias-
>
> -  AC_CHECK_TOOLS(TARGET_CC, [gcc egcs cc],
> +  AC_CHECK_TOOLS(TARGET_CC, [${TARGET_CROSS}gcc ${TARGET_CROSS}egcs ${TARGET_CROSS}cc],
>                   [AC_MSG_ERROR([none of gcc, egcs and cc is found. set TARGET_CC manually.])])
> -  AC_CHECK_TOOL(TARGET_OBJCOPY, objcopy)
> -  AC_CHECK_TOOL(TARGET_STRIP, strip)
> -  AC_CHECK_TOOL(TARGET_NM, nm)
> -  AC_CHECK_TOOL(TARGET_RANLIB, ranlib)
> +  AC_CHECK_TOOL(TARGET_OBJCOPY, ${TARGET_CROSS}objcopy)
> +  AC_CHECK_TOOL(TARGET_STRIP, ${TARGET_CROSS}strip)
> +  AC_CHECK_TOOL(TARGET_NM, ${TARGET_CROSS}nm)
> +  AC_CHECK_TOOL(TARGET_RANLIB, ${TARGET_CROSS}ranlib)

AC_CHECK_TOOL(TARGET_RANLIB, ranlib, false, ${TARGET_CROSS})?

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel