* [PATCH] Add missing cast in compile-time byteswaps
@ 2024-05-16 19:22 Vladimir Serbinenko
2024-06-03 16:33 ` Daniel Kiper
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Serbinenko @ 2024-05-16 19:22 UTC (permalink / raw)
To: grub-devel; +Cc: Vladimir Serbinenko
Without them 0x80LL is 32-bit byte-swapped to 0xffffffff80000000 instead
of correct 0x80000000
Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
---
include/grub/types.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/grub/types.h b/include/grub/types.h
index 064066e2e..45079bf65 100644
--- a/include/grub/types.h
+++ b/include/grub/types.h
@@ -196,8 +196,8 @@ static inline grub_uint16_t grub_swap_bytes16(grub_uint16_t _x)
return (grub_uint16_t) ((_x << 8) | (_x >> 8));
}
-#define grub_swap_bytes16_compile_time(x) ((((x) & 0xff) << 8) | (((x) & 0xff00) >> 8))
-#define grub_swap_bytes32_compile_time(x) ((((x) & 0xff) << 24) | (((x) & 0xff00) << 8) | (((x) & 0xff0000) >> 8) | (((x) & 0xff000000UL) >> 24))
+#define grub_swap_bytes16_compile_time(x) ((grub_uint16_t)((((x) & 0xff) << 8) | (((x) & 0xff00) >> 8)))
+#define grub_swap_bytes32_compile_time(x) ((grub_uint32_t)((((x) & 0xff) << 24) | (((x) & 0xff00) << 8) | (((x) & 0xff0000) >> 8) | (((x) & 0xff000000UL) >> 24)))
#define grub_swap_bytes64_compile_time(x) \
({ \
grub_uint64_t _x = (x); \
--
2.39.2
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-03 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-16 19:22 [PATCH] Add missing cast in compile-time byteswaps Vladimir Serbinenko
2024-06-03 16:33 ` Daniel Kiper
2024-06-03 16:43 ` Daniel Kiper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.