All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, liuhangbin@gmail.com, shuah@kernel.org,
	linux-kselftest@vger.kernel.org, Petr Machata <petrm@nvidia.com>,
	vladimir.oltean@nxp.com
Subject: Re: [PATCH net v3] selftests: net: local_termination: annotate the expected failures
Date: Fri, 17 May 2024 09:54:52 +0100	[thread overview]
Message-ID: <20240517085452.GC443576@kernel.org> (raw)
In-Reply-To: <20240516152513.1115270-1-kuba@kernel.org>

On Thu, May 16, 2024 at 08:25:13AM -0700, Jakub Kicinski wrote:
> Vladimir said when adding this test:
> 
>   The bridge driver fares particularly badly [...] mainly because
>   it does not implement IFF_UNICAST_FLT.
> 
> See commit 90b9566aa5cd ("selftests: forwarding: add a test for
> local_termination.sh").
> 
> We don't want to hide the known gaps, but having a test which
> always fails prevents us from catching regressions. Report
> the cases we know may fail as XFAIL.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

I agree that XFAIL is appropriate for cases like this - the test
is expected to fail and this can act like a TODO.

I also looked over how xfail_on_veth works and this usage seems
correct to me.

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2024-05-17  8:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 15:25 [PATCH net v3] selftests: net: local_termination: annotate the expected failures Jakub Kicinski
2024-05-17  8:54 ` Simon Horman [this message]
2024-05-17  8:54 ` Hangbin Liu
2024-05-17 13:04   ` Petr Machata
2024-05-17 20:38 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240517085452.GC443576@kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=shuah@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.