Re: [Buildroot] [PATCH 1/1] package/zxing-cpp: add options for enabling readers and/or writers

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/zxing-cpp: add options for enabling readers and/or writers
Date: Fri, 17 May 2024 09:08:48 +0200	[thread overview]
Message-ID: <20240517090848.4fdbc89b@windsurf> (raw)
In-Reply-To: <20240515164912.104672-1-dario.binacchi@amarulasolutions.com>

Hello,

On Wed, 15 May 2024 18:49:12 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:

> +if BR2_PACKAGE_ZXING_CPP
> +
> +choice
> +	prompt "readers/writers support"
> +	default BR2_PACKAGE_ZXING_CPP_READERS_AND_WRITERS
> +	help
> +	  Select what you want to enable and then compile
> +
> +config BR2_PACKAGE_ZXING_CPP_READERS
> +	bool "readers only"
> +	help
> +	  Build with only readers (decoders) support
> +
> +config BR2_PACKAGE_ZXING_CPP_WRITERS
> +	bool "writers only"
> +	help
> +	  Build with only writers (encoders) support
> +
> +config BR2_PACKAGE_ZXING_CPP_READERS_AND_WRITERS
> +	bool "readers and writers"
> +	help
> +	  Build with readers and writers support
> +
> +endchoice

I don't think this should be a choice. Instead, it should be like this:

if BR2_PACKAGE_ZXING_CPP

config BR2_PACKAGE_ZXING_CPP_READERS
	bool "readers support"
	default y
	help
	  Build with readers (decoders) support

config BR2_PACKAGE_ZXING_CPP_WRITERS
	bool "writers support"
	default y
	help
	  Build with writers (encoders) support

endif

Could you rework your patch accordingly?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot