From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FA6312F5A3; Fri, 17 May 2024 17:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715965503; cv=none; b=aun2bsP7wLeprPcirlVtLEvTxyhFvhxwZrPrfwd09AykzSyuBV79AgcxD4WLH5zl9pn356sFpRJgUvk/IiJzx2ZVCb2tiJuFrxnoPofPkllGg+mLScsErwWqu+a6bCsTNg1k6p9qokvYHYn7J182sBcLAyisk8qtnHVvgpPaMb0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715965503; c=relaxed/simple; bh=2saU97BMp6H+PskEfO8ECL2dYQUoDkmrv2Pt6mDwnvE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TuL1glGh52t1JnTkqK/TtuiT3wJ5Ak+9yZ832QxBhPwTrMD9QutHfUl9zeXvtPDGFw0M0y/qC4cNIQpLzS+8qVxNaNyXz7Cu2LLYcJzKudHu24iiej4PEMItsaCYEqF1BY54oZlGK3tKLyav+MIsFWdD+gyEDelp847K0xb4z5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6f43ee95078so1207177b3a.1; Fri, 17 May 2024 10:05:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715965501; x=1716570301; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZAF2nClB9tdRe2nZvO7iQeg/IDzJ4PErDPhyqSEtfbs=; b=DSJxJQebzWu5xSgI6UnReibZT/cbSLtcO7vjcMtmv6SAYggz7hUGggTuwrrLQQzP3C tedQf9tOtSJKALUj+oIFuR6IbZvWtiqM0H1IsDe1qTxQtEXiv/bw5FY+91rkb/Crij+m C63833qMtVdnRiCo1zXYZNncW04Q6pnz97C2x8Sn4xZWz4XKA3V/ZpDtCLEonmrQU52C HK+CfXMzujTv4NSymJ4ceXCCZzGyCc+qC+hmcEdTG8fawG3N9PSEnO6FUoV6e2TDQxWq hMDlGWBUL+9ijCpaKpwMQb09MPhMov8yod1ZUGGQP5LzGxkB0vqT58fbOZPp+uIfGMPO 50kw== X-Forwarded-Encrypted: i=1; AJvYcCWwnI9FrHb9P2V1Tt/Mlo+skvseXbrUYIWFwcT4Ai1ofbdFT0iQdfp44mL0kucH4d9X8e7AMGyV2FWm/bCgnAqQgycl3+VRXthgYZAEiWIGbf9I77V5pmtgKO16NgLCiUZtWlitQFdBvMsyqzW76u69rTEL+t3WSv9N1vSGW+7bpXNfpnIR8GRIoN6bpSYpfhkxgjD8LhCXE/pkQQiQNe5xyrkW14oTjBBlak02CK0WD99yZp0Eqlbok2ZJxGEIKjNN+yXYGn6cTO018iRepc+zLJ0l/KHJSFKEoNvKh1aL4jDl X-Gm-Message-State: AOJu0YwDLnAW0dRTbZfHhstbo3bIqRm7W/7scm02X1604Jqb7vLmpbgn 9Yqo786Hzg0niJ36B98IjvJxEVQAZWXzECkMLvPfkdT+n5pWpjak X-Google-Smtp-Source: AGHT+IGDk5wz8T58ydDnsgGbyCZmHKCAeGjDn9utiYyGXMhzVl4Lcok/JS9rF8CQMUTTLF/lj2nWEQ== X-Received: by 2002:a05:6a00:238b:b0:6ea:afdb:6d03 with SMTP id d2e1a72fcca58-6f4e02d3ef9mr24111615b3a.19.1715965501417; Fri, 17 May 2024 10:05:01 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f68c7d3651sm1904783b3a.183.2024.05.17.10.04.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 10:04:59 -0700 (PDT) Date: Sat, 18 May 2024 02:04:58 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Manivannan Sadhasivam Cc: Jingoo Han , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , Shawn Lin , Heiko Stuebner , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Niklas Cassel , linux-arm-kernel@axis.com, linux-rockchip@lists.infradead.org, Frank Li Subject: Re: [PATCH v12 0/8] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host Message-ID: <20240517170458.GA1947919@rocinante> References: <20240327-pci-dbi-rework-v12-0-082625472414@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327-pci-dbi-rework-v12-0-082625472414@linaro.org> Hello, > This series is the continuation of previous work by Vidya Sagar [1] to fix the > issues related to accessing DBI register space before completing the core > initialization in some EP platforms like Tegra194/234 and Qcom EP. > > Since Vidya is busy, I took over the series based on his consent (off-list > discussion). > > NOTE > ==== > > Based on the comments received in v7 [2], I've heavily modified the series > to fix several other issues reported by Bjorn and Niklas. One noticeable > change is getting rid of the 'core_init_notifer' flag added to differentiate > between glue drivers requiring refclk from host and drivers getting refclk > locally. > > By getting rid of this flag, now both the DWC EP driver and the EPF drivers > can use a single flow and need not distinguish between the glue drivers. > > We can also get rid of the 'link_up_notifier' flag in the future by following > the same convention. > > Testing > ======= > > I've tested the series on Qcom SM8450 based dev board that depends on refclk > from host with EPF_MHI driver. It'd be good to test this series on platforms > that generate refclk locally and also with EPF_TEST driver. Applied to controller/dwc, thank you! [01/08] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host https://git.kernel.org/pci/pci/c/869bc5253406 [02/08] PCI: dwc: ep: Add Kernel-doc comments for APIs https://git.kernel.org/pci/pci/c/7cbebc86c72a [03/08] PCI: dwc: ep: Remove deinit() callback from struct dw_pcie_ep_ops https://git.kernel.org/pci/pci/c/b7dec6b85089 [04/08] PCI: dwc: ep: Rename dw_pcie_ep_exit() to dw_pcie_ep_deinit() https://git.kernel.org/pci/pci/c/c8682a3314c1 [05/08] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST# https://git.kernel.org/pci/pci/c/570d7715eed8 [06/08] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers() https://git.kernel.org/pci/pci/c/7d6e64c443ea [07/08] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers https://git.kernel.org/pci/pci/c/df69e17ccc2f [08/08] PCI: endpoint: Remove "core_init_notifier" flag https://git.kernel.org/pci/pci/c/a01e7214bef9 Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0ED44C04FFE for ; Fri, 17 May 2024 17:05:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sa3gSCCv0U5DZrJuJGy1tpawVj6myf76KmgUzGNEotk=; b=VFKilfzpeYxq1x 39jeeNF70n3QuAdexYV0Oz8kcnerE3++P9VkB9Yna6KPib6Cb7R/Z/bwC2dL0fKBLxYJBxZhJvy+o uLT0xMCzMAmMgvQKhyXjzynFHxw1zzFyVW3Z3p1/r69Eu+3vuVh9lGTWQ5ti1KA31oOUPxRS7ZJsK f6hQYO8PTzilZlFmmXiKzW28e2dYAy9Yd4ExZMoQ75qHb8rPNwZhA/eicQqf8fnDeWDu9dz+u+ptU qkHDXJdFcY4U8+vHzaLOdLIr/uBlCqnWz2n7rhCCnHGQZ5in2ELte5/ylzaBx4bCXaz7zSy0YswtE 5narKxgsLH840Gux+Hhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s8111-00000008T2o-2YDv; Fri, 17 May 2024 17:05:07 +0000 Received: from mail-pf1-f171.google.com ([209.85.210.171]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s810x-00000008T27-2Gbj; Fri, 17 May 2024 17:05:06 +0000 Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6f44bcbaae7so1253397b3a.2; Fri, 17 May 2024 10:05:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715965501; x=1716570301; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZAF2nClB9tdRe2nZvO7iQeg/IDzJ4PErDPhyqSEtfbs=; b=mTTHSQRDY481G9/KaFfQLxxJ5sffFsXiLDqkFLO6yDLWmiAQ3A/VsZMuKM3Rmn1Yrs WmiV1joDLbNQfGjQcdphgE1sAjLNDo0H1o8BfRQjPsMsIHL8ZXOckyDwElTPl4twWe8K 5ndWogdWP6M42ikf2zhbfHNI3iZeagq4w2ZqoQydKn5djqQr+jqWKoiYGVmaiedvOnlQ hlULKSKucGiQ66Lx8vtzfGEgA/Si86+8szIskG5NpuqMc+sbubMEmHt2rwgH1Csm+RNq YACPXSl3GHwmuiv1OTHU+L4SBGcrsOJoPG142BjXmf4Sb+AiIadRu1Oxs8klwY5W5mec CJNQ== X-Forwarded-Encrypted: i=1; AJvYcCWmWiWdCInuXJEyPCg23iSofM+Lqt9Z3wzZJTec9nZSkjBwC4gR2VGShUsNc3n85GXyWKpRwJTn6vDGq407l5fKKUQ0DIBuAOUFR+kDgCvcGVq3Q6Ppv8ir2Ck2saJcpC2qHct9VH6FkQTPIYeDV+gbzkqKnsjtz9o= X-Gm-Message-State: AOJu0YzLAqP2cM3A1+whxafRfm6OMcmmCTlXr5qVv9ommkwiAermnW9P sHxGCHVb334lWxI4Q+8mVNWei35KCmYupjAUFh6xVhamEARyMWYl X-Google-Smtp-Source: AGHT+IGDk5wz8T58ydDnsgGbyCZmHKCAeGjDn9utiYyGXMhzVl4Lcok/JS9rF8CQMUTTLF/lj2nWEQ== X-Received: by 2002:a05:6a00:238b:b0:6ea:afdb:6d03 with SMTP id d2e1a72fcca58-6f4e02d3ef9mr24111615b3a.19.1715965501417; Fri, 17 May 2024 10:05:01 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f68c7d3651sm1904783b3a.183.2024.05.17.10.04.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 10:04:59 -0700 (PDT) Date: Sat, 18 May 2024 02:04:58 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Manivannan Sadhasivam Cc: Jingoo Han , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , Shawn Lin , Heiko Stuebner , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Niklas Cassel , linux-arm-kernel@axis.com, linux-rockchip@lists.infradead.org, Frank Li Subject: Re: [PATCH v12 0/8] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host Message-ID: <20240517170458.GA1947919@rocinante> References: <20240327-pci-dbi-rework-v12-0-082625472414@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240327-pci-dbi-rework-v12-0-082625472414@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240517_100503_606801_0C63D161 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello, > This series is the continuation of previous work by Vidya Sagar [1] to fix the > issues related to accessing DBI register space before completing the core > initialization in some EP platforms like Tegra194/234 and Qcom EP. > > Since Vidya is busy, I took over the series based on his consent (off-list > discussion). > > NOTE > ==== > > Based on the comments received in v7 [2], I've heavily modified the series > to fix several other issues reported by Bjorn and Niklas. One noticeable > change is getting rid of the 'core_init_notifer' flag added to differentiate > between glue drivers requiring refclk from host and drivers getting refclk > locally. > > By getting rid of this flag, now both the DWC EP driver and the EPF drivers > can use a single flow and need not distinguish between the glue drivers. > > We can also get rid of the 'link_up_notifier' flag in the future by following > the same convention. > > Testing > ======= > > I've tested the series on Qcom SM8450 based dev board that depends on refclk > from host with EPF_MHI driver. It'd be good to test this series on platforms > that generate refclk locally and also with EPF_TEST driver. Applied to controller/dwc, thank you! [01/08] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host https://git.kernel.org/pci/pci/c/869bc5253406 [02/08] PCI: dwc: ep: Add Kernel-doc comments for APIs https://git.kernel.org/pci/pci/c/7cbebc86c72a [03/08] PCI: dwc: ep: Remove deinit() callback from struct dw_pcie_ep_ops https://git.kernel.org/pci/pci/c/b7dec6b85089 [04/08] PCI: dwc: ep: Rename dw_pcie_ep_exit() to dw_pcie_ep_deinit() https://git.kernel.org/pci/pci/c/c8682a3314c1 [05/08] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST# https://git.kernel.org/pci/pci/c/570d7715eed8 [06/08] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers() https://git.kernel.org/pci/pci/c/7d6e64c443ea [07/08] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers https://git.kernel.org/pci/pci/c/df69e17ccc2f [08/08] PCI: endpoint: Remove "core_init_notifier" flag https://git.kernel.org/pci/pci/c/a01e7214bef9 Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20213C25B79 for ; Fri, 17 May 2024 17:05:35 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Vgtd94gn0z30Wn for ; Sat, 18 May 2024 03:05:33 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.210.179; helo=mail-pf1-f179.google.com; envelope-from=kswilczynski@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Vgtcg6gsDz2ysf for ; Sat, 18 May 2024 03:05:06 +1000 (AEST) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6f44bcbaae7so1253396b3a.2 for ; Fri, 17 May 2024 10:05:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715965501; x=1716570301; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZAF2nClB9tdRe2nZvO7iQeg/IDzJ4PErDPhyqSEtfbs=; b=niGcP7GYLqsMmmpUzRZrEcDHAxZ9EczMtpo+mU4vnDbwtW76V/1XopmXOcPlaxa5+a e6rFLvB0Ye2mX5e7U0Dbyfdi35qGW0Uyk825rdFzQhJgQ7a1efyWd0FFNPnaxaf9cs1h qJQB0HLr0WZq11eYHkZfUL2wvESsFz5xWyBdq/6jK+YZKpQpS2J51fDj6OwUqIo2Xchu Zsc+0enO8u1sh6Yp6tuGAnniMkYl16pK5YC8UNuAqsDEdG82mym3l3cmIA2TdYkU7z+u GxzZ+zdlbSMv+Tw8IQKJAEarED3T2WDihTZk3DJL61U084sO7c+W1NrBqwd2gm9wMUUm OQZw== X-Forwarded-Encrypted: i=1; AJvYcCXYKgol/DgjvmNHEAWSNqnvoIycoIS1Mh/iNTOQ0hEPmsVv9iwvkAFtbipontaqA9S0bS3NZr8RvZkAtla1KfOKIJBcw9rq7BSGcwA1EA== X-Gm-Message-State: AOJu0YyWevfcP5KxoWl3gin1ZzDWIr0JbgZU9bodJ23evTeGPEOxY53o 3aH0G0f6gqbEY665zpAJrnlIsE7w7Uz7fQXjWzJSxJS5KrrRD+hj X-Google-Smtp-Source: AGHT+IGDk5wz8T58ydDnsgGbyCZmHKCAeGjDn9utiYyGXMhzVl4Lcok/JS9rF8CQMUTTLF/lj2nWEQ== X-Received: by 2002:a05:6a00:238b:b0:6ea:afdb:6d03 with SMTP id d2e1a72fcca58-6f4e02d3ef9mr24111615b3a.19.1715965501417; Fri, 17 May 2024 10:05:01 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f68c7d3651sm1904783b3a.183.2024.05.17.10.04.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 10:04:59 -0700 (PDT) Date: Sat, 18 May 2024 02:04:58 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Manivannan Sadhasivam Subject: Re: [PATCH v12 0/8] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host Message-ID: <20240517170458.GA1947919@rocinante> References: <20240327-pci-dbi-rework-v12-0-082625472414@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327-pci-dbi-rework-v12-0-082625472414@linaro.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Kunihiko Hayashi , linux-pci@vger.kernel.org, Lorenzo Pieralisi , Frank Li , Minghuan Lian , Thierry Reding , Fabio Estevam , Marek Vasut , Kishon Vijay Abraham I , Rob Herring , Jesper Nilsson , linux-tegra@vger.kernel.org, linux-arm-kernel@axis.com, Jonathan Hunter , linux-rockchip@lists.infradead.org, NXP Linux Team , Shawn Lin , Richard Zhu , Srikanth Thokala , linux-arm-msm@vger.kernel.org, Sascha Hauer , linuxppc-dev@lists.ozlabs.org, Bjorn Helgaas , linux-omap@vger.kernel.org, Mingkai Hu , linux-arm-kernel@lists.infradead.org, Roy Zang , Niklas Cassel , Jingoo Han , Yoshihiro Shimoda , Heiko Stuebner , linux-kernel@vger.kernel.org, Vidya Sagar , linux-renesas-soc@vger.kernel.org, Masami Hiramatsu , Pengutronix Kernel Team , Shawn Guo , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hello, > This series is the continuation of previous work by Vidya Sagar [1] to fix the > issues related to accessing DBI register space before completing the core > initialization in some EP platforms like Tegra194/234 and Qcom EP. > > Since Vidya is busy, I took over the series based on his consent (off-list > discussion). > > NOTE > ==== > > Based on the comments received in v7 [2], I've heavily modified the series > to fix several other issues reported by Bjorn and Niklas. One noticeable > change is getting rid of the 'core_init_notifer' flag added to differentiate > between glue drivers requiring refclk from host and drivers getting refclk > locally. > > By getting rid of this flag, now both the DWC EP driver and the EPF drivers > can use a single flow and need not distinguish between the glue drivers. > > We can also get rid of the 'link_up_notifier' flag in the future by following > the same convention. > > Testing > ======= > > I've tested the series on Qcom SM8450 based dev board that depends on refclk > from host with EPF_MHI driver. It'd be good to test this series on platforms > that generate refclk locally and also with EPF_TEST driver. Applied to controller/dwc, thank you! [01/08] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host https://git.kernel.org/pci/pci/c/869bc5253406 [02/08] PCI: dwc: ep: Add Kernel-doc comments for APIs https://git.kernel.org/pci/pci/c/7cbebc86c72a [03/08] PCI: dwc: ep: Remove deinit() callback from struct dw_pcie_ep_ops https://git.kernel.org/pci/pci/c/b7dec6b85089 [04/08] PCI: dwc: ep: Rename dw_pcie_ep_exit() to dw_pcie_ep_deinit() https://git.kernel.org/pci/pci/c/c8682a3314c1 [05/08] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST# https://git.kernel.org/pci/pci/c/570d7715eed8 [06/08] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers() https://git.kernel.org/pci/pci/c/7d6e64c443ea [07/08] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers https://git.kernel.org/pci/pci/c/df69e17ccc2f [08/08] PCI: endpoint: Remove "core_init_notifier" flag https://git.kernel.org/pci/pci/c/a01e7214bef9 Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F264C04FFE for ; Fri, 17 May 2024 17:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n4Gr9b546HnXdFq5zWIladeeG/DZZgg3OE+V57jv8Ac=; b=wVPOlFsApwprmZ 1faRneJw0m3yuzqY1cLPSxst6nY8pAIvXrl+vKpLzL7VjYL2X84gYAO32yUiG4CL1NmeLlBDu3QF2 3ZQHML9OTjTr16jOj/moV2SKAamPYJi7poKEiIQqTZ+kkSglsQVWCvm01bV5LXAarrTERbU9m/J+8 LvDaPYb9vT7q0aK+I6aaKZmOeCnleVJFJjO4yd5uD+WG7iSh+4zjD24pwQTgOMgSYu+Y3HBLNGPYY yAPzuaZma/+qU7M761oeVYQuxtbNTf6GzQqmBRuNw+l4r1KdlrHzDC5VO+dc1r4+4E5vJeJhbIq54 xIU7NmxteFobGpaM5ouw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s8111-00000008T2j-0KF7; Fri, 17 May 2024 17:05:07 +0000 Received: from mail-pf1-f171.google.com ([209.85.210.171]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s810x-00000008T27-2Gbj; Fri, 17 May 2024 17:05:06 +0000 Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6f44bcbaae7so1253397b3a.2; Fri, 17 May 2024 10:05:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715965501; x=1716570301; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZAF2nClB9tdRe2nZvO7iQeg/IDzJ4PErDPhyqSEtfbs=; b=mTTHSQRDY481G9/KaFfQLxxJ5sffFsXiLDqkFLO6yDLWmiAQ3A/VsZMuKM3Rmn1Yrs WmiV1joDLbNQfGjQcdphgE1sAjLNDo0H1o8BfRQjPsMsIHL8ZXOckyDwElTPl4twWe8K 5ndWogdWP6M42ikf2zhbfHNI3iZeagq4w2ZqoQydKn5djqQr+jqWKoiYGVmaiedvOnlQ hlULKSKucGiQ66Lx8vtzfGEgA/Si86+8szIskG5NpuqMc+sbubMEmHt2rwgH1Csm+RNq YACPXSl3GHwmuiv1OTHU+L4SBGcrsOJoPG142BjXmf4Sb+AiIadRu1Oxs8klwY5W5mec CJNQ== X-Forwarded-Encrypted: i=1; AJvYcCWmWiWdCInuXJEyPCg23iSofM+Lqt9Z3wzZJTec9nZSkjBwC4gR2VGShUsNc3n85GXyWKpRwJTn6vDGq407l5fKKUQ0DIBuAOUFR+kDgCvcGVq3Q6Ppv8ir2Ck2saJcpC2qHct9VH6FkQTPIYeDV+gbzkqKnsjtz9o= X-Gm-Message-State: AOJu0YzLAqP2cM3A1+whxafRfm6OMcmmCTlXr5qVv9ommkwiAermnW9P sHxGCHVb334lWxI4Q+8mVNWei35KCmYupjAUFh6xVhamEARyMWYl X-Google-Smtp-Source: AGHT+IGDk5wz8T58ydDnsgGbyCZmHKCAeGjDn9utiYyGXMhzVl4Lcok/JS9rF8CQMUTTLF/lj2nWEQ== X-Received: by 2002:a05:6a00:238b:b0:6ea:afdb:6d03 with SMTP id d2e1a72fcca58-6f4e02d3ef9mr24111615b3a.19.1715965501417; Fri, 17 May 2024 10:05:01 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f68c7d3651sm1904783b3a.183.2024.05.17.10.04.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 May 2024 10:04:59 -0700 (PDT) Date: Sat, 18 May 2024 02:04:58 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Manivannan Sadhasivam Cc: Jingoo Han , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , Jesper Nilsson , Srikanth Thokala , Shawn Lin , Heiko Stuebner , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Niklas Cassel , linux-arm-kernel@axis.com, linux-rockchip@lists.infradead.org, Frank Li Subject: Re: [PATCH v12 0/8] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host Message-ID: <20240517170458.GA1947919@rocinante> References: <20240327-pci-dbi-rework-v12-0-082625472414@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240327-pci-dbi-rework-v12-0-082625472414@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240517_100503_606801_0C63D161 X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, > This series is the continuation of previous work by Vidya Sagar [1] to fix the > issues related to accessing DBI register space before completing the core > initialization in some EP platforms like Tegra194/234 and Qcom EP. > > Since Vidya is busy, I took over the series based on his consent (off-list > discussion). > > NOTE > ==== > > Based on the comments received in v7 [2], I've heavily modified the series > to fix several other issues reported by Bjorn and Niklas. One noticeable > change is getting rid of the 'core_init_notifer' flag added to differentiate > between glue drivers requiring refclk from host and drivers getting refclk > locally. > > By getting rid of this flag, now both the DWC EP driver and the EPF drivers > can use a single flow and need not distinguish between the glue drivers. > > We can also get rid of the 'link_up_notifier' flag in the future by following > the same convention. > > Testing > ======= > > I've tested the series on Qcom SM8450 based dev board that depends on refclk > from host with EPF_MHI driver. It'd be good to test this series on platforms > that generate refclk locally and also with EPF_TEST driver. Applied to controller/dwc, thank you! [01/08] PCI: dwc: ep: Fix DBI access failure for drivers requiring refclk from host https://git.kernel.org/pci/pci/c/869bc5253406 [02/08] PCI: dwc: ep: Add Kernel-doc comments for APIs https://git.kernel.org/pci/pci/c/7cbebc86c72a [03/08] PCI: dwc: ep: Remove deinit() callback from struct dw_pcie_ep_ops https://git.kernel.org/pci/pci/c/b7dec6b85089 [04/08] PCI: dwc: ep: Rename dw_pcie_ep_exit() to dw_pcie_ep_deinit() https://git.kernel.org/pci/pci/c/c8682a3314c1 [05/08] PCI: dwc: ep: Introduce dw_pcie_ep_cleanup() API for drivers supporting PERST# https://git.kernel.org/pci/pci/c/570d7715eed8 [06/08] PCI: dwc: ep: Rename dw_pcie_ep_init_complete() to dw_pcie_ep_init_registers() https://git.kernel.org/pci/pci/c/7d6e64c443ea [07/08] PCI: dwc: ep: Call dw_pcie_ep_init_registers() API directly from all glue drivers https://git.kernel.org/pci/pci/c/df69e17ccc2f [08/08] PCI: endpoint: Remove "core_init_notifier" flag https://git.kernel.org/pci/pci/c/a01e7214bef9 Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel