From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57F21C25B74 for ; Sat, 18 May 2024 10:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=StLT/TAKe5osGQwZPYVPgamvFkFUKRidLyLN/P6sI00=; b=C3RNg5sZ8oldhg 19gMxkWHPutxGLG8b7gu6TGUfOy030QqF2XPReHHxye0UIrkVslOr5U/y1e+n8pKAuX5H5F/pjSjd xlp4sFbDXuhgfzAckl8EelBdTrpQOJugABHaYJZFxrFIPSMwG7DAIWFokxHlyhQfclEChQihkLd/H NnLfiQDOx1wWRZceqOSmQwj7FCYcBJFUywjeL0zPUXX+dEW13Rwy0D3pUqYxwQqnGUoLQ2FjsMTt/ EN+M7gT1kA9nFPpPB6OVsEaA5oq4QKXN1QLUT7omw2fOqnrvZSOl3avbHMFDv67usEB02lQPXDrP4 0Wl4D+Wjf2frJbqrFJtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s8HYH-00000009v1j-0TYf; Sat, 18 May 2024 10:44:33 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s8HYC-00000009v0g-3EmM; Sat, 18 May 2024 10:44:30 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0661D40003; Sat, 18 May 2024 10:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1716029063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+g0Djet6VPor+0w2My6R6Rpd8gd93fTaLQzxiswyYc8=; b=dJ1HM4sVgpsZAO+szA2uDJZWhF2Xaigaf8SQ/cwA6DxsJD9fN3RFW2thSnsxioBdD11sGy m6zCzsjLDg1wSAwYoYRgiJlLNL9RdmRqKXLyfg1Xvmo8Z0uJBrf/agKf0X3vrBcBqnPit3 mYxHPYcpDMpZIee5Z1IShXvt8EPkNr1q6v6JsmdVRQL2FCkNSuLAJZtvrYeNKB2akQLd6r +quT7wUKLbNb66kNqBsVo4hweJrp+vOtpd2IBzMFfK1sU+0B1NQdhmuc1KJZoB8LePNocv AUZGzIbI2LbNdabEAX3+TlI1kURXa5IfohYgK5b1glIkgNMAgynbvHeCY9fZNg== Date: Sat, 18 May 2024 12:44:19 +0200 From: Miquel Raynal To: Val Packett Cc: Richard Weinberger , Vignesh Raghavendra , Heiko Stuebner , Stephen Rothwell , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: rockchip: reject NVDDR timings when checked Message-ID: <20240518124404.472eb60b@xps-13> In-Reply-To: <20240518033923.5577-2-val@packett.cool> References: <20240518033923.5577-2-val@packett.cool> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240518_034429_119261_EE0DBB15 X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgVmFsLAoKSSBtaWdodCBwcm9wb3NlIGEgc2xpZ2h0bHkgZGlmZmVyZW50IHRpdGxlIHdoaWNo IEkgdGhpbmsgYmV0dGVyCmRlc2NyaWJlcyB0aGUgc2l0dWF0aW9uOgoibXRkOiByYXduYW5kOiBy b2NrY2hpcDogZW5zdXJlIE5WRERSIHRpbWluZ3MgYXJlIHJlamVjdGVkIgoKdmFsQHBhY2tldHQu Y29vbCB3cm90ZSBvbiBTYXQsIDE4IE1heSAyMDI0IDAwOjMxOjEzIC0wMzAwOgoKPiAuc2V0dXBf aW50ZXJmYWNlIGZpcnN0IGdldHMgY2FsbGVkIHdpdGggYSBuZWdhdGl2ZSAidGFyZ2V0IiB2YWx1 ZQoKSnVzdCBhcyBhbiBGWUksIHRoZSBmYWN0IHRoYXQgaXQgaXMgbmVnYXRpdmUgaXMgYW4gaW1w bGVtZW50YXRpb24KZGV0YWlsLCBidXQgeW91IG1lbnRpb24gdGhlICNkZWZpbmUgb2YgdGhlIHZh bHVlIGJlbG93LCBzbyB0aGF0J3MgZmluZS4KIAo+IE5BTkRfREFUQV9JRkFDRV9DSEVDS19PTkxZ LCBpbiB3aGljaCBjYXNlIGFuIGVycm9yIGlzIGV4cGVjdGVkCj4gaWYgdGhlIGNvbnRyb2xsZXIg ZHJpdmVyIGRvZXMgbm90IHN1cHBvcnQgdGhlIHRpbWluZyBtb2RlIChOVkREUikuCj4gCgpIZXJl IEkgd291bGQgd2VsY29tZSB0d28gdGFncyBpbiBvcmRlciB0byBnZXQgdGhpcyBiYWNrcG9ydGVk IGFzIGVhcmx5CmFzIG5lZWRlZCBpbiBzdGFibGUga2VybmVsczoKCkNjOiBzdGFibGVAdmdlci5r ZXJuZWwub3JnCkZpeGVzOiBhOWVjYzhjODE0ZTkgKCJtdGQ6IHJhd25hbmQ6IENob29zZSB0aGUg YmVzdCB0aW1pbmdzLCBOVi1ERFIgaW5jbHVkZWQiKQoKPiBTaWduZWQtb2ZmLWJ5OiBWYWwgUGFj a2V0dCA8dmFsQHBhY2tldHQuY29vbD4KPiAtLS0KPiBIZWxsbyBldmVyeW9uZSwgZmlyc3QgTGlu dXggcGF0Y2ggZnJvbSBhIGxvbmcgdGltZSBGcmVlQlNEIHBlcnNvbiA6KQo+IAo+IFRoaXMgd2Fz IHJlcXVpcmVkIHRvIGdldCB0aGUgTkFORCBjb250cm9sbGVyIHRvIGF0dGFjaCBvbiB0aGUgcmFu ZG9tCj4gb2xkIFJLMzA2NiB0YWJsZXQgSSdtIGJyaW5naW5nIHVwIG1haW5saW5lIG9uLgoKV2Vs Y29tZSEgVGhlIGZpeCBsb29rcyByaWdodCBiZXNpZGVzIG1pbm9yIG5pdHMgaW4gdGhlIGNvbW1p dCBsb2cuIEknbGwKcHJvYmFibHkgdGFrZSB0aGUgdjIgd2hlbiBpdCdzIG91dCBhZnRlciAtcmMx IGhhcyBiZWVuIHRhZ2dlZC4KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1h aWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5ADBC25B74 for ; Sat, 18 May 2024 10:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WK4z8VRMnYzSvW4xaKfm0lJQfrFo8SFYFcVq3OkPT1s=; b=xmnCKHDiqXEOjP qdEKsNiLE6bskdiKkco1YZOa1D/SpUEEbRBO/6X6Ly5rhcPcgCYJVF0tTOdqtPSXKH4/mnlRYHxqO khxUU0lTTIBptt+819dfXiRaq3Simg7XAwCGoZ7SZXtsD8twsJAh4xk2bg2jWRjqL+/7z0aMUqJOF Z5Kue+/TOjRATaNaBK7JWpJYsEsq2dwf4c1E00q56F6YQuCDH/LC7OG72KH7kCkhOr5yJXP1iasiE 9wIzDdKimWbU4gkAFQ7J0DKTPGn4nshEyZf2s+Pt5RU7lDOi1dRLrMuY5LtPRrO5g3doryASyv0s1 lGsupoZE/hdvnMzNzYAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s8HYH-00000009v1t-39YU; Sat, 18 May 2024 10:44:33 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s8HYC-00000009v0g-3EmM; Sat, 18 May 2024 10:44:30 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0661D40003; Sat, 18 May 2024 10:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1716029063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+g0Djet6VPor+0w2My6R6Rpd8gd93fTaLQzxiswyYc8=; b=dJ1HM4sVgpsZAO+szA2uDJZWhF2Xaigaf8SQ/cwA6DxsJD9fN3RFW2thSnsxioBdD11sGy m6zCzsjLDg1wSAwYoYRgiJlLNL9RdmRqKXLyfg1Xvmo8Z0uJBrf/agKf0X3vrBcBqnPit3 mYxHPYcpDMpZIee5Z1IShXvt8EPkNr1q6v6JsmdVRQL2FCkNSuLAJZtvrYeNKB2akQLd6r +quT7wUKLbNb66kNqBsVo4hweJrp+vOtpd2IBzMFfK1sU+0B1NQdhmuc1KJZoB8LePNocv AUZGzIbI2LbNdabEAX3+TlI1kURXa5IfohYgK5b1glIkgNMAgynbvHeCY9fZNg== Date: Sat, 18 May 2024 12:44:19 +0200 From: Miquel Raynal To: Val Packett Cc: Richard Weinberger , Vignesh Raghavendra , Heiko Stuebner , Stephen Rothwell , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: rockchip: reject NVDDR timings when checked Message-ID: <20240518124404.472eb60b@xps-13> In-Reply-To: <20240518033923.5577-2-val@packett.cool> References: <20240518033923.5577-2-val@packett.cool> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240518_034429_119261_EE0DBB15 X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgVmFsLAoKSSBtaWdodCBwcm9wb3NlIGEgc2xpZ2h0bHkgZGlmZmVyZW50IHRpdGxlIHdoaWNo IEkgdGhpbmsgYmV0dGVyCmRlc2NyaWJlcyB0aGUgc2l0dWF0aW9uOgoibXRkOiByYXduYW5kOiBy b2NrY2hpcDogZW5zdXJlIE5WRERSIHRpbWluZ3MgYXJlIHJlamVjdGVkIgoKdmFsQHBhY2tldHQu Y29vbCB3cm90ZSBvbiBTYXQsIDE4IE1heSAyMDI0IDAwOjMxOjEzIC0wMzAwOgoKPiAuc2V0dXBf aW50ZXJmYWNlIGZpcnN0IGdldHMgY2FsbGVkIHdpdGggYSBuZWdhdGl2ZSAidGFyZ2V0IiB2YWx1 ZQoKSnVzdCBhcyBhbiBGWUksIHRoZSBmYWN0IHRoYXQgaXQgaXMgbmVnYXRpdmUgaXMgYW4gaW1w bGVtZW50YXRpb24KZGV0YWlsLCBidXQgeW91IG1lbnRpb24gdGhlICNkZWZpbmUgb2YgdGhlIHZh bHVlIGJlbG93LCBzbyB0aGF0J3MgZmluZS4KIAo+IE5BTkRfREFUQV9JRkFDRV9DSEVDS19PTkxZ LCBpbiB3aGljaCBjYXNlIGFuIGVycm9yIGlzIGV4cGVjdGVkCj4gaWYgdGhlIGNvbnRyb2xsZXIg ZHJpdmVyIGRvZXMgbm90IHN1cHBvcnQgdGhlIHRpbWluZyBtb2RlIChOVkREUikuCj4gCgpIZXJl IEkgd291bGQgd2VsY29tZSB0d28gdGFncyBpbiBvcmRlciB0byBnZXQgdGhpcyBiYWNrcG9ydGVk IGFzIGVhcmx5CmFzIG5lZWRlZCBpbiBzdGFibGUga2VybmVsczoKCkNjOiBzdGFibGVAdmdlci5r ZXJuZWwub3JnCkZpeGVzOiBhOWVjYzhjODE0ZTkgKCJtdGQ6IHJhd25hbmQ6IENob29zZSB0aGUg YmVzdCB0aW1pbmdzLCBOVi1ERFIgaW5jbHVkZWQiKQoKPiBTaWduZWQtb2ZmLWJ5OiBWYWwgUGFj a2V0dCA8dmFsQHBhY2tldHQuY29vbD4KPiAtLS0KPiBIZWxsbyBldmVyeW9uZSwgZmlyc3QgTGlu dXggcGF0Y2ggZnJvbSBhIGxvbmcgdGltZSBGcmVlQlNEIHBlcnNvbiA6KQo+IAo+IFRoaXMgd2Fz IHJlcXVpcmVkIHRvIGdldCB0aGUgTkFORCBjb250cm9sbGVyIHRvIGF0dGFjaCBvbiB0aGUgcmFu ZG9tCj4gb2xkIFJLMzA2NiB0YWJsZXQgSSdtIGJyaW5naW5nIHVwIG1haW5saW5lIG9uLgoKV2Vs Y29tZSEgVGhlIGZpeCBsb29rcyByaWdodCBiZXNpZGVzIG1pbm9yIG5pdHMgaW4gdGhlIGNvbW1p dCBsb2cuIEknbGwKcHJvYmFibHkgdGFrZSB0aGUgdjIgd2hlbiBpdCdzIG91dCBhZnRlciAtcmMx IGhhcyBiZWVuIHRhZ2dlZC4KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0Ckxp bnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B999C25B74 for ; Sat, 18 May 2024 10:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tsytIG6mFnTIp1Ri3k4QcoZGp0ZpGPQqkzN2D8rVTyw=; b=vJKo8b79qHPj0M JAijg4ACfTtGKKjoIqEAFPJvtQB06dS8ssM29IoDMoBu3Jhl38OZoQkTRP21Zwrk/LQ0ibD3uwsYy AgCoIc5uGdG7L+psoVyfb+WQE/EkH0n6FC8t0NLI4utNcBgX/GdVOpkHe7VZFbVuZf9HPfA6F0Q0B DCa210Zovf5j3MrK/wMRPDxdFzMjr0v8VOA/l0dTyQC77w0vk36/pFX5MwDmhj9IKctuOxEec9zaU E9We6AiZUp2k9Tl6GbM1FpLBbWNSQGJsS/z1VNLLLzdUmS00KEC+wL7KWDtuwDYx+M7LhtjpTQaD3 ANnLxE/18cscA5BTjaCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s8HYF-00000009v1P-2rVK; Sat, 18 May 2024 10:44:31 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s8HYC-00000009v0g-3EmM; Sat, 18 May 2024 10:44:30 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0661D40003; Sat, 18 May 2024 10:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1716029063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+g0Djet6VPor+0w2My6R6Rpd8gd93fTaLQzxiswyYc8=; b=dJ1HM4sVgpsZAO+szA2uDJZWhF2Xaigaf8SQ/cwA6DxsJD9fN3RFW2thSnsxioBdD11sGy m6zCzsjLDg1wSAwYoYRgiJlLNL9RdmRqKXLyfg1Xvmo8Z0uJBrf/agKf0X3vrBcBqnPit3 mYxHPYcpDMpZIee5Z1IShXvt8EPkNr1q6v6JsmdVRQL2FCkNSuLAJZtvrYeNKB2akQLd6r +quT7wUKLbNb66kNqBsVo4hweJrp+vOtpd2IBzMFfK1sU+0B1NQdhmuc1KJZoB8LePNocv AUZGzIbI2LbNdabEAX3+TlI1kURXa5IfohYgK5b1glIkgNMAgynbvHeCY9fZNg== Date: Sat, 18 May 2024 12:44:19 +0200 From: Miquel Raynal To: Val Packett Cc: Richard Weinberger , Vignesh Raghavendra , Heiko Stuebner , Stephen Rothwell , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: rockchip: reject NVDDR timings when checked Message-ID: <20240518124404.472eb60b@xps-13> In-Reply-To: <20240518033923.5577-2-val@packett.cool> References: <20240518033923.5577-2-val@packett.cool> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240518_034429_119261_EE0DBB15 X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVmFsLAoKSSBtaWdodCBwcm9wb3NlIGEgc2xpZ2h0bHkgZGlmZmVyZW50IHRpdGxlIHdoaWNo IEkgdGhpbmsgYmV0dGVyCmRlc2NyaWJlcyB0aGUgc2l0dWF0aW9uOgoibXRkOiByYXduYW5kOiBy b2NrY2hpcDogZW5zdXJlIE5WRERSIHRpbWluZ3MgYXJlIHJlamVjdGVkIgoKdmFsQHBhY2tldHQu Y29vbCB3cm90ZSBvbiBTYXQsIDE4IE1heSAyMDI0IDAwOjMxOjEzIC0wMzAwOgoKPiAuc2V0dXBf aW50ZXJmYWNlIGZpcnN0IGdldHMgY2FsbGVkIHdpdGggYSBuZWdhdGl2ZSAidGFyZ2V0IiB2YWx1 ZQoKSnVzdCBhcyBhbiBGWUksIHRoZSBmYWN0IHRoYXQgaXQgaXMgbmVnYXRpdmUgaXMgYW4gaW1w bGVtZW50YXRpb24KZGV0YWlsLCBidXQgeW91IG1lbnRpb24gdGhlICNkZWZpbmUgb2YgdGhlIHZh bHVlIGJlbG93LCBzbyB0aGF0J3MgZmluZS4KIAo+IE5BTkRfREFUQV9JRkFDRV9DSEVDS19PTkxZ LCBpbiB3aGljaCBjYXNlIGFuIGVycm9yIGlzIGV4cGVjdGVkCj4gaWYgdGhlIGNvbnRyb2xsZXIg ZHJpdmVyIGRvZXMgbm90IHN1cHBvcnQgdGhlIHRpbWluZyBtb2RlIChOVkREUikuCj4gCgpIZXJl IEkgd291bGQgd2VsY29tZSB0d28gdGFncyBpbiBvcmRlciB0byBnZXQgdGhpcyBiYWNrcG9ydGVk IGFzIGVhcmx5CmFzIG5lZWRlZCBpbiBzdGFibGUga2VybmVsczoKCkNjOiBzdGFibGVAdmdlci5r ZXJuZWwub3JnCkZpeGVzOiBhOWVjYzhjODE0ZTkgKCJtdGQ6IHJhd25hbmQ6IENob29zZSB0aGUg YmVzdCB0aW1pbmdzLCBOVi1ERFIgaW5jbHVkZWQiKQoKPiBTaWduZWQtb2ZmLWJ5OiBWYWwgUGFj a2V0dCA8dmFsQHBhY2tldHQuY29vbD4KPiAtLS0KPiBIZWxsbyBldmVyeW9uZSwgZmlyc3QgTGlu dXggcGF0Y2ggZnJvbSBhIGxvbmcgdGltZSBGcmVlQlNEIHBlcnNvbiA6KQo+IAo+IFRoaXMgd2Fz IHJlcXVpcmVkIHRvIGdldCB0aGUgTkFORCBjb250cm9sbGVyIHRvIGF0dGFjaCBvbiB0aGUgcmFu ZG9tCj4gb2xkIFJLMzA2NiB0YWJsZXQgSSdtIGJyaW5naW5nIHVwIG1haW5saW5lIG9uLgoKV2Vs Y29tZSEgVGhlIGZpeCBsb29rcyByaWdodCBiZXNpZGVzIG1pbm9yIG5pdHMgaW4gdGhlIGNvbW1p dCBsb2cuIEknbGwKcHJvYmFibHkgdGFrZSB0aGUgdjIgd2hlbiBpdCdzIG91dCBhZnRlciAtcmMx IGhhcyBiZWVuIHRhZ2dlZC4KClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2707946F for ; Sat, 18 May 2024 10:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716029067; cv=none; b=YgdvwbXqYHN1CMExEuxTaPVTlnOeHVAbrMEx3b9wATuKqpVZbJNaLpHBERxfOuNTGMNBqu3WFFaIeRxB22ENm7a9N4C7lu3Lc9MKGbLpNHsvDsUemXS1bBVxxTu03umQZnqX50drAGsP31jl04I33dP8FvsVqoIlYM3V+ZHvhoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716029067; c=relaxed/simple; bh=+g0Djet6VPor+0w2My6R6Rpd8gd93fTaLQzxiswyYc8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FGuhWUteIBkmiY1qJNB34bNMxES8z4nF47N0R6dC3lrg0deEoicY9qSPjSpNGT1zIEywoFj6dCaYhoIh06J09hsHV/ivhS5Rl3nyWrysN+342dQGiCQPliKiyM+Oc1PMJ4V30sMQibz5tBTUIOxLS2lnMJCPRf6WK6o0ygL98gQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=dJ1HM4sV; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dJ1HM4sV" Received: by mail.gandi.net (Postfix) with ESMTPSA id 0661D40003; Sat, 18 May 2024 10:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1716029063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+g0Djet6VPor+0w2My6R6Rpd8gd93fTaLQzxiswyYc8=; b=dJ1HM4sVgpsZAO+szA2uDJZWhF2Xaigaf8SQ/cwA6DxsJD9fN3RFW2thSnsxioBdD11sGy m6zCzsjLDg1wSAwYoYRgiJlLNL9RdmRqKXLyfg1Xvmo8Z0uJBrf/agKf0X3vrBcBqnPit3 mYxHPYcpDMpZIee5Z1IShXvt8EPkNr1q6v6JsmdVRQL2FCkNSuLAJZtvrYeNKB2akQLd6r +quT7wUKLbNb66kNqBsVo4hweJrp+vOtpd2IBzMFfK1sU+0B1NQdhmuc1KJZoB8LePNocv AUZGzIbI2LbNdabEAX3+TlI1kURXa5IfohYgK5b1glIkgNMAgynbvHeCY9fZNg== Date: Sat, 18 May 2024 12:44:19 +0200 From: Miquel Raynal To: Val Packett Cc: Richard Weinberger , Vignesh Raghavendra , Heiko Stuebner , Stephen Rothwell , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: rawnand: rockchip: reject NVDDR timings when checked Message-ID: <20240518124404.472eb60b@xps-13> In-Reply-To: <20240518033923.5577-2-val@packett.cool> References: <20240518033923.5577-2-val@packett.cool> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Val, I might propose a slightly different title which I think better describes the situation: "mtd: rawnand: rockchip: ensure NVDDR timings are rejected" val@packett.cool wrote on Sat, 18 May 2024 00:31:13 -0300: > .setup_interface first gets called with a negative "target" value Just as an FYI, the fact that it is negative is an implementation detail, but you mention the #define of the value below, so that's fine. =20 > NAND_DATA_IFACE_CHECK_ONLY, in which case an error is expected > if the controller driver does not support the timing mode (NVDDR). >=20 Here I would welcome two tags in order to get this backported as early as needed in stable kernels: Cc: stable@vger.kernel.org Fixes: a9ecc8c814e9 ("mtd: rawnand: Choose the best timings, NV-DDR include= d") > Signed-off-by: Val Packett > --- > Hello everyone, first Linux patch from a long time FreeBSD person :) >=20 > This was required to get the NAND controller to attach on the random > old RK3066 tablet I'm bringing up mainline on. Welcome! The fix looks right besides minor nits in the commit log. I'll probably take the v2 when it's out after -rc1 has been tagged. Thanks, Miqu=C3=A8l