From: Christoph Hellwig <hch@lst.de>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: brauner@kernel.org, djwong@kernel.org, willy@infradead.org,
hch@lst.de, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, jun.li@nxp.com
Subject: Re: [PATCH v3] iomap: avoid redundant fault_in_iov_iter_readable() judgement when use larger chunks
Date: Mon, 20 May 2024 17:29:17 +0200 [thread overview]
Message-ID: <20240520152917.GA485@lst.de> (raw)
In-Reply-To: <20240520105525.2176322-1-xu.yang_2@nxp.com>
This looks generally good. But a few nitpicks:
- please split the mapping_max_folio_size addition into a separate
well-documented helper instead of merging it into the iomap change.
- judgment is a really weird term for code. Here is a subject I came
up with, which might not be perfect:
"iomap: fault in smaller chunks for non-large folio mappings"
next prev parent reply other threads:[~2024-05-20 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 10:55 [PATCH v3] iomap: avoid redundant fault_in_iov_iter_readable() judgement when use larger chunks Xu Yang
2024-05-20 15:08 ` Darrick J. Wong
2024-05-21 1:51 ` Xu Yang
2024-05-20 15:29 ` Christoph Hellwig [this message]
2024-05-21 1:57 ` Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240520152917.GA485@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=jun.li@nxp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.