From: Simon Horman <horms@kernel.org>
To: Ronak Doshi <ronak.doshi@broadcom.com>
Cc: netdev@vger.kernel.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 2/4] vmxnet3: add latency measurement support in vmxnet3
Date: Mon, 20 May 2024 21:06:10 +0100 [thread overview]
Message-ID: <20240520200610.GD764145@kernel.org> (raw)
In-Reply-To: <CAP1Q3XQKStM5Tn9HZjTdgki4_7RiF8EOf0ksZE9gzZYHNkAFbQ@mail.gmail.com>
On Mon, May 20, 2024 at 12:19:43PM -0700, Ronak Doshi wrote:
> > On Wed, May 15, 2024 at 3:46 AM Simon Horman <horms@kernel.org> wrote:
> > If not, I would suggest making this feature optional and only compiled
> > for x86. That might mean factoring it out into a different file. I'm
> > unsure.
> I can move the rdpmc code under #if defined(__i386__) ||
> defined(__x86_64__) so that it will be no-op for other architectures.
> Will that be fine?
Hi Ronak,
I think that it would be an good improvement, as long as the result is a
working driver for other architectures.
Perhaps #ifdef CONFIG_X86 can be used as the guard.
I also would suggest using rdpmc helpers if possible.
next prev parent reply other threads:[~2024-05-20 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 18:20 [PATCH net-next 0/4] vmxnet3: upgrade to version 9 Ronak Doshi
2024-05-14 18:20 ` [PATCH net-next 1/4] vmxnet3: prepare for version 9 changes Ronak Doshi
2024-05-14 18:20 ` [PATCH net-next 2/4] vmxnet3: add latency measurement support in vmxnet3 Ronak Doshi
2024-05-15 10:46 ` Simon Horman
[not found] ` <CAP1Q3XRYGySJQaWe8dvasUGmpZGcYy_g_Xgft2u=hg9R_eqEsQ@mail.gmail.com>
2024-05-20 19:19 ` Ronak Doshi
2024-05-20 20:06 ` Simon Horman [this message]
2024-05-15 23:02 ` kernel test robot
2024-05-16 1:59 ` kernel test robot
2024-05-16 3:31 ` kernel test robot
2024-05-14 18:20 ` [PATCH net-next 3/4] vmxnet3: add command to allow disabling of offloads Ronak Doshi
2024-05-15 10:47 ` Simon Horman
2024-05-14 18:20 ` [PATCH net-next 4/4] vmxnet3: update to version 9 Ronak Doshi
2024-05-15 10:49 ` Simon Horman
2024-05-15 10:52 ` [PATCH net-next 0/4] vmxnet3: upgrade " Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240520200610.GD764145@kernel.org \
--to=horms@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ronak.doshi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.