Re: [LTP] [PATCH 2/3] lib: Add .skip_in_32bit

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > @@ -494,6 +497,7 @@ struct tst_ulimit_val {
> >  	unsigned int skip_in_lockdown:1;
> >  	unsigned int skip_in_secureboot:1;
> >  	unsigned int skip_in_compat:1;
> > +	unsigned int skip_in_32bit:1;

> I was thinking about this and maybe it would make more sense to make
> this more generic. If we ever need to add flags for a test to be skipped
> on 64bit ABI we would have to add another flag. One example would be an
> EOVERFLOW error from mmap() that can happen only on 32bit.

> So maybe it would make sense to change this to be .needs_abi_bits and
> the possible values would be 32 and 64.

.needs_abi_bits sounds good, I'll send v2.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp