From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: animesh.manna@intel.com, mika.kahola@intel.com,
"Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH v2 06/17] drm/i915/psr: Add Panel Replay support to intel_psr2_config_et_valid
Date: Tue, 21 May 2024 11:46:37 +0300 [thread overview]
Message-ID: <20240521084648.1987837-7-jouni.hogander@intel.com> (raw)
In-Reply-To: <20240521084648.1987837-1-jouni.hogander@intel.com>
Early Transport is possible and in our HW mandatory on eDP Panel
Replay. Add parameter to intel_psr2_config_et_valid to differentiate
validity check for Panel Replay.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 3884d88e1594..24d832dc26c7 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -673,16 +673,17 @@ static void hsw_psr_setup_aux(struct intel_dp *intel_dp)
aux_ctl);
}
-static bool psr2_su_region_et_valid(struct intel_dp *intel_dp)
+static bool psr2_su_region_et_valid(struct intel_dp *intel_dp, bool panel_replay)
{
struct drm_i915_private *i915 = dp_to_i915(intel_dp);
- if (DISPLAY_VER(i915) >= 20 &&
- intel_dp->psr_dpcd[0] == DP_PSR2_WITH_Y_COORD_ET_SUPPORTED &&
- !(intel_dp->psr.debug & I915_PSR_DEBUG_SU_REGION_ET_DISABLE))
- return true;
+ if (DISPLAY_VER(i915) < 20 || !intel_dp_is_edp(intel_dp) ||
+ intel_dp->psr.debug & I915_PSR_DEBUG_SU_REGION_ET_DISABLE)
+ return false;
- return false;
+ return panel_replay ?
+ intel_dp->pr_dpcd & DP_PANEL_REPLAY_EARLY_TRANSPORT_SUPPORT :
+ intel_dp->psr_dpcd[0] != DP_PSR2_WITH_Y_COORD_ET_SUPPORTED;
}
static unsigned int intel_psr_get_enable_sink_offset(struct intel_dp *intel_dp)
@@ -709,7 +710,8 @@ void intel_psr_enable_sink(struct intel_dp *intel_dp,
DP_ALPM_ENABLE |
DP_ALPM_LOCK_ERROR_IRQ_HPD_ENABLE);
- if (psr2_su_region_et_valid(intel_dp))
+ if (psr2_su_region_et_valid(intel_dp,
+ intel_dp->psr.panel_replay_enabled))
dpcd_val |= DP_PSR_ENABLE_SU_REGION_ET;
}
@@ -978,7 +980,8 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
PSR2_MAN_TRK_CTL(dev_priv, cpu_transcoder), 0);
}
- if (psr2_su_region_et_valid(intel_dp))
+ if (psr2_su_region_et_valid(intel_dp,
+ intel_dp->psr.panel_replay_enabled))
val |= LNL_EDP_PSR2_SU_REGION_ET_ENABLE;
/*
@@ -1587,7 +1590,7 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
tgl_dc3co_exitline_compute_config(intel_dp, crtc_state);
- if (psr2_su_region_et_valid(intel_dp))
+ if (psr2_su_region_et_valid(intel_dp, false))
crtc_state->enable_psr2_su_region_et = true;
return true;
--
2.34.1
next prev parent reply other threads:[~2024-05-21 8:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 8:46 [PATCH v2 00/17] Panel Replay eDP support Jouni Högander
2024-05-21 8:46 ` [PATCH v2 01/17] drm/i915/psr: Store pr_dpcd in intel_dp Jouni Högander
2024-05-24 5:55 ` Manna, Animesh
2024-05-24 6:18 ` Hogander, Jouni
2024-05-24 8:22 ` Manna, Animesh
2024-05-21 8:46 ` [PATCH v2 02/17] drm/panel replay: Add edp1.5 Panel Replay bits and register Jouni Högander
2024-05-21 8:46 ` [PATCH v2 03/17] drm/i915/psr: Move printing sink PSR support to own function Jouni Högander
2024-05-21 8:46 ` [PATCH v2 04/17] drm/i915/psr: Move printing PSR mode " Jouni Högander
2024-05-24 5:59 ` Manna, Animesh
2024-05-24 7:03 ` Hogander, Jouni
2024-05-21 8:46 ` [PATCH v2 05/17] drm/i915/psr: modify psr status debugfs to support eDP Panel Replay Jouni Högander
2024-05-21 8:46 ` Jouni Högander [this message]
2024-05-21 8:46 ` [PATCH v2 07/17] drm/i915/psr: Add Early Transport into psr debugfs interface Jouni Högander
2024-05-21 8:46 ` [PATCH v2 08/17] drm/display: Add missing aux less alpm wake related bits Jouni Högander
2024-05-21 8:46 ` [PATCH v2 09/17] drm/i915/psr: Check panel ALPM capability for eDP Panel Replay Jouni Högander
2024-05-21 8:46 ` [PATCH v2 10/17] drm/i915/psr: Inform Panel Replay source support on eDP as well Jouni Högander
2024-05-21 8:46 ` [PATCH v2 11/17] drm/i915/psr: enable sink for eDP1.5 Panel Replay Jouni Högander
2024-05-21 8:46 ` [PATCH v2 12/17] drm/i915/psr: Check panel Early Transport capability for eDP PR Jouni Högander
2024-05-21 8:46 ` [PATCH v2 13/17] drm/i915/psr: Perfrom psr2 checks related to ALPM for Panel Replay Jouni Högander
2024-05-21 8:46 ` [PATCH v2 14/17] drm/i915/psr: Check Early Transport for Panel Replay as well Jouni Högander
2024-05-21 8:46 ` [PATCH v2 15/17] drm/i915/psr: Modify dg2_activate_panel_replay to support eDP Jouni Högander
2024-05-21 8:46 ` [PATCH v2 16/17] drm/i915/psr: Add new debug bit to disable Panel Replay Jouni Högander
2024-05-21 8:46 ` [PATCH v2 17/17] Revert "drm/i915/psr: Disable early transport by default" Jouni Högander
2024-05-21 10:05 ` ✗ Fi.CI.CHECKPATCH: warning for Panel Replay eDP support (rev2) Patchwork
2024-05-21 10:05 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-21 10:17 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-22 4:31 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-24 5:53 ` [PATCH v2 00/17] Panel Replay eDP support Manna, Animesh
2024-05-24 7:03 ` Hogander, Jouni
2024-05-27 7:24 ` Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240521084648.1987837-7-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=animesh.manna@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.