All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Antonio Ojea <aojea@google.com>,
	netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCH v3 0/2] netfilter: nfqueue: incorrect sctp checksum
Date: Tue, 21 May 2024 12:51:24 +0200	[thread overview]
Message-ID: <20240521105124.GA29082@breakpoint.cc> (raw)
In-Reply-To: <Zkx8BCuu6dyTDjcX@calendula>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > I see, so I fixed the bug in one direction and regressed in the other
> > one, let me retest both things locallly
> 
> The check to force GSO SCTP to be segmented before being sent to
> userspace, my proposal:
> 
>               if (!skb_is_gso(skb) || ((queue->flags & NFQA_CFG_F_GSO) && !skb_is_gso_sctp(skb)))
>                         return __nfqnl_enqueue_packet(net, queue, entry);

This disables F_GSO with sctp packets, is sctp incompatible with nfqueue?

  reply	other threads:[~2024-05-21 10:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-13 22:00 [PATCH v3 0/2] netfilter: nfqueue: incorrect sctp checksum Antonio Ojea
2024-05-13 22:00 ` [PATCH v3 1/2] netfilter: nft_queue: compute SCTP checksum Antonio Ojea
2024-05-13 22:18   ` Florian Westphal
2024-05-13 22:00 ` [PATCH v3 2/2] selftests: net: netfilter: nft_queue.sh: sctp checksum Antonio Ojea
2024-05-13 22:18   ` Florian Westphal
2024-05-20 11:27 ` [PATCH v3 0/2] netfilter: nfqueue: incorrect " Pablo Neira Ayuso
2024-05-20 15:44   ` Pablo Neira Ayuso
2024-05-20 18:33     ` Pablo Neira Ayuso
2024-05-20 18:47       ` Pablo Neira Ayuso
2024-05-20 18:59         ` Antonio Ojea
2024-05-21 10:48           ` Pablo Neira Ayuso
2024-05-21 10:51             ` Florian Westphal [this message]
2024-05-21 12:07               ` Pablo Neira Ayuso
2024-05-21 12:48                 ` Florian Westphal
2024-05-21 12:58                   ` Pablo Neira Ayuso
2024-06-02 15:30                     ` Florian Westphal
2024-06-11  8:46                       ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240521105124.GA29082@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=aojea@google.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.