From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ken Milmore <ken.milmore@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: r8169: Crash with TX segmentation offload on RTL8125
Date: Wed, 22 May 2024 06:55:50 -0700 [thread overview]
Message-ID: <20240522065550.32d37359@kernel.org> (raw)
In-Reply-To: <75df2de0-9e32-475d-886c-0e65d7cfba1e@gmail.com>
On Fri, 17 May 2024 15:21:00 -0700 Florian Fainelli wrote:
> > The patch below fixes the problem, by simply reading nr_frags a bit later, after the checksum stage.
>
> Yeah, that's an excellent catch and one that is bitten us before, too:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=20d1f2d1b024f6be199a3bedf1578a1d21592bc5
>
> unclear what we would do in skb_shinfo() to help driver writers, rather
> than rely upon code inspection to find such bugs.
I wonder if we should add a "error injection" hook under DEBUG_NET
to force re-allocation of skbs in any helper which may cause it?
next prev parent reply other threads:[~2024-05-22 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 20:51 r8169: Crash with TX segmentation offload on RTL8125 Ken Milmore
2024-05-17 22:21 ` Florian Fainelli
2024-05-22 13:55 ` Jakub Kicinski [this message]
2024-05-22 14:01 ` Eric Dumazet
2024-07-18 20:02 ` Breno Leitao
2024-07-20 0:41 ` Jakub Kicinski
2024-05-19 19:46 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240522065550.32d37359@kernel.org \
--to=kuba@kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ken.milmore@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.