All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Liam Kearney <liam.kearney@canonical.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>, stable@vger.kernel.org
Subject: Re: [PATCH v2] crypto: arm64: use simd_skcipher_create() when registering aes internal algs
Date: Wed, 22 May 2024 06:18:54 +0200	[thread overview]
Message-ID: <2024052212-saved-manmade-9c8e@gregkh> (raw)
In-Reply-To: <20240522035837.18610-1-liam.kearney@canonical.com>

On Wed, May 22, 2024 at 01:58:37PM +1000, Liam Kearney wrote:
> The arm64 crypto drivers duplicate driver names when adding simd
> variants, which after backported commit 27016f75f5ed ("crypto: api -
> Disallow identical driver names"), causes an error that leads to the
> aes algs not being installed. On weaker processors this results in hangs
> due to falling back to SW crypto.

But that commit has already been reverted in the stable releases, right?

> Use simd_skcipher_create() as it will properly namespace the new algs.
> This issue does not exist in mainline/latest (and stable v6.1+) as the
> driver has been refactored to remove the simd algs from this code path.
> 
> Fixes: 27016f75f5ed ("crypto: api - Disallow identical driver names")
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: stable@vger.kernel.org
> Signed-off-by: Liam Kearney <liam.kearney@canonical.com>

What kernel tree(s) are you thinking this needs to go to?

thanks,

greg k-h

  reply	other threads:[~2024-05-22  4:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22  3:58 [PATCH v2] crypto: arm64: use simd_skcipher_create() when registering aes internal algs Liam Kearney
2024-05-22  4:18 ` Greg KH [this message]
2024-05-22  4:47   ` Liam Kearney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024052212-saved-manmade-9c8e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=liam.kearney@canonical.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.