From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Mike Rapoport <rppt@kernel.org>, Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>
Subject: [PATCH RFC 6/6] mm/mm_init: initialize page->_mapcount directly in__init_single_page()
Date: Wed, 22 May 2024 23:03:41 +0200 [thread overview]
Message-ID: <20240522210341.1030552-7-david@redhat.com> (raw)
In-Reply-To: <20240522210341.1030552-1-david@redhat.com>
Let's simply reinitialize the page->_mapcount directly. We can now
get rid of page_mapcount_reset().
Signed-off-by: David Hildenbrand <david@redhat.com>
---
include/linux/mm.h | 5 -----
include/linux/mm_types.h | 2 +-
mm/mm_init.c | 2 +-
3 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 018e7c0265ca..3e1d3b0d545e 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1206,11 +1206,6 @@ static inline int folio_entire_mapcount(const struct folio *folio)
return atomic_read(&folio->_entire_mapcount) + 1;
}
-static inline void page_mapcount_reset(struct page *page)
-{
- atomic_set(&(page)->_mapcount, -1);
-}
-
/**
* page_mapcount() - Number of times this precise page is mapped.
* @page: The page.
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index 6dae8e15037b..c377c040f87d 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -169,7 +169,7 @@ struct page {
* See page-flags.h for a list of page types which are currently
* stored here.
*
- * Owners of typed folios may reuse the lower 16bit of the
+ * Owners of typed folios may reuse the lower 16 bit of the
* head page page_type field after setting the page type,
* but must reset these 16 bit to -1 before clearing the
* page type.
diff --git a/mm/mm_init.c b/mm/mm_init.c
index f72b852bd5b8..b4916751edce 100644
--- a/mm/mm_init.c
+++ b/mm/mm_init.c
@@ -568,7 +568,7 @@ void __meminit __init_single_page(struct page *page, unsigned long pfn,
mm_zero_struct_page(page);
set_page_links(page, zone, nid, pfn);
init_page_count(page);
- page_mapcount_reset(page);
+ atomic_set(&page->_mapcount, -1);
page_cpupid_reset_last(page);
page_kasan_tag_reset(page);
--
2.45.0
prev parent reply other threads:[~2024-05-22 21:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 21:03 [PATCH RFC 0/6] mm: page_type, zsmalloc and page_mapcount_reset() David Hildenbrand
2024-05-22 21:03 ` [PATCH RFC 1/6] mm: update _mapcount and page_type documentation David Hildenbrand
2024-05-24 8:58 ` Mike Rapoport
2024-05-22 21:03 ` [PATCH RFC 2/6] mm: allow reuse of the lower 16bit of the page type with an actual type David Hildenbrand
2024-05-24 10:04 ` David Hildenbrand
2024-05-22 21:03 ` [PATCH RFC 3/6] mm/zsmalloc: use a proper page type David Hildenbrand
2024-05-23 14:55 ` David Hildenbrand
2024-05-23 20:38 ` David Hildenbrand
2024-05-24 8:52 ` Mike Rapoport
2024-05-22 21:03 ` [PATCH RFC 4/6] mm/page_alloc: clear PageBuddy using __ClearPageBuddy() for bad pages David Hildenbrand
2024-05-22 21:03 ` [PATCH RFC 5/6] mm/filemap: reinitialize folio->_mapcount directly David Hildenbrand
2024-05-22 21:03 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240522210341.1030552-7-david@redhat.com \
--to=david@redhat.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=rppt@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.