From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C0F613BC0C for ; Thu, 23 May 2024 11:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716465387; cv=none; b=Vru2scmSblKE0Gl5xk7E7uy16mp/rFtWm0ukak+cHPGWVVxPIXkHatUx6WGIDCLzXFbLTK+7vVwAuj3zDIkEUSOBCbe3LeU6p3jCYsqebmS24/+nrIxdE4u1nZ4Vcq8Kxw3fErSPx59RbrZqJ9crKu+BVCwEsL5SUDkAhC0n8aI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716465387; c=relaxed/simple; bh=TSfI3BBhH4SQXg15oTofZkSYvmFAtIJa1tOfLIcM9B0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jwTbr3TSrzjzqaH1Qx2obWs3Fgmq40ZAF2kFIxQYnSzK4GPs5KJ0axCbZY/R93LcPkwhR3umQtZmwowcsP0SNkAYyjJC38f5UXS7ujLeOQowz4gY0k86OunQIfaNmVkc66Ok+jWae3T908enWc0UKPSTTkMXXfq3/gzh/s0Y+zs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JKgGxXUw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JKgGxXUw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 270B5C2BD10; Thu, 23 May 2024 11:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716465386; bh=TSfI3BBhH4SQXg15oTofZkSYvmFAtIJa1tOfLIcM9B0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JKgGxXUws6sCt60RPWuz5taXnWtwkms5/6fpdduD3LQwOU2kJIKMiqBrTIbTv/J3V sly6G5AHSXiEGA6gQSxt2FrTIUCQGaVAX7WVzV20Jhh4t5tSzUIOrMFuMH6v9z7MQi g0XQptM31iLDqYq8dYkqFUwr4Q6yj5wflI+XM1UU= Date: Thu, 23 May 2024 13:56:23 +0200 From: Greg KH To: Oleksandr Tymoshenko Cc: Catalin Marinas , Will Deacon , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland Subject: Re: [PATCH 6.1] arm64: atomics: lse: remove stale dependency on JUMP_LABEL Message-ID: <2024052316-diaper-carless-bcdd@gregkh> References: <20240521-lse-atomics-6-1-v1-1-7aa6040fc6cd@google.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240521-lse-atomics-6-1-v1-1-7aa6040fc6cd@google.com> On Tue, May 21, 2024 at 02:51:29PM +0000, Oleksandr Tymoshenko wrote: > From: Mark Rutland > > [ Upstream commit 657eef0a5420a02c02945ed8c87f2ddcbd255772 ] > > Currently CONFIG_ARM64_USE_LSE_ATOMICS depends upon CONFIG_JUMP_LABEL, > as the inline atomics were indirected with a static branch. > > However, since commit: > > 21fb26bfb01ffe0d ("arm64: alternatives: add alternative_has_feature_*()") > > ... we use an alternative_branch (which is always available) rather than > a static branch, and hence the dependency is unnecessary. > > Remove the stale dependency, along with the stale include. This will > allow the use of LSE atomics in kernels built with CONFIG_JUMP_LABEL=n, > and reduces the risk of circular header dependencies via . > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Will Deacon > Link: https://lore.kernel.org/r/20221114125424.2998268-1-mark.rutland@arm.com > Signed-off-by: Will Deacon > Signed-off-by: Oleksandr Tymoshenko > --- > arch/arm64/Kconfig | 1 - > arch/arm64/include/asm/lse.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index c15f71501c6c..044b98a62f7b 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1752,7 +1752,6 @@ config ARM64_LSE_ATOMICS > > config ARM64_USE_LSE_ATOMICS > bool "Atomic instructions" > - depends on JUMP_LABEL > default y > help > As part of the Large System Extensions, ARMv8.1 introduces new > diff --git a/arch/arm64/include/asm/lse.h b/arch/arm64/include/asm/lse.h > index c503db8e73b0..f99d74826a7e 100644 > --- a/arch/arm64/include/asm/lse.h > +++ b/arch/arm64/include/asm/lse.h > @@ -10,7 +10,6 @@ > > #include > #include > -#include > #include > #include > #include > > --- > base-commit: 4078fa637fcd80c8487680ec2e4ef7c58308e9aa > change-id: 20240521-lse-atomics-6-1-b0960e206035 > > Best regards, > -- > Oleksandr Tymoshenko > > Now queued up, thanks. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2175C25B75 for ; Thu, 23 May 2024 11:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0NDdredNxTjfaNBNKdwqMcYwY8df7yPitCSbhUSTXaE=; b=pherxxJGYXQwnj X2jNCrmjLtHHkzmrdwhAqAqMsHgQTEoTWb/PBfs6CIYE9VwrLWLWbvF7i7gnRjP1wX/KyAQq7Cpa8 l2gHnjcYHSwWEvFJx9tpH1Z6EarVGGFow7MhPhl0+/YOp6QTzsnmsw3WUW1C81BbIVCejme/bAUnQ aFpk8gDoQ5/+vp1IQcQIIq4zpsLpkAP4bh3ZwWoGw+sNFz58rZo6MyjLQuKvhrcCOtlLFbLVk7MSQ Pf30FXmmVWHSM8DWOLAuGEbiqh3kpm2I3pdGtlF3GQnH7YuSGERBuMAbVTkOr6L0YuvGFyokb8dzJ ea6FXd8YhM7G+RiYaxeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sA73i-000000066Yy-3rXL; Thu, 23 May 2024 11:56:34 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sA73f-000000066Xg-3kAI for linux-arm-kernel@lists.infradead.org; Thu, 23 May 2024 11:56:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 456FBCE1395; Thu, 23 May 2024 11:56:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 270B5C2BD10; Thu, 23 May 2024 11:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1716465386; bh=TSfI3BBhH4SQXg15oTofZkSYvmFAtIJa1tOfLIcM9B0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JKgGxXUws6sCt60RPWuz5taXnWtwkms5/6fpdduD3LQwOU2kJIKMiqBrTIbTv/J3V sly6G5AHSXiEGA6gQSxt2FrTIUCQGaVAX7WVzV20Jhh4t5tSzUIOrMFuMH6v9z7MQi g0XQptM31iLDqYq8dYkqFUwr4Q6yj5wflI+XM1UU= Date: Thu, 23 May 2024 13:56:23 +0200 From: Greg KH To: Oleksandr Tymoshenko Cc: Catalin Marinas , Will Deacon , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland Subject: Re: [PATCH 6.1] arm64: atomics: lse: remove stale dependency on JUMP_LABEL Message-ID: <2024052316-diaper-carless-bcdd@gregkh> References: <20240521-lse-atomics-6-1-v1-1-7aa6040fc6cd@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240521-lse-atomics-6-1-v1-1-7aa6040fc6cd@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240523_045632_370322_A8897B66 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 21, 2024 at 02:51:29PM +0000, Oleksandr Tymoshenko wrote: > From: Mark Rutland > > [ Upstream commit 657eef0a5420a02c02945ed8c87f2ddcbd255772 ] > > Currently CONFIG_ARM64_USE_LSE_ATOMICS depends upon CONFIG_JUMP_LABEL, > as the inline atomics were indirected with a static branch. > > However, since commit: > > 21fb26bfb01ffe0d ("arm64: alternatives: add alternative_has_feature_*()") > > ... we use an alternative_branch (which is always available) rather than > a static branch, and hence the dependency is unnecessary. > > Remove the stale dependency, along with the stale include. This will > allow the use of LSE atomics in kernels built with CONFIG_JUMP_LABEL=n, > and reduces the risk of circular header dependencies via . > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Will Deacon > Link: https://lore.kernel.org/r/20221114125424.2998268-1-mark.rutland@arm.com > Signed-off-by: Will Deacon > Signed-off-by: Oleksandr Tymoshenko > --- > arch/arm64/Kconfig | 1 - > arch/arm64/include/asm/lse.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index c15f71501c6c..044b98a62f7b 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1752,7 +1752,6 @@ config ARM64_LSE_ATOMICS > > config ARM64_USE_LSE_ATOMICS > bool "Atomic instructions" > - depends on JUMP_LABEL > default y > help > As part of the Large System Extensions, ARMv8.1 introduces new > diff --git a/arch/arm64/include/asm/lse.h b/arch/arm64/include/asm/lse.h > index c503db8e73b0..f99d74826a7e 100644 > --- a/arch/arm64/include/asm/lse.h > +++ b/arch/arm64/include/asm/lse.h > @@ -10,7 +10,6 @@ > > #include > #include > -#include > #include > #include > #include > > --- > base-commit: 4078fa637fcd80c8487680ec2e4ef7c58308e9aa > change-id: 20240521-lse-atomics-6-1-b0960e206035 > > Best regards, > -- > Oleksandr Tymoshenko > > Now queued up, thanks. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel