From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 747D4DDBB for ; Thu, 23 May 2024 15:14:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716477246; cv=none; b=V+H9n4zdEHkmJbCalqjtyxfAXEGuyeQlSPW8uKygPU2E96JXBvebuUFFYFcjAjeHmGJSZ2++iE9gcKuHvfeKYlJZ07Px/0ARDvK/tmu+GNsDOXDD/UGHi1v4voLgZmHLQGph9QDUdqANATkE4Ndj+7a+/uXAKaCJ5KPh6ApR77I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716477246; c=relaxed/simple; bh=SQE2i0yMAkLmu1dTnE6gJPQncGEH1UEWiMQDHn0szng=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H3aA1NLKg9hVjju77RijQ2vTwF45fdxar1G1GfGebvPHrbCGJKWfRD4dmd76Mf5K2Wy/c2r9MFDDHRJ5QbqJfmqSINk/VjgN5Kx13YKooiCEiIr/TZGcq652nG1WAWYmCgEm6r8IVi1KBc9sRA4czvVTsMReNnJqUCnnfiJkRt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VlWnP1XzHz6JB16; Thu, 23 May 2024 23:10:17 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 9467D140A1B; Thu, 23 May 2024 23:13:59 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 23 May 2024 16:13:59 +0100 Date: Thu, 23 May 2024 16:13:57 +0100 From: Jonathan Cameron To: Zaid Alali CC: , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v2 3/8] ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type Message-ID: <20240523161357.00007532@Huawei.com> In-Reply-To: <20240521211036.227674-4-zaidal@os.amperecomputing.com> References: <20240521211036.227674-1-zaidal@os.amperecomputing.com> <20240521211036.227674-4-zaidal@os.amperecomputing.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: acpica-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) On Tue, 21 May 2024 14:10:31 -0700 Zaid Alali wrote: > A single call to einj_get_available_error_type in init function is > sufficient to save the return value in a global variable to be used > later in various places in the code. This commit does not introduce > any functional changes, but only removing unnecessary redundant > function calls. > > Signed-off-by: Zaid Alali Seems reasonable to me. Reviewed-by: Jonathan Cameron