From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: ranechita <ramona.nechita@analog.com>,
<linux-iio@vger.kernel.org>, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: iio: adc: add a7779 doc
Date: Thu, 23 May 2024 18:03:52 +0100 [thread overview]
Message-ID: <20240523180352.0000623b@Huawei.com> (raw)
In-Reply-To: <efb07835-8894-43d0-9fe1-14cb865db135@kernel.org>
On Wed, 22 May 2024 15:33:56 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
Typo in the patch title.. dt-bindings: iio: adc: add ad7779
> On 22/05/2024 14:01, ranechita wrote:
> > Add dt bindings for adc ad7779.
Good to provide a very brief intro here to the device.
> >
> > Signed-off-by: ranechita <ramona.nechita@analog.com>
>
> Are you sure that's the name or identity you want to use? Looks like
> misconfigured git...
>
> > ---
> > .../ABI/testing/sysfs-bus-iio-adc-ad777x | 23 +++++
> > .../bindings/iio/adc/adi,ad7779.yaml | 93 +++++++++++++++++++
>
> Where is any user of it?
> ...
>
> > +
> > + clock-names:
> > + items:
> > + - const: adc-clk
>
> Drop names, it repeats what's obvious.
>
>
> Best regards,
> Krzysztof
>
>
next prev parent reply other threads:[~2024-05-23 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 12:01 [PATCH] dt-bindings: iio: adc: add a7779 doc ranechita
2024-05-22 13:33 ` Krzysztof Kozlowski
2024-05-23 17:03 ` Jonathan Cameron [this message]
2024-05-29 15:25 ` Nechita, Ramona
2024-05-31 7:45 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240523180352.0000623b@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramona.nechita@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.