Re: [PATCH 6.1 01/24] xfs: write page faults in iomap are not buffered writes

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, May 22, 2024 at 02:55:18PM -0700, Leah Rumancik wrote:
> On Wed, May 22, 2024 at 7:11 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, May 06, 2024 at 10:52:16AM -0700, Leah Rumancik wrote:
> > > Ah my bad, I'll make sure to explicitly mention its been ACK'd by
> > > linux-xfs in the future.
> > >
> > > Will send out a MAINTAINERS file patch as well.
> >
> > Did that happen?
> 
> Yep, https://lore.kernel.org/all/Zj9xj1wIzlTK8VCm@sashalap/
> 
> >
> > Anyway, this patch series breaks the build:
> >
> > s/xfs/xfs_iomap.c: In function ‘xfs_iomap_inode_sequence’:
> > fs/xfs/xfs_iomap.c:58:27: error: ‘IOMAP_F_XATTR’ undeclared (first use in this function); did you mean ‘IOP_XATTR’?
> >    58 |         if (iomap_flags & IOMAP_F_XATTR)
> >       |                           ^~~~~~~~~~~~~
> >       |                           IOP_XATTR
> > fs/xfs/xfs_iomap.c:58:27: note: each undeclared identifier is reported only once for each function it appears in
> > fs/xfs/xfs_iomap.c: In function ‘xfs_iomap_valid’:
> > fs/xfs/xfs_iomap.c:74:21: error: ‘const struct iomap’ has no member named ‘validity_cookie’
> >    74 |         return iomap->validity_cookie ==
> >       |                     ^~
> > fs/xfs/xfs_iomap.c: At top level:
> > fs/xfs/xfs_iomap.c:79:10: error: ‘const struct iomap_page_ops’ has no member named ‘iomap_valid’
> >    79 |         .iomap_valid            = xfs_iomap_valid,
> >       |          ^~~~~~~~~~~
> > fs/xfs/xfs_iomap.c:79:35: error: positional initialization of field in ‘struct’ declared with ‘designated_init’ attribute [-Werror=designated-init]
> >    79 |         .iomap_valid            = xfs_iomap_valid,
> >       |                                   ^~~~~~~~~~~~~~~
> > fs/xfs/xfs_iomap.c:79:35: note: (near initialization for ‘xfs_iomap_page_ops’)
> > fs/xfs/xfs_iomap.c:79:35: error: invalid initializer
> > fs/xfs/xfs_iomap.c:79:35: note: (near initialization for ‘xfs_iomap_page_ops.<anonymous>’)
> > fs/xfs/xfs_iomap.c: In function ‘xfs_bmbt_to_iomap’:
> > fs/xfs/xfs_iomap.c:127:14: error: ‘struct iomap’ has no member named ‘validity_cookie’
> >   127 |         iomap->validity_cookie = sequence_cookie;
> >       |              ^~
> > fs/xfs/xfs_iomap.c: In function ‘xfs_xattr_iomap_begin’:
> > fs/xfs/xfs_iomap.c:1375:44: error: ‘IOMAP_F_XATTR’ undeclared (first use in this function); did you mean ‘IOP_XATTR’?
> >  1375 |         seq = xfs_iomap_inode_sequence(ip, IOMAP_F_XATTR);
> >       |                                            ^~~~~~~~~~~~~
> >       |                                            IOP_XATTR
> > fs/xfs/xfs_iomap.c:1382:1: error: control reaches end of non-void function [-Werror=return-type]
> >  1382 | }
> >       | ^
> > cc1: all warnings being treated as errors
> >
> >
> > Any chance you can rebase and resend it?
> >
> 
> Will do.

Nope, this was my fault, the original series here is fine!

Sorry for the noise, I'll go queue it up now.

greg k-h