From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34EA5381C6 for ; Fri, 24 May 2024 19:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716577821; cv=none; b=SEkRzXMCoxqZ/yNAInanHo/I6paVf7rIxOdlhNzkr3JA9RsWz88b934vEfvtOVq/pHMhvp5+iR1tUAsVhNNQoiUgx64cxxB5K3INTxsm/2veiLZ8SULQwj5BsCOXXmvfx0KUPAdo/N9h+jEyVnaYhEPAFNfmrqm3PwCQ9IUT9y8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716577821; c=relaxed/simple; bh=qRfM4TU7sRQJ/7eeA6XN0y8uQdtXege7cNrMTDXXWso=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bh+9arXRSWRotAApKyYsB/35MfHQJocYdoj9zzuk14dIpLROU4H3RwuSshOF7BsKSycfa4DCkFmtMMlkA32JbtAwlJNV0uyGtnZk6xpAWZf99ylQxhnbKesOvKTDcHMkToGzHMFifQR4HE+n4cmhe1QJ17k08ozhvSs5KoW08F4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bd+MzVyG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bd+MzVyG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFE6AC2BBFC; Fri, 24 May 2024 19:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716577820; bh=qRfM4TU7sRQJ/7eeA6XN0y8uQdtXege7cNrMTDXXWso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bd+MzVyGeSBmeWqjwO4x7j6KpuGsANl+9m8m1Emwh/XdOKy4QSutbnOlTvsgznLWt QdfVw1cqaiuHXyGtLueE7PuqP2diE2W/4UgXTKG60OV+MrOyaFMZ5AGMv+ooVhgiMf 11ObI3ROLz0n/MLRyQdiEgHHW/iuFXnr5LYf4LKyroDrVMwuEkqwL6MEiovPPfq8MW GWi/ayO90Y+WQ39y0B/dAf3PNjoSPfMDVsr7TlWOX2VKE6Bej+osCto258/GvV1uhb qunoYYecIcsCoj1QIcPv5y9tlqGN2X/WQCog6+RS2fYAs/TGrJxLSL3YuKvNgE8mMO 7eX75PvJm9Iag== Date: Fri, 24 May 2024 20:10:15 +0100 From: Conor Dooley To: Ryan Walklin Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Neil Armstrong , Jessica Zhang , Sam Ravnborg , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hironori KIKUCHI , Chris Morgan Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel Message-ID: <20240524-purveyor-outlying-5201f700a56e@spud> References: <20240524103506.187277-1-ryan@testtoast.com> <20240524103506.187277-2-ryan@testtoast.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pLrOJBoAnsXYyrmH" Content-Disposition: inline In-Reply-To: <20240524103506.187277-2-ryan@testtoast.com> --pLrOJBoAnsXYyrmH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 24, 2024 at 10:33:13PM +1200, Ryan Walklin wrote: > The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown > OEM, used in a number of handheld gaming devices made by Anbernic. >=20 > Add a device tree binding for the panel. >=20 > Signed-off-by: Ryan Walklin > --- > .../bindings/display/panel/wl-355608-a8.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/wl-35= 5608-a8.yaml >=20 > diff --git a/Documentation/devicetree/bindings/display/panel/wl-355608-a8= =2Eyaml b/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml > new file mode 100644 > index 000000000..af12303e2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel > + > +maintainers: > + - Ryan Walklin > + > +allOf: > + - $ref: panel-common.yaml# > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +properties: > + compatible: > + const: wl-355608-a8 You're missing a vendor prefix here. And when you add it, update the filename to match. > + > + reg: > + maxItems: 1 > + > + spi-3wire: true > + > +required: > + - compatible > + - reg > + - port > + - power-supply > + - reset-gpios > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + > + spi_lcd: spi { > + compatible =3D "spi-gpio"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + sck-gpios =3D <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9 > + mosi-gpios =3D <&pio 8 10 GPIO_ACTIVE_HIGH>; // PI10 > + cs-gpios =3D <&pio 8 8 GPIO_ACTIVE_HIGH>; // PI8 > + num-chipselects =3D <1>; All of this is not needed in the example, all you need to have here is: spi { #address-cells =3D <1>; #size-cells =3D <0>; > + > + panel: panel@0 { This "panel" label is not used, you should drop it. > + compatible =3D "wl_355608_a8"; This doesn't match what you documented, be sure to run dt_binding_check. > + reg =3D <0>; > + > + spi-3wire; > + spi-max-frequency =3D <3125000>; > + > + reset-gpios =3D <&pio 8 14 GPIO_ACTIVE_LOW>; // PI14 > + > + backlight =3D <&backlight>; > + power-supply =3D <®_lcd>; > + pinctrl-0 =3D <&lcd0_rgb888_pins>; > + pinctrl-names =3D "default"; > + > + port { > + panel_in_rgb: endpoint { Neither is this label afaict. Thanks, Conor. > + remote-endpoint =3D <&tcon_lcd0_out_lcd>; > + }; > + }; > + }; > + }; > --=20 > 2.45.1 >=20 --pLrOJBoAnsXYyrmH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZlDmFwAKCRB4tDGHoIJi 0sJlAPsHIXJ5RW+GGQGLu1zyH7U8LPyVW3Yh9QRjxnQie6ur3gEAzLG3B8OasbR3 qS9DRp/1m6iEAvWbi+M9HxIMetDHbwk= =qrd6 -----END PGP SIGNATURE----- --pLrOJBoAnsXYyrmH--