From: Michael Estner <michaelestner@web.de>
To: phil@nwl.cc
Cc: netfilter-devel@vger.kernel.org, Michael Estner <michaelestner@web.de>
Subject: [PATCH] iptables: cleanup FIXME
Date: Fri, 24 May 2024 15:24:52 +0200 [thread overview]
Message-ID: <20240524132452.84195-2-michaelestner@web.de> (raw)
In-Reply-To: <20240524132452.84195-1-michaelestner@web.de>
Rework FIXME since struct ebt_entry has no flags var.
Use variable bitmask instead.
Update the debug output.
Signed-off-by: Michael Estner <michaelestner@web.de>
---
iptables/nft-bridge.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/iptables/nft-bridge.c b/iptables/nft-bridge.c
index 922ce983..f4a3c69a 100644
--- a/iptables/nft-bridge.c
+++ b/iptables/nft-bridge.c
@@ -373,9 +373,9 @@ static bool nft_bridge_is_same(const struct iptables_command_state *cs_a,
int i;
if (a->ethproto != b->ethproto ||
- /* FIXME: a->flags != b->flags || */
+ a->bitmask != b->bitmask ||
a->invflags != b->invflags) {
- DEBUGP("different proto/flags/invflags\n");
+ DEBUGP("different proto/bitmask/invflags\n");
return false;
}
--
2.25.1
next prev parent reply other threads:[~2024-05-24 13:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Zk9yrd8Ji1xAcblw>
2024-05-24 13:24 ` [PATCH] iptables: cleanup FIXME Michael Estner
2024-05-24 13:24 ` Michael Estner [this message]
2024-05-26 9:50 ` Phil Sutter
2024-05-23 14:50 Michael Estner
2024-05-23 16:45 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240524132452.84195-2-michaelestner@web.de \
--to=michaelestner@web.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.