Re: [PATCH] crypto: x86/aesni - Update aesni_set_key() to return void

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240311213232.128240-1-chang.seok.bae@intel.com>
References: <20240311213232.128240-1-chang.seok.bae@intel.com>
TO: "Chang S. Bae" <chang.seok.bae@intel.com>

Hi Chang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on v6.9]
[cannot apply to herbert-cryptodev-2.6/master herbert-crypto-2.6/master linus/master next-20240523]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chang-S-Bae/crypto-x86-aesni-Update-aesni_set_key-to-return-void/20240523-071024
base:   v6.9
patch link:    https://lore.kernel.org/r/20240311213232.128240-1-chang.seok.bae%40intel.com
patch subject: [PATCH] crypto: x86/aesni - Update aesni_set_key() to return void
:::::: branch date: 31 hours ago
:::::: commit date: 31 hours ago
config: x86_64-randconfig-161-20240524 (https://download.01.org/0day-ci/archive/20240524/202405241440.ksMTxyPy-lkp@intel.com/config)
compiler: gcc-11 (Ubuntu 11.4.0-4ubuntu1) 11.4.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202405241440.ksMTxyPy-lkp@intel.com/

smatch warnings:
arch/x86/crypto/aesni-intel_glue.c:248 aes_set_key_common() error: uninitialized symbol 'err'.

vim +/err +248 arch/x86/crypto/aesni-intel_glue.c

e12a68b3c6ac2c Chang S. Bae   2023-09-28  230  
28b776098379fb Eric Biggers   2023-07-14  231  static int aes_set_key_common(struct crypto_aes_ctx *ctx,
54b6a1bd5364ac Huang Ying     2009-01-18  232  			      const u8 *in_key, unsigned int key_len)
54b6a1bd5364ac Huang Ying     2009-01-18  233  {
54b6a1bd5364ac Huang Ying     2009-01-18  234  	int err;
54b6a1bd5364ac Huang Ying     2009-01-18  235  
54b6a1bd5364ac Huang Ying     2009-01-18  236  	if (key_len != AES_KEYSIZE_128 && key_len != AES_KEYSIZE_192 &&
674f368a952c48 Eric Biggers   2019-12-30  237  	    key_len != AES_KEYSIZE_256)
54b6a1bd5364ac Huang Ying     2009-01-18  238  		return -EINVAL;
54b6a1bd5364ac Huang Ying     2009-01-18  239  
f2abe0d72b2167 Eric Biggers   2019-03-12  240  	if (!crypto_simd_usable())
2c53fd11f76246 Ard Biesheuvel 2019-07-02  241  		err = aes_expandkey(ctx, in_key, key_len);
54b6a1bd5364ac Huang Ying     2009-01-18  242  	else {
54b6a1bd5364ac Huang Ying     2009-01-18  243  		kernel_fpu_begin();
36ac212f978e58 Chang S. Bae   2024-03-11  244  		aesni_set_key(ctx, in_key, key_len);
54b6a1bd5364ac Huang Ying     2009-01-18  245  		kernel_fpu_end();
54b6a1bd5364ac Huang Ying     2009-01-18  246  	}
54b6a1bd5364ac Huang Ying     2009-01-18  247  
54b6a1bd5364ac Huang Ying     2009-01-18 @248  	return err;
54b6a1bd5364ac Huang Ying     2009-01-18  249  }
54b6a1bd5364ac Huang Ying     2009-01-18  250  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki