From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, shinichiro.kawasaki@wdc.com,
hch@lst.de, sagi@grimberg.me, axboe@kernel.dk,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv3] nvme: use srcu for iterating namespace list
Date: Fri, 24 May 2024 18:43:45 +0200 [thread overview]
Message-ID: <20240524164345.GC21444@lst.de> (raw)
In-Reply-To: <20240524155345.243814-1-kbusch@meta.com>
> -static inline bool nvme_get_ns(struct nvme_ns *ns)
> +bool nvme_get_ns(struct nvme_ns *ns)
> {
> return kref_get_unless_zero(&ns->kref);
> }
> +EXPORT_SYMBOL_NS_GPL(nvme_get_ns, NVME_TARGET_PASSTHRU);
What actually needs the export in nvmet? AFAICS the export only grows
a new user in ioctl.c.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-05-24 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 15:53 [PATCHv3] nvme: use srcu for iterating namespace list Keith Busch
2024-05-24 16:43 ` Christoph Hellwig [this message]
2024-05-28 17:15 ` Keith Busch
2024-05-26 13:53 ` Sagi Grimberg
2024-05-27 13:15 ` Shinichiro Kawasaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240524164345.GC21444@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.