From: kernel test robot <lkp@intel.com>
To: Qais Yousef <qyousef@layalina.io>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [qais-yousef:uclamp-max-aggregation 13/13] kernel/sched/core.c:4914:21: error: implicit declaration of function '__ignore_task_perf'
Date: Sat, 25 May 2024 04:13:26 +0800 [thread overview]
Message-ID: <202405250438.YmaypNVh-lkp@intel.com> (raw)
tree: https://github.com/qais-yousef/linux uclamp-max-aggregation
head: 3173a853e6c16e1dcb09d392ef1e9b5a06448696
commit: 3173a853e6c16e1dcb09d392ef1e9b5a06448696 [13/13] sched: Make iowait boost per task
config: alpha-allnoconfig (https://download.01.org/0day-ci/archive/20240525/202405250438.YmaypNVh-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240525/202405250438.YmaypNVh-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405250438.YmaypNVh-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/export.h:5,
from include/linux/linkage.h:7,
from include/linux/fs.h:5,
from include/linux/highmem.h:5,
from kernel/sched/core.c:9:
kernel/sched/core.c: In function 'update_cpufreq_ctx_switch':
kernel/sched/core.c:4906:37: error: 'struct cfs_rq' has no member named 'decayed'
4906 | if (unlikely(rq->cfs.decayed)) {
| ^
include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
kernel/sched/core.c:4907:32: error: 'struct cfs_rq' has no member named 'decayed'
4907 | rq->cfs.decayed = false;
| ^
>> kernel/sched/core.c:4914:21: error: implicit declaration of function '__ignore_task_perf' [-Werror=implicit-function-declaration]
4914 | if (__ignore_task_perf(current))
| ^~~~~~~~~~~~~~~~~~
>> kernel/sched/core.c:4918:30: error: implicit declaration of function '__uclamp_eff_value'; did you mean 'uclamp_eff_value'? [-Werror=implicit-function-declaration]
4918 | uclamp_min = __uclamp_eff_value(current, UCLAMP_MIN);
| ^~~~~~~~~~~~~~~~~~
| uclamp_eff_value
kernel/sched/core.c:4920:34: error: 'struct cfs_rq' has no member named 'avg'
4920 | rq_util = rq->cfs.avg.util_avg;
| ^
cc1: some warnings being treated as errors
vim +/__ignore_task_perf +4914 kernel/sched/core.c
4887
4888 static inline void update_cpufreq_ctx_switch(struct rq *rq)
4889 {
4890 if (unlikely(current->sched_class == &stop_sched_class))
4891 return;
4892
4893 if (unlikely(current->sched_class == &idle_sched_class))
4894 return;
4895
4896 if (unlikely(task_has_idle_policy(current)))
4897 return;
4898
4899 if (likely(fair_policy(current->policy))) {
4900 unsigned long uclamp_min, uclamp_max;
4901 unsigned long rq_util;
4902
4903 /*
4904 * Allow cpufreq updates once for every update_load_avg() decay.
4905 */
4906 if (unlikely(rq->cfs.decayed)) {
4907 rq->cfs.decayed = false;
4908 goto force_update;
4909 }
4910
4911 if (unlikely(current->in_iowait))
4912 goto force_update;
4913
> 4914 if (__ignore_task_perf(current))
4915 return;
4916
4917 /* Force an update if perf hints are required to be applied */
> 4918 uclamp_min = __uclamp_eff_value(current, UCLAMP_MIN);
4919 uclamp_max = __uclamp_eff_value(current, UCLAMP_MAX);
4920 rq_util = rq->cfs.avg.util_avg;
4921
4922 if (uclamp_min > rq_util || uclamp_max < rq_util)
4923 goto force_update;
4924
4925 return;
4926 }
4927
4928 /* RT and DL should always send a freq update */
4929
4930 /* XXX ignore updates for sugov worker thread */
4931
4932 force_update:
4933
4934 /*
4935 * Request freq update after __balance_callbacks to take into account
4936 * any changes to rq.
4937 */
4938 cpufreq_update_util(rq, 0);
4939 }
4940
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-05-24 20:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405250438.YmaypNVh-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=qyousef@layalina.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.