All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kent Gibson <warthog618@gmail.com>
To: linux-gpio@vger.kernel.org, brgl@bgdev.pl
Cc: Kent Gibson <warthog618@gmail.com>
Subject: [libgpiod][PATCH 2/2] bindings: python: fix python-tests-run make target
Date: Sun, 26 May 2024 19:32:34 +0800	[thread overview]
Message-ID: <20240526113234.253859-3-warthog618@gmail.com> (raw)
In-Reply-To: <20240526113234.253859-1-warthog618@gmail.com>

The python-tests-run target is broken as it does not correctly split
lines.  It also calls Python directly rather then through the $PYTHON
variable.

Fix the line splitting and call Python using the $PYTHON variable.

Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
 bindings/python/Makefile.am | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/bindings/python/Makefile.am b/bindings/python/Makefile.am
index 65964c7..c14a6d4 100644
--- a/bindings/python/Makefile.am
+++ b/bindings/python/Makefile.am
@@ -13,10 +13,10 @@ python-tests:
 	$(PYTHON) build_tests.py
 
 python-tests-run:
-	PYTHONPATH=$(abs_top_srcdir)/bindings/python
+	PYTHONPATH=$(abs_top_srcdir)/bindings/python \
 	LD_LIBRARY_PATH=$(abs_top_builddir)/lib/.libs/:\
-		$(abs_top_builddir)/tests/gpiosim/.libs/ \
-	python3 -B -m tests
+	$(abs_top_builddir)/tests/gpiosim/.libs/ \
+	$(PYTHON) -B -m tests
 
 else
 
-- 
2.39.2


  parent reply	other threads:[~2024-05-26 11:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-26 11:32 [libgpiod][PATCH 0/2] bindings: python: fix running tests via Makefile Kent Gibson
2024-05-26 11:32 ` [libgpiod][PATCH 1/2] bindings: python: add Testing section to README Kent Gibson
2024-05-26 11:32 ` Kent Gibson [this message]
2024-05-28  9:14 ` [libgpiod][PATCH 0/2] bindings: python: fix running tests via Makefile Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240526113234.253859-3-warthog618@gmail.com \
    --to=warthog618@gmail.com \
    --cc=brgl@bgdev.pl \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.